linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vincent.guittot@linaro.org (Vincent Guittot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/14] sched: filter task pull request
Date: Thu, 25 Apr 2013 19:23:27 +0200	[thread overview]
Message-ID: <1366910611-20048-12-git-send-email-vincent.guittot@linaro.org> (raw)
In-Reply-To: <1366910611-20048-1-git-send-email-vincent.guittot@linaro.org>

Only CPUs that participates to the packing effort can pull tasks on a busiest
group.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/fair.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 28f8ea7..6f63fb9 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3494,6 +3494,12 @@ static bool is_buddy_full(int cpu)
 	return (sum * 1024 >= period * 1000);
 }
 
+static bool is_my_buddy(int cpu, int buddy)
+{
+	int my_buddy = per_cpu(sd_pack_buddy, cpu);
+	return (my_buddy == -1) || (buddy == my_buddy);
+}
+
 static bool is_light_task(struct task_struct *p)
 {
 	/* A light task runs less than 20% in average */
@@ -4688,8 +4694,8 @@ static inline void update_sg_lb_stats(struct lb_env *env,
 
 		/* Bias balancing toward cpus of our domain */
 		if (local_group) {
-			if (idle_cpu(i) && !first_idle_cpu &&
-					cpumask_test_cpu(i, sched_group_mask(group))) {
+			if (is_my_buddy(i, i) && idle_cpu(i) && !first_idle_cpu
+			 && cpumask_test_cpu(i, sched_group_mask(group))) {
 				first_idle_cpu = 1;
 				balance_cpu = i;
 			}
@@ -4817,6 +4823,10 @@ static void update_plb_buddy(int cpu, int *balance, struct sd_lb_stats *sds,
 
 	/* Get my new buddy */
 	buddy = per_cpu(sd_pack_buddy, cpu);
+
+	/* This CPU doesn't act for agressive packing */
+	if (buddy != cpu)
+		sds->busiest = 0;
 }
 
 /**
-- 
1.7.9.5

  parent reply	other threads:[~2013-04-25 17:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 17:23 [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-25 17:23 ` [PATCH 01/14] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Vincent Guittot
2013-04-25 17:23 ` [PATCH 02/14] sched: add a new SD_SHARE_POWERDOMAIN flag for sched_domain Vincent Guittot
2013-04-25 17:23 ` [PATCH 03/14] sched: pack small tasks Vincent Guittot
2013-04-26 12:30   ` Peter Zijlstra
2013-04-26 13:16     ` Vincent Guittot
2013-04-26 12:38   ` Peter Zijlstra
2013-04-26 13:38     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 04/14] sched: pack the idle load balance Vincent Guittot
2013-04-26 12:49   ` Peter Zijlstra
2013-04-26 13:47     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 05/14] ARM: sched: clear SD_SHARE_POWERDOMAIN Vincent Guittot
2013-04-25 17:23 ` [PATCH 06/14] sched: add a knob to choose the packing level Vincent Guittot
2013-04-25 17:23 ` [PATCH 07/14] sched: agressively pack at wake/fork/exec Vincent Guittot
2013-04-26 13:08   ` Peter Zijlstra
2013-04-26 14:23     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 08/14] sched: trig ILB on an idle buddy Vincent Guittot
2013-04-26 13:15   ` Peter Zijlstra
2013-04-26 14:52     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 09/14] sched: evaluate the activity level of the system Vincent Guittot
2013-05-22 16:50   ` Morten Rasmussen
2013-05-23  8:11     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 10/14] sched: update the buddy CPU Vincent Guittot
2013-04-28  8:20   ` Francesco Lavra
2013-04-29  7:32     ` Vincent Guittot
2013-04-25 17:23 ` Vincent Guittot [this message]
2013-04-26 10:00   ` [PATCH 11/14] sched: filter task pull request Vincent Guittot
2013-05-22 15:56     ` Morten Rasmussen
2013-05-22 16:03       ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 12/14] sched: create a new field with available capacity Vincent Guittot
2013-04-25 17:23 ` [PATCH 13/14] sched: update the cpu_power Vincent Guittot
2013-05-22 15:46   ` Morten Rasmussen
2013-05-22 15:58     ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 14/14] sched: force migration on buddy CPU Vincent Guittot
2013-04-26 12:08 ` [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-26 15:00 ` Arjan van de Ven
2013-04-26 15:40   ` Vincent Guittot
2013-04-26 15:46     ` Arjan van de Ven
2013-04-26 15:56       ` Vincent Guittot
2013-05-02  9:12       ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366910611-20048-12-git-send-email-vincent.guittot@linaro.org \
    --to=vincent.guittot@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).