From: vincent.guittot@linaro.org (Vincent Guittot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/14] sched: update the cpu_power
Date: Thu, 25 Apr 2013 19:23:29 +0200 [thread overview]
Message-ID: <1366910611-20048-14-git-send-email-vincent.guittot@linaro.org> (raw)
In-Reply-To: <1366910611-20048-1-git-send-email-vincent.guittot@linaro.org>
The cpu_power is updated for CPUs that don't participate to the packing
effort. We consider that their cpu_power is allocated to idleness as it could
be allocated by rt. So the cpu_power that remains available for cfs, is set to
min value (i.e. 1)
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 35 ++++++++++++++++++++---------------
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 756b1e3..54c1541 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -224,12 +224,12 @@ void update_packing_domain(int cpu)
/* loop the sched groups to find the best one */
for (tmp = sg->next; tmp != sg; tmp = tmp->next) {
- if (tmp->sgp->power * pack->group_weight >
- pack->sgp->power * tmp->group_weight)
+ if (tmp->sgp->power_available * pack->group_weight >
+ pack->sgp->power_available * tmp->group_weight)
continue;
- if ((tmp->sgp->power * pack->group_weight ==
- pack->sgp->power * tmp->group_weight)
+ if ((tmp->sgp->power_available * pack->group_weight ==
+ pack->sgp->power_available * tmp->group_weight)
&& (cpumask_first(sched_group_cpus(tmp)) >= id))
continue;
@@ -269,12 +269,12 @@ void update_packing_buddy(int cpu, int activity)
/* loop the sched groups to find the best one */
for (tmp = sg->next; tmp != sg; tmp = tmp->next) {
- if ((tmp->sgp->power * pack->group_weight) >
+ if ((tmp->sgp->power_available * pack->group_weight) >
(pack->sgp->power_available * tmp->group_weight))
continue;
- if (((tmp->sgp->power * pack->group_weight) ==
- (pack->sgp->power * tmp->group_weight))
+ if (((tmp->sgp->power_available * pack->group_weight) ==
+ (pack->sgp->power_available * tmp->group_weight))
&& (cpumask_first(sched_group_cpus(tmp)) >= id))
continue;
@@ -285,20 +285,20 @@ void update_packing_buddy(int cpu, int activity)
id = cpumask_first(sched_group_cpus(pack));
}
- if ((cpu == id) || (activity <= power_of(id))) {
+ if ((cpu == id) || (activity <= available_of(id))) {
per_cpu(sd_pack_buddy, cpu) = id;
return;
}
for (tmp = pack; activity > 0; tmp = tmp->next) {
- if (tmp->sgp->power > activity) {
+ if (tmp->sgp->power_available > activity) {
id = cpumask_first(sched_group_cpus(tmp));
- activity -= power_of(id);
+ activity -= available_of(id);
if (cpu == id)
activity = 0;
while ((activity > 0) && (id < nr_cpu_ids)) {
id = cpumask_next(id, sched_group_cpus(tmp));
- activity -= power_of(id);
+ activity -= available_of(id);
if (cpu == id)
activity = 0;
}
@@ -306,7 +306,7 @@ void update_packing_buddy(int cpu, int activity)
id = cpu;
activity = 0;
} else {
- activity -= tmp->sgp->power;
+ activity -= tmp->sgp->power_available;
}
}
@@ -3369,7 +3369,8 @@ find_idlest_group(struct sched_domain *sd, struct task_struct *p,
}
/* Adjust by relative CPU power of the group */
- avg_load = (avg_load * SCHED_POWER_SCALE) / group->sgp->power;
+ avg_load = (avg_load * SCHED_POWER_SCALE)
+ / group->sgp->power_available;
if (local_group) {
this_load = avg_load;
@@ -3551,10 +3552,10 @@ static int get_cpu_activity(int cpu)
if (sum == period) {
u32 overload = rq->nr_running > 1 ? 1 : 0;
- return power_of(cpu) + overload;
+ return available_of(cpu) + overload;
}
- return (sum * power_of(cpu)) / period;
+ return (sum * available_of(cpu)) / period;
}
/*
@@ -4596,8 +4597,12 @@ static void update_cpu_power(struct sched_domain *sd, int cpu)
cpu_rq(cpu)->cpu_available = power;
sdg->sgp->power_available = power;
+ if (!is_my_buddy(cpu, cpu))
+ power = 1;
+
cpu_rq(cpu)->cpu_power = power;
sdg->sgp->power = power;
+
}
void update_group_power(struct sched_domain *sd, int cpu)
--
1.7.9.5
next prev parent reply other threads:[~2013-04-25 17:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 17:23 [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-25 17:23 ` [PATCH 01/14] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Vincent Guittot
2013-04-25 17:23 ` [PATCH 02/14] sched: add a new SD_SHARE_POWERDOMAIN flag for sched_domain Vincent Guittot
2013-04-25 17:23 ` [PATCH 03/14] sched: pack small tasks Vincent Guittot
2013-04-26 12:30 ` Peter Zijlstra
2013-04-26 13:16 ` Vincent Guittot
2013-04-26 12:38 ` Peter Zijlstra
2013-04-26 13:38 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 04/14] sched: pack the idle load balance Vincent Guittot
2013-04-26 12:49 ` Peter Zijlstra
2013-04-26 13:47 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 05/14] ARM: sched: clear SD_SHARE_POWERDOMAIN Vincent Guittot
2013-04-25 17:23 ` [PATCH 06/14] sched: add a knob to choose the packing level Vincent Guittot
2013-04-25 17:23 ` [PATCH 07/14] sched: agressively pack at wake/fork/exec Vincent Guittot
2013-04-26 13:08 ` Peter Zijlstra
2013-04-26 14:23 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 08/14] sched: trig ILB on an idle buddy Vincent Guittot
2013-04-26 13:15 ` Peter Zijlstra
2013-04-26 14:52 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 09/14] sched: evaluate the activity level of the system Vincent Guittot
2013-05-22 16:50 ` Morten Rasmussen
2013-05-23 8:11 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 10/14] sched: update the buddy CPU Vincent Guittot
2013-04-28 8:20 ` Francesco Lavra
2013-04-29 7:32 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 11/14] sched: filter task pull request Vincent Guittot
2013-04-26 10:00 ` Vincent Guittot
2013-05-22 15:56 ` Morten Rasmussen
2013-05-22 16:03 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 12/14] sched: create a new field with available capacity Vincent Guittot
2013-04-25 17:23 ` Vincent Guittot [this message]
2013-05-22 15:46 ` [PATCH 13/14] sched: update the cpu_power Morten Rasmussen
2013-05-22 15:58 ` Vincent Guittot
2013-04-25 17:23 ` [PATCH 14/14] sched: force migration on buddy CPU Vincent Guittot
2013-04-26 12:08 ` [RFC PATCH v4 00/14] sched: packing small tasks Vincent Guittot
2013-04-26 15:00 ` Arjan van de Ven
2013-04-26 15:40 ` Vincent Guittot
2013-04-26 15:46 ` Arjan van de Ven
2013-04-26 15:56 ` Vincent Guittot
2013-05-02 9:12 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366910611-20048-14-git-send-email-vincent.guittot@linaro.org \
--to=vincent.guittot@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).