linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pranavkumar@linaro.org (Pranavkumar Sawargaonkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] virtio: console: Add early writeonly register to config space
Date: Fri, 26 Apr 2013 16:34:55 +0530	[thread overview]
Message-ID: <1366974299-17877-2-git-send-email-pranavkumar@linaro.org> (raw)
In-Reply-To: <1366974299-17877-1-git-send-email-pranavkumar@linaro.org>

This patch adds a early_wr register (writeonly) in config space of virtio console device which can be used for debugging.

The patch also updates virtio-spec in Documentation to reflect this feature addition in virtio console.

Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Signed-off-by: Anup Patel <anup.patel@linaro.org>
---
 Documentation/virtual/virtio-spec.txt |   13 +++++++++++--
 include/uapi/linux/virtio_console.h   |    3 +++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/Documentation/virtual/virtio-spec.txt b/Documentation/virtual/virtio-spec.txt
index 0d6ec85..bc4e8b5 100644
--- a/Documentation/virtual/virtio-spec.txt
+++ b/Documentation/virtual/virtio-spec.txt
@@ -1927,11 +1927,18 @@ Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
     ports; configuration fields nr_ports and max_nr_ports are
     valid and control virtqueues will be used.
 
+  VIRTIO_CONSOLE_F_EARLY_WRITE(2) Device has support for early
+  write. Configuration field early_wr is valid.
+
   Device configuration layout The size of the console is supplied
   in the configuration space if the VIRTIO_CONSOLE_F_SIZE feature
   is set. Furthermore, if the VIRTIO_CONSOLE_F_MULTIPORT feature
   is set, the maximum number of ports supported by the device can
-  be fetched.struct virtio_console_config {
+  be fetched. If VIRTIO_CONSOLE_F_EARLY_WRITE is set then one can
+  use early write to output single character without initializing
+  virtio queues.
+
+  struct virtio_console_config {
 
 	u16 cols;
 
@@ -1941,7 +1948,9 @@ Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
 
 	u32 max_nr_ports;
 
-};
+	u32 early_wr;
+
+  };
 
   Device Initialization
 
diff --git a/include/uapi/linux/virtio_console.h b/include/uapi/linux/virtio_console.h
index ee13ab6..7cd84b5 100644
--- a/include/uapi/linux/virtio_console.h
+++ b/include/uapi/linux/virtio_console.h
@@ -38,6 +38,7 @@
 /* Feature bits */
 #define VIRTIO_CONSOLE_F_SIZE	0	/* Does host provide console size? */
 #define VIRTIO_CONSOLE_F_MULTIPORT 1	/* Does host provide multiple ports? */
+#define VIRTIO_CONSOLE_F_EARLY_WRITE 2	/* Does host support early write? */
 
 #define VIRTIO_CONSOLE_BAD_ID		(~(u32)0)
 
@@ -48,6 +49,8 @@ struct virtio_console_config {
 	__u16 rows;
 	/* max. number of ports this device can hold */
 	__u32 max_nr_ports;
+	/* early write register */
+	__u32 early_wr;
 } __attribute__((packed));
 
 /*
-- 
1.7.9.5

  reply	other threads:[~2013-04-26 11:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 11:04 [PATCH 0/2] Early printk support for virtio console devices Pranavkumar Sawargaonkar
2013-04-26 11:04 ` Pranavkumar Sawargaonkar [this message]
2013-04-29  3:10   ` [PATCH 1/2] virtio: console: Add early writeonly register to config space Rusty Russell
2013-04-26 11:04 ` [PATCH 2/2] arm64: earlyprintk support for virtio-mmio console Pranavkumar Sawargaonkar
2013-04-26 11:19 ` [PATCH 0/2] Early printk support for virtio console devices Alexander Graf
2013-04-26 11:33   ` Peter Maydell
2013-04-26 12:06     ` Anup Patel
2013-04-26 12:33       ` Arnd Bergmann
2013-04-26 12:59         ` Anup Patel
2013-04-26 15:03           ` Arnd Bergmann
2013-04-26 15:54             ` Marc Zyngier
2013-04-26 15:19         ` Peter Maydell
2013-04-29  3:09   ` Rusty Russell
2013-04-29 12:22     ` Alexander Graf
2013-04-29 12:48       ` Pranavkumar Sawargaonkar
2013-04-29 12:53         ` Alexander Graf
2013-05-01  2:07           ` Rusty Russell
2013-05-01  6:53             ` Anup Patel
2013-05-01 14:46               ` Will Deacon
2013-05-02 10:06             ` Peter Maydell
2013-05-06  5:11               ` Rusty Russell
2013-05-06  9:14                 ` Peter Maydell
2013-05-07  4:46                   ` Rusty Russell
2013-05-07 12:19                     ` Peter Maydell
2013-05-07 15:52                       ` Christopher Covington
2013-05-07 15:58                         ` Peter Maydell
2013-05-08 14:17                           ` Catalin Marinas
2013-05-09 10:39                             ` Grant Likely
2013-05-06  9:40                 ` Pranavkumar Sawargaonkar
2013-04-29 12:50       ` Peter Maydell
2013-04-29 12:53         ` Alexander Graf
2013-04-30  0:32       ` Rusty Russell
2013-05-01  0:26         ` Alexander Graf
2013-05-01  5:01           ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366974299-17877-2-git-send-email-pranavkumar@linaro.org \
    --to=pranavkumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).