* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4
@ 2013-03-23 15:06 Sebastian Hesselbarth
2013-03-26 8:28 ` Andrew Lunn
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Sebastian Hesselbarth @ 2013-03-23 15:06 UTC (permalink / raw)
To: linux-arm-kernel
The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using
CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable
iWMMXt extensions on Dove.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2c3bdce..4fc9bca 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -556,7 +556,7 @@ config ARCH_IXP4XX
config ARCH_DOVE
bool "Marvell Dove"
select ARCH_REQUIRE_GPIOLIB
- select CPU_V7
+ select CPU_PJ4
select GENERIC_CLOCKEVENTS
select MIGHT_HAVE_PCI
select PINCTRL
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-23 15:06 [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Sebastian Hesselbarth @ 2013-03-26 8:28 ` Andrew Lunn 2013-03-28 17:06 ` Jason Cooper ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Andrew Lunn @ 2013-03-26 8:28 UTC (permalink / raw) To: linux-arm-kernel On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Acked-by: Andrew Lunn <andrew@lunn.ch> > --- > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 2c3bdce..4fc9bca 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -556,7 +556,7 @@ config ARCH_IXP4XX > config ARCH_DOVE > bool "Marvell Dove" > select ARCH_REQUIRE_GPIOLIB > - select CPU_V7 > + select CPU_PJ4 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI > select PINCTRL > -- > 1.7.10.4 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-23 15:06 [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Sebastian Hesselbarth 2013-03-26 8:28 ` Andrew Lunn @ 2013-03-28 17:06 ` Jason Cooper 2013-03-28 18:14 ` Russell King - ARM Linux 2013-04-29 16:50 ` Jason Cooper 2013-04-29 19:26 ` [PATCH RESEND] " Sebastian Hesselbarth 3 siblings, 1 reply; 9+ messages in thread From: Jason Cooper @ 2013-03-28 17:06 UTC (permalink / raw) To: linux-arm-kernel On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hmmm, I'm getting (with dove_defconfig): arch/arm/kernel/built-in.o: In function `iwmmxt_do': /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' make: *** [vmlinux] Error 1 thx, Jason. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-28 17:06 ` Jason Cooper @ 2013-03-28 18:14 ` Russell King - ARM Linux 2013-03-28 20:19 ` Sebastian Hesselbarth 0 siblings, 1 reply; 9+ messages in thread From: Russell King - ARM Linux @ 2013-03-28 18:14 UTC (permalink / raw) To: linux-arm-kernel On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote: > On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > > iWMMXt extensions on Dove. > > > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > --- > > Cc: Russell King <linux@arm.linux.org.uk> > > Cc: Jason Cooper <jason@lakedaemon.net> > > Cc: Andrew Lunn <andrew@lunn.ch> > > Cc: linux-arm-kernel at lists.infradead.org > > Cc: linux-kernel at vger.kernel.org > > --- > > arch/arm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hmmm, I'm getting (with dove_defconfig): > > arch/arm/kernel/built-in.o: In function `iwmmxt_do': > /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' > /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' > make: *** [vmlinux] Error 1 Looks to me like PJ4 IWMMXT support wasn't properly tested out when it was submitted - it's possible to end up with pj4-cp0.c built without the IWMMXT code that it depends on being built... ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-28 18:14 ` Russell King - ARM Linux @ 2013-03-28 20:19 ` Sebastian Hesselbarth 2013-03-28 21:04 ` Russell King - ARM Linux 0 siblings, 1 reply; 9+ messages in thread From: Sebastian Hesselbarth @ 2013-03-28 20:19 UTC (permalink / raw) To: linux-arm-kernel On 03/28/2013 07:14 PM, Russell King - ARM Linux wrote: > On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote: >> On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: >>> The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using >>> CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable >>> iWMMXt extensions on Dove. >>> >>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> >>> --- >>> Cc: Russell King<linux@arm.linux.org.uk> >>> Cc: Jason Cooper<jason@lakedaemon.net> >>> Cc: Andrew Lunn<andrew@lunn.ch> >>> Cc: linux-arm-kernel at lists.infradead.org >>> Cc: linux-kernel at vger.kernel.org >>> --- >>> arch/arm/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Hmmm, I'm getting (with dove_defconfig): >> >> arch/arm/kernel/built-in.o: In function `iwmmxt_do': >> /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' >> /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' >> make: *** [vmlinux] Error 1 > > Looks to me like PJ4 IWMMXT support wasn't properly tested out when it > was submitted - it's possible to end up with pj4-cp0.c built without > the IWMMXT code that it depends on being built... Russel, Jason, do we force iWMMXt on CPU_PJ4 or should there be some #ifdef'ery if IWMMXT is not selected? Sebastian ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-28 20:19 ` Sebastian Hesselbarth @ 2013-03-28 21:04 ` Russell King - ARM Linux 2013-03-29 1:18 ` Jason Cooper 0 siblings, 1 reply; 9+ messages in thread From: Russell King - ARM Linux @ 2013-03-28 21:04 UTC (permalink / raw) To: linux-arm-kernel On Thu, Mar 28, 2013 at 09:19:01PM +0100, Sebastian Hesselbarth wrote: > On 03/28/2013 07:14 PM, Russell King - ARM Linux wrote: >> On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote: >>> On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: >>>> The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using >>>> CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable >>>> iWMMXt extensions on Dove. >>>> >>>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com> >>>> --- >>>> Cc: Russell King<linux@arm.linux.org.uk> >>>> Cc: Jason Cooper<jason@lakedaemon.net> >>>> Cc: Andrew Lunn<andrew@lunn.ch> >>>> Cc: linux-arm-kernel at lists.infradead.org >>>> Cc: linux-kernel at vger.kernel.org >>>> --- >>>> arch/arm/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> Hmmm, I'm getting (with dove_defconfig): >>> >>> arch/arm/kernel/built-in.o: In function `iwmmxt_do': >>> /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release' >>> /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch' >>> make: *** [vmlinux] Error 1 >> >> Looks to me like PJ4 IWMMXT support wasn't properly tested out when it >> was submitted - it's possible to end up with pj4-cp0.c built without >> the IWMMXT code that it depends on being built... > > Russel, Jason, > > do we force iWMMXt on CPU_PJ4 or should there be some #ifdef'ery if > IWMMXT is not selected? >From what I could see, there's not much point to pj4-cp0.c without iwmmxt.S also being built. So, what I'd suggest is this, which will ensure IWMMXT is enabled when PJ4 is set, otherwise giving people the choice as it used to be. diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 67874b8..ef6733a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1171,9 +1171,9 @@ config ARM_NR_BANKS default 8 config IWMMXT - bool "Enable iWMMXt support" + bool "Enable iWMMXt support" if !CPU_PJ4 depends on CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_PJ4 - default y if PXA27x || PXA3xx || ARCH_MMP + default y if PXA27x || PXA3xx || ARCH_MMP || CPU_PJ4 help Enable support for iWMMXt context switching at run time if running on a CPU that supports it. ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-28 21:04 ` Russell King - ARM Linux @ 2013-03-29 1:18 ` Jason Cooper 0 siblings, 0 replies; 9+ messages in thread From: Jason Cooper @ 2013-03-29 1:18 UTC (permalink / raw) To: linux-arm-kernel On Thu, Mar 28, 2013 at 09:04:12PM +0000, Russell King - ARM Linux wrote: ... > From what I could see, there's not much point to pj4-cp0.c without > iwmmxt.S also being built. So, what I'd suggest is this, which will > ensure IWMMXT is enabled when PJ4 is set, otherwise giving people the > choice as it used to be. > Russell, Are you going to take these two patches? I don't want to assume and have them potentially get lost. thx, Jason. > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 67874b8..ef6733a 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1171,9 +1171,9 @@ config ARM_NR_BANKS > default 8 > > config IWMMXT > - bool "Enable iWMMXt support" > + bool "Enable iWMMXt support" if !CPU_PJ4 > depends on CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_PJ4 > - default y if PXA27x || PXA3xx || ARCH_MMP > + default y if PXA27x || PXA3xx || ARCH_MMP || CPU_PJ4 > help > Enable support for iWMMXt context switching at run time if > running on a CPU that supports it. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-23 15:06 [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Sebastian Hesselbarth 2013-03-26 8:28 ` Andrew Lunn 2013-03-28 17:06 ` Jason Cooper @ 2013-04-29 16:50 ` Jason Cooper 2013-04-29 19:26 ` [PATCH RESEND] " Sebastian Hesselbarth 3 siblings, 0 replies; 9+ messages in thread From: Jason Cooper @ 2013-04-29 16:50 UTC (permalink / raw) To: linux-arm-kernel On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote: > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable > iWMMXt extensions on Dove. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: Andrew Lunn <andrew@lunn.ch> > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > --- > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sebastian, It looks as though Russell's fix for IWMMXT made it in. Please place this patch in Russell's patch tracker. If you don't have the original thread, Andrew Lunn gave this an Acked-by. Now me as well: Acked-by: Jason Cooper <jason@lakedaemon.net> thx, Jason. > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 2c3bdce..4fc9bca 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -556,7 +556,7 @@ config ARCH_IXP4XX > config ARCH_DOVE > bool "Marvell Dove" > select ARCH_REQUIRE_GPIOLIB > - select CPU_V7 > + select CPU_PJ4 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI > select PINCTRL > -- > 1.7.10.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH RESEND] ARM: dove: fix Dove cpu type from V7 to PJ4 2013-03-23 15:06 [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Sebastian Hesselbarth ` (2 preceding siblings ...) 2013-04-29 16:50 ` Jason Cooper @ 2013-04-29 19:26 ` Sebastian Hesselbarth 3 siblings, 0 replies; 9+ messages in thread From: Sebastian Hesselbarth @ 2013-04-29 19:26 UTC (permalink / raw) To: linux-arm-kernel The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will enable iWMMXt extensions on Dove. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Acked-by: Jason Cooper <jason@lakedaemon.net> Acked-by: Andrew Lunn <andrew@lunn.ch> --- Note: This patch is rebased on v3.9 and patch message has been modified to point out that iWMMXt is now enforced on CPU_PJ4. Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Russell King <linux@arm.linux.org.uk> Cc: linux-arm-kernel at lists.infradead.org Cc: linux-kernel at vger.kernel.org --- arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 1cacda4..3c5e4da 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -555,7 +555,7 @@ config ARCH_IXP4XX config ARCH_DOVE bool "Marvell Dove" select ARCH_REQUIRE_GPIOLIB - select CPU_V7 + select CPU_PJ4 select GENERIC_CLOCKEVENTS select MIGHT_HAVE_PCI select PINCTRL -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-29 19:26 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-03-23 15:06 [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Sebastian Hesselbarth 2013-03-26 8:28 ` Andrew Lunn 2013-03-28 17:06 ` Jason Cooper 2013-03-28 18:14 ` Russell King - ARM Linux 2013-03-28 20:19 ` Sebastian Hesselbarth 2013-03-28 21:04 ` Russell King - ARM Linux 2013-03-29 1:18 ` Jason Cooper 2013-04-29 16:50 ` Jason Cooper 2013-04-29 19:26 ` [PATCH RESEND] " Sebastian Hesselbarth
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).