* [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller
@ 2013-05-01 10:46 Alexander Shiyan
2013-05-01 10:46 ` [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module Alexander Shiyan
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Alexander Shiyan @ 2013-05-01 10:46 UTC (permalink / raw)
To: linux-arm-kernel
Add aliases to determine the proper SPI bus number.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx27.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index ff4bd48..cd85828 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -25,6 +25,9 @@
gpio3 = &gpio4;
gpio4 = &gpio5;
gpio5 = &gpio6;
+ spi0 = &cspi1;
+ spi1 = &cspi2;
+ spi2 = &cspi3;
};
avic: avic-interrupt-controller at e0000000 {
--
1.8.1.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module
2013-05-01 10:46 [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Alexander Shiyan
@ 2013-05-01 10:46 ` Alexander Shiyan
2013-05-01 10:46 ` [PATCH 3/3] ARM: dts: Add MC13783 " Alexander Shiyan
2013-05-02 3:12 ` [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Shawn Guo
2 siblings, 0 replies; 11+ messages in thread
From: Alexander Shiyan @ 2013-05-01 10:46 UTC (permalink / raw)
To: linux-arm-kernel
Added SPI node to imx27-phytec-phycore DT file.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx27-phytec-phycore.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/imx27-phytec-phycore.dts b/arch/arm/boot/dts/imx27-phytec-phycore.dts
index fe64e3a..b0e9372 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycore.dts
@@ -72,6 +72,12 @@
};
};
+&cspi1 {
+ fsl,spi-num-chipselects = <1>;
+ cs-gpios = <&gpio4 28 0>;
+ status = "okay";
+};
+
&nfc {
nand-bus-width = <8>;
nand-ecc-mode = "hw";
--
1.8.1.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/3] ARM: dts: Add MC13783 support for i.MX27 Phytec PCM038 module
2013-05-01 10:46 [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Alexander Shiyan
2013-05-01 10:46 ` [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module Alexander Shiyan
@ 2013-05-01 10:46 ` Alexander Shiyan
2013-05-01 15:36 ` Sascha Hauer
2013-05-02 3:12 ` [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Shawn Guo
2 siblings, 1 reply; 11+ messages in thread
From: Alexander Shiyan @ 2013-05-01 10:46 UTC (permalink / raw)
To: linux-arm-kernel
Added MC13783 node to imx27-phytec-phycore DT file.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx27-phytec-phycore.dts | 92 ++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/arch/arm/boot/dts/imx27-phytec-phycore.dts b/arch/arm/boot/dts/imx27-phytec-phycore.dts
index b0e9372..5c4fea9 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycore.dts
@@ -76,6 +76,98 @@
fsl,spi-num-chipselects = <1>;
cs-gpios = <&gpio4 28 0>;
status = "okay";
+
+ pmic: mc13783 at 0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,mc13783";
+ spi-max-frequency = <20000000>;
+ reg = <0>;
+ interrupt-parent = <&gpio2>;
+ interrupts = <23 0x4>;
+ fsl,mc13xxx-uses-adc;
+
+ regulators {
+ sw1a_reg: sw1a {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ sw1b_reg: sw1b {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ sw2a_reg: sw2a {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ sw2b_reg: sw2b {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ sw3_reg: sw3 {
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ vaudio_reg: vaudio {
+ regulator-min-microvolt = <2775000>;
+ regulator-max-microvolt = <2775000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ violo_reg: violo {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ viohi_reg: viohi {
+ regulator-min-microvolt = <2775000>;
+ regulator-max-microvolt = <2775000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ vgen_reg: vgen {
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ vcam_reg: vcam {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+ vrf1_reg: vrf1 {
+ regulator-min-microvolt = <2775000>;
+ regulator-max-microvolt = <2775000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ vrf2_reg: vrf2 {
+ regulator-min-microvolt = <2775000>;
+ regulator-max-microvolt = <2775000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ vmmc1_reg: vmmc1 {
+ regulator-min-microvolt = <1600000>;
+ regulator-max-microvolt = <3000000>;
+ };
+ gpo1_reg: gpo1 {
+ };
+ pwgt1spi_reg: pwgt1spi {
+ };
+ };
+ };
};
&nfc {
--
1.8.1.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/3] ARM: dts: Add MC13783 support for i.MX27 Phytec PCM038 module
2013-05-01 10:46 ` [PATCH 3/3] ARM: dts: Add MC13783 " Alexander Shiyan
@ 2013-05-01 15:36 ` Sascha Hauer
2013-05-01 15:40 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 11+ messages in thread
From: Sascha Hauer @ 2013-05-01 15:36 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 01, 2013 at 02:46:59PM +0400, Alexander Shiyan wrote:
> Added MC13783 node to imx27-phytec-phycore DT file.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx27-phytec-phycore.dts | 92 ++++++++++++++++++++++++++++++
> 1 file changed, 92 insertions(+)
You can merge this with the previous patch.
>
> diff --git a/arch/arm/boot/dts/imx27-phytec-phycore.dts b/arch/arm/boot/dts/imx27-phytec-phycore.dts
> index b0e9372..5c4fea9 100644
> --- a/arch/arm/boot/dts/imx27-phytec-phycore.dts
> +++ b/arch/arm/boot/dts/imx27-phytec-phycore.dts
> @@ -76,6 +76,98 @@
> fsl,spi-num-chipselects = <1>;
> cs-gpios = <&gpio4 28 0>;
> status = "okay";
> +
> + pmic: mc13783 at 0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,mc13783";
> + spi-max-frequency = <20000000>;
> + reg = <0>;
> + interrupt-parent = <&gpio2>;
> + interrupts = <23 0x4>;
> + fsl,mc13xxx-uses-adc;
> +
> + regulators {
> + sw1a_reg: sw1a {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> + sw1b_reg: sw1b {
Please add a blank line after each node.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 11+ messages in thread* Re[2]: [PATCH 3/3] ARM: dts: Add MC13783 support for i.MX27 Phytec PCM038 module
2013-05-01 15:36 ` Sascha Hauer
@ 2013-05-01 15:40 ` Alexander Shiyan
2013-05-01 19:15 ` Sascha Hauer
0 siblings, 1 reply; 11+ messages in thread
From: Alexander Shiyan @ 2013-05-01 15:40 UTC (permalink / raw)
To: linux-arm-kernel
> On Wed, May 01, 2013 at 02:46:59PM +0400, Alexander Shiyan wrote:
> > Added MC13783 node to imx27-phytec-phycore DT file.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/boot/dts/imx27-phytec-phycore.dts | 92 ++++++++++++++++++++++++++++++
> > 1 file changed, 92 insertions(+)
>
> You can merge this with the previous patch.
Part 2 just adds a SPI host for the target. Is this merge is really necessary?
---
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] ARM: dts: Add MC13783 support for i.MX27 Phytec PCM038 module
2013-05-01 15:40 ` Re[2]: " Alexander Shiyan
@ 2013-05-01 19:15 ` Sascha Hauer
2013-05-02 4:09 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 11+ messages in thread
From: Sascha Hauer @ 2013-05-01 19:15 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 01, 2013 at 07:40:37PM +0400, Alexander Shiyan wrote:
> > On Wed, May 01, 2013 at 02:46:59PM +0400, Alexander Shiyan wrote:
> > > Added MC13783 node to imx27-phytec-phycore DT file.
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > > arch/arm/boot/dts/imx27-phytec-phycore.dts | 92 ++++++++++++++++++++++++++++++
> > > 1 file changed, 92 insertions(+)
> >
> > You can merge this with the previous patch.
>
> Part 2 just adds a SPI host for the target. Is this merge is really necessary?
The SPI host does nothing without devices registered on it, so why not
make 2/3 and 3/3 a single patch?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re[2]: [PATCH 3/3] ARM: dts: Add MC13783 support for i.MX27 Phytec PCM038 module
2013-05-01 19:15 ` Sascha Hauer
@ 2013-05-02 4:09 ` Alexander Shiyan
2013-05-02 4:13 ` Re[3]: " Alexander Shiyan
0 siblings, 1 reply; 11+ messages in thread
From: Alexander Shiyan @ 2013-05-02 4:09 UTC (permalink / raw)
To: linux-arm-kernel
> On Wed, May 01, 2013 at 07:40:37PM +0400, Alexander Shiyan wrote:
> > > On Wed, May 01, 2013 at 02:46:59PM +0400, Alexander Shiyan wrote:
> > > > Added MC13783 node to imx27-phytec-phycore DT file.
> > > >
> > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > > ---
> > > > arch/arm/boot/dts/imx27-phytec-phycore.dts | 92 ++++++++++++++++++++++++++++++
> > > > 1 file changed, 92 insertions(+)
> > >
> > > You can merge this with the previous patch.
> >
> > Part 2 just adds a SPI host for the target. Is this merge is really necessary?
>
> The SPI host does nothing without devices registered on it, so why not
> make 2/3 and 3/3 a single patch?
At point of 2/3 user can use SPI0.0 as spidev. And in th
---
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re[3]: [PATCH 3/3] ARM: dts: Add MC13783 support for i.MX27 Phytec PCM038 module
2013-05-02 4:09 ` Re[2]: " Alexander Shiyan
@ 2013-05-02 4:13 ` Alexander Shiyan
0 siblings, 0 replies; 11+ messages in thread
From: Alexander Shiyan @ 2013-05-02 4:13 UTC (permalink / raw)
To: linux-arm-kernel
> > On Wed, May 01, 2013 at 07:40:37PM +0400, Alexander Shiyan wrote:
> > > > On Wed, May 01, 2013 at 02:46:59PM +0400, Alexander Shiyan wrote:
> > > > > Added MC13783 node to imx27-phytec-phycore DT file.
> > > > >
> > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > > > ---
> > > > > arch/arm/boot/dts/imx27-phytec-phycore.dts | 92 ++++++++++++++++++++++++++++++
> > > > > 1 file changed, 92 insertions(+)
> > > >
> > > > You can merge this with the previous patch.
> > >
> > > Part 2 just adds a SPI host for the target. Is this merge is really necessary?
> >
> > The SPI host does nothing without devices registered on it, so why not
> > make 2/3 and 3/3 a single patch?
>
> At point of 2/3 user can use SPI0.0 as spidev. And in th
Please ignore this message.
Thanks.
---
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller
2013-05-01 10:46 [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Alexander Shiyan
2013-05-01 10:46 ` [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module Alexander Shiyan
2013-05-01 10:46 ` [PATCH 3/3] ARM: dts: Add MC13783 " Alexander Shiyan
@ 2013-05-02 3:12 ` Shawn Guo
2 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2013-05-02 3:12 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 01, 2013 at 02:46:57PM +0400, Alexander Shiyan wrote:
> Add aliases to determine the proper SPI bus number.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Applied, thanks.
> ---
> arch/arm/boot/dts/imx27.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index ff4bd48..cd85828 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -25,6 +25,9 @@
> gpio3 = &gpio4;
> gpio4 = &gpio5;
> gpio5 = &gpio6;
> + spi0 = &cspi1;
> + spi1 = &cspi2;
> + spi2 = &cspi3;
> };
>
> avic: avic-interrupt-controller at e0000000 {
> --
> 1.8.1.5
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/3] ARM: dts: Add NFC support for i.MX27 Phytec PCM038 module
@ 2013-04-07 15:29 Alexander Shiyan
2013-04-07 15:29 ` [PATCH 2/3] ARM: dts: Add SPI " Alexander Shiyan
0 siblings, 1 reply; 11+ messages in thread
From: Alexander Shiyan @ 2013-04-07 15:29 UTC (permalink / raw)
To: linux-arm-kernel
Added NFC node to imx27-phytec-phycore DT file.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx27-phytec-phycore.dtsp | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/imx27-phytec-phycore.dtsp b/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
index 924097a..7228153 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
+++ b/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
@@ -71,3 +71,9 @@
#size-cells = <1>;
};
};
+
+&nfc {
+ nand-bus-width = <8>;
+ nand-ecc-mode = "hw";
+ status = "okay";
+};
--
1.8.1.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module
2013-04-07 15:29 [PATCH 1/3] ARM: dts: Add NFC support for i.MX27 Phytec PCM038 module Alexander Shiyan
@ 2013-04-07 15:29 ` Alexander Shiyan
2013-04-08 6:35 ` Shawn Guo
0 siblings, 1 reply; 11+ messages in thread
From: Alexander Shiyan @ 2013-04-07 15:29 UTC (permalink / raw)
To: linux-arm-kernel
Added SPI node to imx27-phytec-phycore DT file.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx27-phytec-phycore.dtsp | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/imx27-phytec-phycore.dtsp b/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
index 7228153..354dc77 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
+++ b/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
@@ -77,3 +77,9 @@
nand-ecc-mode = "hw";
status = "okay";
};
+
+&cspi1 {
+ fsl,spi-num-chipselects = <1>;
+ cs-gpios = <&gpio4 28 0>;
+ status = "okay";
+};
--
1.8.1.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module
2013-04-07 15:29 ` [PATCH 2/3] ARM: dts: Add SPI " Alexander Shiyan
@ 2013-04-08 6:35 ` Shawn Guo
0 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2013-04-08 6:35 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Apr 07, 2013 at 07:29:13PM +0400, Alexander Shiyan wrote:
> Added SPI node to imx27-phytec-phycore DT file.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx27-phytec-phycore.dtsp | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx27-phytec-phycore.dtsp b/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
> index 7228153..354dc77 100644
> --- a/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
> +++ b/arch/arm/boot/dts/imx27-phytec-phycore.dtsp
> @@ -77,3 +77,9 @@
> nand-ecc-mode = "hw";
> status = "okay";
> };
> +
> +&cspi1 {
> + fsl,spi-num-chipselects = <1>;
> + cs-gpios = <&gpio4 28 0>;
> + status = "okay";
> +};
I would suggest these codes be sorted in alphabet order of label name.
IOW, &cspi1 should be put before &nfc.
Shawn
> --
> 1.8.1.5
>
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-05-02 4:13 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-01 10:46 [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Alexander Shiyan
2013-05-01 10:46 ` [PATCH 2/3] ARM: dts: Add SPI support for i.MX27 Phytec PCM038 module Alexander Shiyan
2013-05-01 10:46 ` [PATCH 3/3] ARM: dts: Add MC13783 " Alexander Shiyan
2013-05-01 15:36 ` Sascha Hauer
2013-05-01 15:40 ` Re[2]: " Alexander Shiyan
2013-05-01 19:15 ` Sascha Hauer
2013-05-02 4:09 ` Re[2]: " Alexander Shiyan
2013-05-02 4:13 ` Re[3]: " Alexander Shiyan
2013-05-02 3:12 ` [PATCH 1/3] ARM: dts: Add aliases for i.MX27 SPI controller Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2013-04-07 15:29 [PATCH 1/3] ARM: dts: Add NFC support for i.MX27 Phytec PCM038 module Alexander Shiyan
2013-04-07 15:29 ` [PATCH 2/3] ARM: dts: Add SPI " Alexander Shiyan
2013-04-08 6:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).