From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] crypto: ux500/cryp - Prepare clock before enabling it
Date: Thu, 2 May 2013 11:49:46 +0100 [thread overview]
Message-ID: <1367491790-9727-5-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1367491790-9727-1-git-send-email-lee.jones@linaro.org>
If we fail to prepare the ux500-cryp clock before enabling it the
platform will fail to boot. Here we insure this happens.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andreas Westin <andreas.westin@stericsson.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-crypto at vger.kernel.org
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/crypto/ux500/cryp/cryp_core.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c b/drivers/crypto/ux500/cryp/cryp_core.c
index 22c9063..bf78d60 100644
--- a/drivers/crypto/ux500/cryp/cryp_core.c
+++ b/drivers/crypto/ux500/cryp/cryp_core.c
@@ -1459,11 +1459,17 @@ static int ux500_cryp_probe(struct platform_device *pdev)
goto out_regulator;
}
+ ret = clk_prepare(device_data->clk);
+ if (ret) {
+ dev_err(dev, "[%s]: clk_prepare() failed!", __func__);
+ goto out_clk;
+ }
+
/* Enable device power (and clock) */
ret = cryp_enable_power(device_data->dev, device_data, false);
if (ret) {
dev_err(dev, "[%s]: cryp_enable_power() failed!", __func__);
- goto out_clk;
+ goto out_clk_unprepare;
}
cryp_error = cryp_check(device_data);
@@ -1524,6 +1530,9 @@ static int ux500_cryp_probe(struct platform_device *pdev)
out_power:
cryp_disable_power(device_data->dev, device_data, false);
+out_clk_unprepare:
+ clk_unprepare(device_data->clk);
+
out_clk:
clk_put(device_data->clk);
@@ -1594,6 +1603,7 @@ static int ux500_cryp_remove(struct platform_device *pdev)
dev_err(&pdev->dev, "[%s]: cryp_disable_power() failed",
__func__);
+ clk_unprepare(device_data->clk);
clk_put(device_data->clk);
regulator_put(device_data->pwr_regulator);
--
1.7.10.4
next prev parent reply other threads:[~2013-05-02 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 10:49 [PATCH 0/8] crypto: Fix clocks and DMA configuration Lee Jones
2013-05-02 10:49 ` [PATCH 1/8] crypto: ux500/hash - Prepare clock before enabling it Lee Jones
2013-05-08 13:57 ` Ulf Hansson
2013-05-02 10:49 ` [PATCH 2/8] crypto: ux500/hash - Set DMA configuration though dma_slave_config() Lee Jones
2013-05-02 10:49 ` [PATCH 3/8] ARM: ux500: Stop passing Hash DMA channel config information though pdata Lee Jones
2013-05-02 10:49 ` Lee Jones [this message]
2013-05-08 13:57 ` [PATCH 4/8] crypto: ux500/cryp - Prepare clock before enabling it Ulf Hansson
2013-05-02 10:49 ` [PATCH 5/8] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() Lee Jones
2013-05-02 10:49 ` [PATCH 6/8] ARM: ux500: Stop passing Cryp DMA channel config information though pdata Lee Jones
2013-05-02 10:49 ` [PATCH 7/8] crypto: ux500/[cryp|hash] - Show successful start-up in the bootlog Lee Jones
2013-05-02 10:49 ` [PATCH 8/8] ARM: ux500: Register Cyrp and Hash platform drivers on Snowball Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367491790-9727-5-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).