linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: steve.capper@linaro.org (Steve Capper)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 05/11] mm: thp: Correct the HPAGE_PMD_ORDER check.
Date: Wed,  8 May 2013 10:52:37 +0100	[thread overview]
Message-ID: <1368006763-30774-6-git-send-email-steve.capper@linaro.org> (raw)
In-Reply-To: <1368006763-30774-1-git-send-email-steve.capper@linaro.org>

All Transparent Huge Pages are allocated by the buddy allocator.

A compile time check is in place that fails when the order of a
transparent huge page is too large to be allocated by the buddy
allocator. Unfortunately that compile time check passes when:
HPAGE_PMD_ORDER == MAX_ORDER
( which is incorrect as the buddy allocator can only allocate
memory of order strictly less than MAX_ORDER. )

This patch updates the compile time check to fail in the above
case.

Signed-off-by: Steve Capper <steve.capper@linaro.org>
---
 include/linux/huge_mm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index ee1c244..3d71e5c 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -119,7 +119,7 @@ extern void __split_huge_page_pmd(struct vm_area_struct *vma,
 	} while (0)
 extern void split_huge_page_pmd_mm(struct mm_struct *mm, unsigned long address,
 		pmd_t *pmd);
-#if HPAGE_PMD_ORDER > MAX_ORDER
+#if HPAGE_PMD_ORDER >= MAX_ORDER
 #error "hugepages can't be allocated by the buddy allocator"
 #endif
 extern int hugepage_madvise(struct vm_area_struct *vma,
-- 
1.8.1.4

  parent reply	other threads:[~2013-05-08  9:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  9:52 [RFC PATCH v2 00/11] HugeTLB and THP support for ARM64 Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 01/11] mm: hugetlb: Copy huge_pmd_share from x86 to mm Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 02/11] x86: mm: Remove x86 version of huge_pmd_share Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 03/11] mm: hugetlb: Copy general hugetlb code from x86 to mm Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 04/11] x86: mm: Remove general hugetlb code from x86 Steve Capper
2013-05-08  9:52 ` Steve Capper [this message]
2013-05-08 12:44   ` [RFC PATCH v2 05/11] mm: thp: Correct the HPAGE_PMD_ORDER check Kirill A. Shutemov
2013-05-08 12:03     ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 06/11] ARM64: mm: Restore memblock limit when map_mem finished Steve Capper
2013-05-16 13:52   ` Catalin Marinas
2013-05-08  9:52 ` [RFC PATCH v2 07/11] ARM64: mm: Make PAGE_NONE pages read only and no-execute Steve Capper
2013-05-08 16:43   ` Will Deacon
2013-05-09  8:27     ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 08/11] ARM64: mm: Swap PTE_FILE and PTE_PROT_NONE bits Steve Capper
2013-05-08 16:17   ` Christopher Covington
2013-05-09  8:15     ` Steve Capper
2013-05-08 16:40   ` Will Deacon
2013-05-09  8:22     ` Steve Capper
2013-05-16 14:58   ` Catalin Marinas
2013-05-08  9:52 ` [RFC PATCH v2 09/11] ARM64: mm: HugeTLB support Steve Capper
2013-05-16 14:32   ` Catalin Marinas
2013-05-17  8:41     ` Steve Capper
2013-05-08  9:52 ` [RFC PATCH v2 10/11] ARM64: mm: Raise MAX_ORDER for 64KB pages and THP Steve Capper
2013-05-16 14:59   ` Catalin Marinas
2013-05-08  9:52 ` [RFC PATCH v2 11/11] ARM64: mm: THP support Steve Capper
2013-05-16 15:01   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368006763-30774-6-git-send-email-steve.capper@linaro.org \
    --to=steve.capper@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).