From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] ARM: ux500: Remove duplicated assignment of ab8500_platdata
Date: Wed, 8 May 2013 14:29:01 +0100 [thread overview]
Message-ID: <1368019749-19455-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1368019749-19455-1-git-send-email-lee.jones@linaro.org>
Since: "05ec260 mfd: db8500-prcmu: update resource passing", the AB8500's
platform data 'ab8500_platdata' is passed directly as an attribute to
'db8500_prcmu_pdata', so there's no requirement to assign it a second
time. In fact, it's only due to an ordering issue that the entire
'db8500_prcmu_pdata' data structure isn't completely over-written by the
assignment in u8500_init_devices().
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
arch/arm/mach-ux500/board-mop500.c | 6 +++---
arch/arm/mach-ux500/cpu-db8500.c | 4 +---
arch/arm/mach-ux500/setup.h | 2 +-
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-ux500/board-mop500.c b/arch/arm/mach-ux500/board-mop500.c
index 9bc762a..14a3598 100644
--- a/arch/arm/mach-ux500/board-mop500.c
+++ b/arch/arm/mach-ux500/board-mop500.c
@@ -623,7 +623,7 @@ static void __init mop500_init_machine(void)
sdi0_reg_info.gpios[0].gpio = GPIO_SDMMC_1V8_3V_SEL;
mop500_pinmaps_init();
- parent = u8500_init_devices(&ab8500_platdata);
+ parent = u8500_init_devices();
for (i = 0; i < ARRAY_SIZE(mop500_platform_devs); i++)
mop500_platform_devs[i]->dev.parent = parent;
@@ -660,7 +660,7 @@ static void __init snowball_init_machine(void)
sdi0_reg_info.gpios[0].gpio = SNOWBALL_SDMMC_1V8_3V_GPIO;
snowball_pinmaps_init();
- parent = u8500_init_devices(&ab8500_platdata);
+ parent = u8500_init_devices();
for (i = 0; i < ARRAY_SIZE(snowball_platform_devs); i++)
snowball_platform_devs[i]->dev.parent = parent;
@@ -698,7 +698,7 @@ static void __init hrefv60_init_machine(void)
sdi0_reg_info.gpios[0].gpio = HREFV60_SDMMC_1V8_3V_GPIO;
hrefv60_pinmaps_init();
- parent = u8500_init_devices(&ab8500_platdata);
+ parent = u8500_init_devices();
for (i = 0; i < ARRAY_SIZE(mop500_platform_devs); i++)
mop500_platform_devs[i]->dev.parent = parent;
diff --git a/arch/arm/mach-ux500/cpu-db8500.c b/arch/arm/mach-ux500/cpu-db8500.c
index 995928b..8c2590c 100644
--- a/arch/arm/mach-ux500/cpu-db8500.c
+++ b/arch/arm/mach-ux500/cpu-db8500.c
@@ -206,7 +206,7 @@ static struct device * __init db8500_soc_device_init(void)
/*
* This function is called from the board init
*/
-struct device * __init u8500_init_devices(struct ab8500_platform_data *ab8500)
+struct device * __init u8500_init_devices(void)
{
struct device *parent;
int i;
@@ -220,8 +220,6 @@ struct device * __init u8500_init_devices(struct ab8500_platform_data *ab8500)
for (i = 0; i < ARRAY_SIZE(platform_devs); i++)
platform_devs[i]->dev.parent = parent;
- db8500_prcmu_device.dev.platform_data = ab8500;
-
platform_add_devices(platform_devs, ARRAY_SIZE(platform_devs));
return parent;
diff --git a/arch/arm/mach-ux500/setup.h b/arch/arm/mach-ux500/setup.h
index bddce2b..cad3ca8 100644
--- a/arch/arm/mach-ux500/setup.h
+++ b/arch/arm/mach-ux500/setup.h
@@ -18,7 +18,7 @@
void __init ux500_map_io(void);
extern void __init u8500_map_io(void);
-extern struct device * __init u8500_init_devices(struct ab8500_platform_data *ab8500);
+extern struct device * __init u8500_init_devices(void);
extern void __init ux500_init_irq(void);
extern void __init ux500_init_late(void);
--
1.7.10.4
next prev parent reply other threads:[~2013-05-08 13:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:29 [PATCH 0/9] Important ux500 fixups due for the v3.10 -rc:s Lee Jones
2013-05-08 13:29 ` Lee Jones [this message]
2013-05-14 8:17 ` [PATCH 1/9] ARM: ux500: Remove duplicated assignment of ab8500_platdata Linus Walleij
2013-05-08 13:29 ` [PATCH 2/9] mfd: ab8500-core: Use the correct driver name when enabling gpio/pinctrl Lee Jones
2013-05-14 8:23 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 3/9] clk: ux500: Provide device enumeration number suffix for SMSC911x Lee Jones
2013-05-08 14:00 ` Ulf Hansson
2013-05-14 8:25 ` Linus Walleij
2013-05-14 8:45 ` Lee Jones
2013-06-10 9:08 ` Lee Jones
2013-06-10 9:11 ` Lee Jones
2013-05-14 15:58 ` Mike Turquette
2013-05-15 8:54 ` Linus Walleij
2013-05-15 9:07 ` Lee Jones
2013-05-08 13:29 ` [PATCH 4/9] mfd: db8500-prcmu: Supply the pdata_size attribute for db8500-thermal Lee Jones
2013-05-14 8:25 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 5/9] ARM: ux500: Fix incorrect DEBUG UART virtual addresses Lee Jones
2013-05-14 8:27 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 6/9] ARM: ux500: Provide device enumeration number suffix for SMSC911x Lee Jones
2013-05-14 8:30 ` Linus Walleij
2013-05-14 8:48 ` Lee Jones
2013-05-08 13:29 ` [PATCH 7/9] pinctrl: abx500: Specify failed sub-driver by ID instead of driver_data Lee Jones
2013-05-14 8:35 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 8/9] pinctrl: abx500: Rejiggle platform data and DT initialisation Lee Jones
2013-05-14 8:40 ` Linus Walleij
2013-05-14 8:47 ` Lee Jones
2013-05-14 8:50 ` Linus Walleij
2013-05-14 9:40 ` Lee Jones
2013-05-14 11:09 ` Linus Walleij
2013-05-08 13:29 ` [PATCH 9/9] mfd: ab8500-core: Pass GPADC compatible string to MFD core Lee Jones
2013-05-14 8:46 ` Linus Walleij
2013-05-14 9:26 ` Lee Jones
2013-05-14 11:06 ` Linus Walleij
2013-05-14 11:34 ` Lee Jones
2013-05-08 13:37 ` [PATCH 0/9] Important ux500 fixups due for the v3.10 -rc:s Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368019749-19455-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).