From: mst@redhat.com (Michael S. Tsirkin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 02/11] arm64: uaccess s/might_sleep/might_fault/
Date: Fri, 24 May 2013 17:17:47 +0300 [thread overview]
Message-ID: <1369404522-12927-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <cover.1368702323.git.mst@redhat.com>
The only reason uaccess routines might sleep
is if they fault. Make this explicit.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/arm64/include/asm/uaccess.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index 008f848..edb3d5c 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -166,7 +166,7 @@ do { \
#define get_user(x, ptr) \
({ \
- might_sleep(); \
+ might_fault(); \
access_ok(VERIFY_READ, (ptr), sizeof(*(ptr))) ? \
__get_user((x), (ptr)) : \
((x) = 0, -EFAULT); \
@@ -227,7 +227,7 @@ do { \
#define put_user(x, ptr) \
({ \
- might_sleep(); \
+ might_fault(); \
access_ok(VERIFY_WRITE, (ptr), sizeof(*(ptr))) ? \
__put_user((x), (ptr)) : \
-EFAULT; \
--
MST
prev parent reply other threads:[~2013-05-24 14:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 11:07 [PATCH v2 00/10] uaccess: better might_sleep/might_fault behavior Michael S. Tsirkin
2013-05-16 11:10 ` [PATCH v2 01/10] asm-generic: uaccess s/might_sleep/might_fault/ Michael S. Tsirkin
2013-05-16 11:10 ` [PATCH v2 02/10] arm64: " Michael S. Tsirkin
2013-05-16 13:29 ` Catalin Marinas
2013-05-16 11:10 ` [PATCH v2 03/10] frv: " Michael S. Tsirkin
2013-05-16 11:11 ` [PATCH v2 04/10] m32r: " Michael S. Tsirkin
2013-05-16 11:11 ` [PATCH v2 05/10] microblaze: " Michael S. Tsirkin
2013-05-16 11:12 ` [PATCH v2 06/10] mn10300: " Michael S. Tsirkin
2013-05-16 11:15 ` [PATCH v2 07/10] powerpc: " Michael S. Tsirkin
2013-05-22 13:59 ` Arnd Bergmann
2013-05-22 14:30 ` Michael S. Tsirkin
2013-05-24 13:00 ` Michael S. Tsirkin
2013-05-24 13:11 ` Michael S. Tsirkin
2013-05-24 13:30 ` Arnd Bergmann
2013-05-16 11:15 ` [PATCH v2 08/10] tile: " Michael S. Tsirkin
2013-05-16 13:33 ` Chris Metcalf
2013-05-16 11:15 ` [PATCH v2 09/10] x86: " Michael S. Tsirkin
2013-05-16 11:16 ` [PATCH v2 10/10] kernel: might_fault does not imply might_sleep Michael S. Tsirkin
2013-05-16 18:40 ` Peter Zijlstra
2013-05-19 9:35 ` Michael S. Tsirkin
2013-05-19 12:34 ` Steven Rostedt
2013-05-19 13:34 ` Michael S. Tsirkin
2013-05-19 16:06 ` Steven Rostedt
2013-05-19 16:40 ` Michael S. Tsirkin
2013-05-19 20:23 ` Steven Rostedt
2013-05-19 20:35 ` Michael S. Tsirkin
2013-05-21 11:18 ` Peter Zijlstra
2013-05-21 11:21 ` Peter Zijlstra
2013-05-21 11:57 ` Peter Zijlstra
2013-05-22 9:47 ` Michael S. Tsirkin
2013-05-22 10:16 ` Peter Zijlstra
2013-05-22 20:38 ` Michael S. Tsirkin
2013-05-22 20:36 ` Michael S. Tsirkin
2013-05-22 9:25 ` [PATCH v2 00/10] uaccess: better might_sleep/might_fault behavior Arnd Bergmann
2013-05-22 9:58 ` Michael S. Tsirkin
2013-05-22 10:19 ` Peter Zijlstra
2013-05-22 11:07 ` Michael S. Tsirkin
2013-05-22 11:27 ` Peter Zijlstra
2013-05-22 13:41 ` Russell King - ARM Linux
2013-05-22 14:04 ` Arnd Bergmann
2013-05-22 14:44 ` Michael S. Tsirkin
2013-05-24 14:17 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369404522-12927-2-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).