* [PATCH v2] usb: musb: fix clock naming
@ 2013-05-28 7:21 yegorslists at googlemail.com
2013-05-28 17:36 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: yegorslists at googlemail.com @ 2013-05-28 7:21 UTC (permalink / raw)
To: linux-arm-kernel
From: Yegor Yefremov <yegorslists@googlemail.com>
'ick' was changed to 'hsotgusb_ick'
'fck' was changed to 'hsotgusb_fck'
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
v2: CC linux-usb mailing list
drivers/usb/musb/am35x.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
index 2231850..92b5b23 100644
--- a/drivers/usb/musb/am35x.c
+++ b/drivers/usb/musb/am35x.c
@@ -477,14 +477,14 @@ static int am35x_probe(struct platform_device *pdev)
goto err1;
}
- phy_clk = clk_get(&pdev->dev, "fck");
+ phy_clk = clk_get(&pdev->dev, "hsotgusb_ick");
if (IS_ERR(phy_clk)) {
dev_err(&pdev->dev, "failed to get PHY clock\n");
ret = PTR_ERR(phy_clk);
goto err3;
}
- clk = clk_get(&pdev->dev, "ick");
+ clk = clk_get(&pdev->dev, "hsotgusb_fck");
if (IS_ERR(clk)) {
dev_err(&pdev->dev, "failed to get clock\n");
ret = PTR_ERR(clk);
--
1.7.7
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] usb: musb: fix clock naming
2013-05-28 7:21 [PATCH v2] usb: musb: fix clock naming yegorslists at googlemail.com
@ 2013-05-28 17:36 ` Felipe Balbi
2013-05-29 9:36 ` Jan Lübbe
2013-05-29 10:06 ` Yegor Yefremov
0 siblings, 2 replies; 6+ messages in thread
From: Felipe Balbi @ 2013-05-28 17:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> 'ick' was changed to 'hsotgusb_ick'
> 'fck' was changed to 'hsotgusb_fck'
>
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
NAK. Fix your clock data.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130528/2bcee7a7/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] usb: musb: fix clock naming
2013-05-28 17:36 ` Felipe Balbi
@ 2013-05-29 9:36 ` Jan Lübbe
2013-05-29 9:51 ` Yegor Yefremov
2013-05-29 10:06 ` Yegor Yefremov
1 sibling, 1 reply; 6+ messages in thread
From: Jan Lübbe @ 2013-05-29 9:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2013-05-28 at 20:36 +0300, Felipe Balbi wrote:
> On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists at googlemail.com wrote:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > 'ick' was changed to 'hsotgusb_ick'
> > 'fck' was changed to 'hsotgusb_fck'
> >
> > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> NAK. Fix your clock data.
Yegor, I'm not sure how my signed-off-by got here. It seems that you
picked the patch up from this thread:
http://marc.info/?l=linux-omap&m=134390141101734
Note that my mail contains no signed-off-by and the change is described
as a work around.
Regards,
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] usb: musb: fix clock naming
2013-05-29 9:36 ` Jan Lübbe
@ 2013-05-29 9:51 ` Yegor Yefremov
0 siblings, 0 replies; 6+ messages in thread
From: Yegor Yefremov @ 2013-05-29 9:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 29, 2013 at 11:36 AM, Jan L?bbe <jlu@pengutronix.de> wrote:
> On Tue, 2013-05-28 at 20:36 +0300, Felipe Balbi wrote:
>> On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists at googlemail.com wrote:
>> > From: Yegor Yefremov <yegorslists@googlemail.com>
>> >
>> > 'ick' was changed to 'hsotgusb_ick'
>> > 'fck' was changed to 'hsotgusb_fck'
>> >
>> > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
>> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> NAK. Fix your clock data.
>
> Yegor, I'm not sure how my signed-off-by got here. It seems that you
> picked the patch up from this thread:
> http://marc.info/?l=linux-omap&m=134390141101734
>
> Note that my mail contains no signed-off-by and the change is described
> as a work around.
I'll remove your SoB, when I post the next version. I just added it,
because you provided the fix. Will contact you next time first. Have
you worked on this SoC lately? Any pending patches?
Yegor
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] usb: musb: fix clock naming
2013-05-28 17:36 ` Felipe Balbi
2013-05-29 9:36 ` Jan Lübbe
@ 2013-05-29 10:06 ` Yegor Yefremov
2013-05-29 17:41 ` Felipe Balbi
1 sibling, 1 reply; 6+ messages in thread
From: Yegor Yefremov @ 2013-05-29 10:06 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 28, 2013 at 7:36 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists at googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> 'ick' was changed to 'hsotgusb_ick'
>> 'fck' was changed to 'hsotgusb_fck'
>>
>> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> NAK. Fix your clock data.
Do you mean here arch/arm/mach-omap2/cclock3xxx_data.c?
Yegor
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] usb: musb: fix clock naming
2013-05-29 10:06 ` Yegor Yefremov
@ 2013-05-29 17:41 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2013-05-29 17:41 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 29, 2013 at 12:06:52PM +0200, Yegor Yefremov wrote:
> On Tue, May 28, 2013 at 7:36 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Tue, May 28, 2013 at 09:21:01AM +0200, yegorslists at googlemail.com wrote:
> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >>
> >> 'ick' was changed to 'hsotgusb_ick'
> >> 'fck' was changed to 'hsotgusb_fck'
> >>
> >> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > NAK. Fix your clock data.
>
> Do you mean here arch/arm/mach-omap2/cclock3xxx_data.c?
yes
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130529/e081ec5d/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-29 17:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 7:21 [PATCH v2] usb: musb: fix clock naming yegorslists at googlemail.com
2013-05-28 17:36 ` Felipe Balbi
2013-05-29 9:36 ` Jan Lübbe
2013-05-29 9:51 ` Yegor Yefremov
2013-05-29 10:06 ` Yegor Yefremov
2013-05-29 17:41 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).