public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] SPI: Unify simple platform data for some controllers
Date: Wed, 29 May 2013 21:05:59 +0400	[thread overview]
Message-ID: <1369847158.250798748@f433.i.mail.ru> (raw)
In-Reply-To: <20130529144909.GT3660@sirena.org.uk>

> On Wed, May 29, 2013 at 03:26:34PM +0200, Arnd Bergmann wrote:
> > On Wednesday 29 May 2013, Mark Brown wrote:
> 
> > > We probably also want to make
> > > GPIO chip select support a standard thing that's available with every
> > > driver rather than something the driver has to know about but that's a
> > > separate bit of work.
> 
> > That actually seems simpler than doing it in just one driver: if
> > we add a cs_gpio field to spi_board_info, spi_new_device could
> > just copy that information into the new spi_device instead of
> > taking it from master->cs_gpios.
> 
> Yeah, that bit of it is fine and straightforward.  It's slightly more
> work to factor the chip select handling out so that we can implement the
> handling at the appropriate moments in the flow due to the fact that
> it's embedded in the message transfer functions but totally doable.

Initial try to simplify i.MX SPI driver I will send in 5 min.
Patches is untested, so it is only RFC. Platform data still present in
driver but patch migrate driver to using dynamic counter of
chipselects for dt-case. Is it true way now? Comments are welcome.
Thanks.

---

  reply	other threads:[~2013-05-29 17:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29  6:42 [PATCH] SPI: Unify simple platform data for some controllers Alexander Shiyan
2013-05-29  7:56 ` Arnd Bergmann
2013-05-29  8:49   ` Alexander Shiyan
2013-05-29 11:20     ` Mark Brown
2013-05-29 13:26       ` Arnd Bergmann
2013-05-29 14:49         ` Mark Brown
2013-05-29 17:05           ` Alexander Shiyan [this message]
2013-05-29 18:10             ` Arnd Bergmann
2013-05-30  1:50               ` Shawn Guo
     [not found]           ` <1369847430-10799-1-git-send-email-shc_work@mail.ru>
2013-05-30  2:05             ` [RFC 1/3] SPI: imx: Convert to devm_* API Shawn Guo
     [not found]               ` <1369885838.170762928@f286.mail.ru>
2013-05-30  4:06                 ` Shawn Guo
     [not found]             ` <1369847430-10799-2-git-send-email-shc_work@mail.ru>
2013-05-30  2:42               ` [RFC 2/3] SPI: imx: Using SPI-master "cs_gpios" field for array of chipselects instead of private Shawn Guo
2013-05-30  3:22               ` Shawn Guo
     [not found]             ` <1369847430-10799-3-git-send-email-shc_work@mail.ru>
2013-05-30  3:36               ` [RFC 3/3] SPI: imx: Using dynamic count of chipselects provided by of_spi_register_master Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369847158.250798748@f433.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox