From: Michal Simek <michal.simek@amd.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
<linux-arm-kernel@lists.infradead.org>
Cc: <kernel@pengutronix.de>, <robh+dt@kernel.org>,
<michal.simek@xilinx.com>, <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller)
Date: Wed, 30 Nov 2022 18:08:44 +0100 [thread overview]
Message-ID: <136f33d8-0bd9-d212-1efd-5de1df8117a9@amd.com> (raw)
In-Reply-To: <7c41e150-8d75-cc5d-2815-2fd3198b6b4a@pengutronix.de>
Hi,
On 11/30/22 18:02, Ahmad Fatoum wrote:
> Hello!
>
> On 23.10.22 23:56, Michael Grzeschik wrote:
>> Since we need to support legacy phys with the dwc3 controller,
>> we enable this quirk on the zynqmp platforms.
>
> Slightly off-topic question below.
>
>>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> ---
>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index a549265e55f6e7..7c1af75f33a05b 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 {
>> clock-names = "bus_early", "ref";
>> iommus = <&smmu 0x860>;
>> snps,quirk-frame-length-adjustment = <0x20>;
>> + snps,resume-hs-terminations;
>> /* dma-coherent; */
>
> Is it possible to configure coherent DMA for the device and this is currently
> not done or how should this comment be interpreted?
I didn't try it for a while but before you start a53 you can enable CCI and then
dma-coherent flags should be enabled.
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-30 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 21:56 [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller Michael Grzeschik
2022-11-14 15:57 ` Michael Grzeschik
2022-11-30 16:57 ` Michal Simek
2022-11-30 17:02 ` Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller) Ahmad Fatoum
2022-11-30 17:08 ` Michal Simek [this message]
2022-11-30 17:12 ` Ahmad Fatoum
2022-11-30 17:17 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=136f33d8-0bd9-d212-1efd-5de1df8117a9@amd.com \
--to=michal.simek@amd.com \
--cc=a.fatoum@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.grzeschik@pengutronix.de \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox