From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A463C433FE for ; Wed, 30 Nov 2022 17:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=po7SzNMdw22M6MQI5kV9CwtMZYkHRmOe8g8ccyHtlzQ=; b=0W44fkqKm0CpV1 QY8ZBCNQdywV7W7ZqKS69PuPmoluRy9Ew2AicExs2ajUU2349BI2hojc/ol2Oi5tzwgZoyoYgWWYe mA7R2U/pYpWQJ54MyNt68m63lrZZ6Q16nWAhhVfuCd+6hSpkXeQuzTIaIq2RFmdSByVgXm5ni2DQB sNpJdxcSaORD4V54RcPSdf+tUfh16WNGjRUNvCOTPo62G+X8ppvSh+hZFF6a+e+U50jDKXaIgqhUa VUliXoVtL/35pn0JpmE6txFDgwC0TKYmObx0Pz0sXU+wT+HC+A7ilgmS/D5rlLhyzL5twEN5OoI/K Fq3JWJpIsKFL5jpfZGqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0Qa1-000piY-NA; Wed, 30 Nov 2022 17:09:09 +0000 Received: from mail-bn8nam12on20611.outbound.protection.outlook.com ([2a01:111:f400:fe5b::611] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0QZu-000pdD-N5 for linux-arm-kernel@lists.infradead.org; Wed, 30 Nov 2022 17:09:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MJdvwefnC0UejEYJBaoLxQBvUa1ri4yCFhbbNhglQdfSykp2caTJYEEx7HbH51QgF5kEhyYEe2Uq0Z8yRT+r5tg/hZCmii3G7qzDtjxV+QV18CvSFoerCwomn/zNlTcoWeeSYa8WtouqrWWGE3m4xbSIHcE4CnQ3ld4MR9kI45xEWq3BXBaQMsTVXkkDXYhFnyEZQWPTDu4YCBRV2ekYcoQjHYMr/hzYGwGr61Mf+7/JYvtKP8XuRJsO+dqUJhbk0ThI31/LpwUS71/ZumS/YZ6QF1Jp5grygQvbqcKl2+VdTJrmgjuecc9Bg3VJH2CpZH6TlnVCgNqRs35mLk0hsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tRGA4PXzSOPGV2JSX1NDG8xs3UosHxSIwSva7CnASYk=; b=HS+BH3lQ1d5WZ2vN+yveCzwuBMnCP4IMgSUrz+XlgWEJm6RnKAilNWdTnxAaM6uxWSbHEYQO7FG85yaOctgBNCDI8kbzoLwi6UGuTIjMno58q877CrIEGkapraV3C2lP8w26fe0rylf+75YMLZmLwgRBu4bJ00QhtMe1vxPru003STN++/yqdax4WZtX+EAA6pg8GTvxCRU5dVk3OA9q1u2MQJ4uh+nMvnpWMuv47Cvys6uT1+2Hdpt6L8+PSJ6Ma2+m9mJG+4rI6hP8NEMMdiRt+0jT3R8/Z66vAlLU3HPRZrLnXE43nNNBqcF1TNQ5tEEKK3oXIHvLGyalbSnjDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=pengutronix.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tRGA4PXzSOPGV2JSX1NDG8xs3UosHxSIwSva7CnASYk=; b=fnxN5lhcSlU1ta9n/5bV6zwlz/RJEcwaa+QgCbnp/+3xrBXMLmr//8RLwHDRbY8BSYBsr9oLjFqQx/3Psiq/VAeIVjonXOECO1lG4QLAJ6EABBqQZBSiDR2Nk5uipqJdu7B7glGUNmD2Q+AW2Snv8bFYzlD3uVFdOkqt4nzER/4= Received: from MW4PR03CA0124.namprd03.prod.outlook.com (2603:10b6:303:8c::9) by SJ0PR12MB6686.namprd12.prod.outlook.com (2603:10b6:a03:479::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Wed, 30 Nov 2022 17:08:52 +0000 Received: from CO1NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::3e) by MW4PR03CA0124.outlook.office365.com (2603:10b6:303:8c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23 via Frontend Transport; Wed, 30 Nov 2022 17:08:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT039.mail.protection.outlook.com (10.13.174.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5857.23 via Frontend Transport; Wed, 30 Nov 2022 17:08:50 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 30 Nov 2022 11:08:47 -0600 Message-ID: <136f33d8-0bd9-d212-1efd-5de1df8117a9@amd.com> Date: Wed, 30 Nov 2022 18:08:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: Meaning of commented out dma-coherent in ZynqMP DWC3 DT node (Was: Re: [PATCH] arm64: zynqmp: Enable hs termination flag for USB dwc3 controller) Content-Language: en-US To: Ahmad Fatoum , Michael Grzeschik , CC: , , , References: <20221023215649.221726-1-m.grzeschik@pengutronix.de> <7c41e150-8d75-cc5d-2815-2fd3198b6b4a@pengutronix.de> From: Michal Simek In-Reply-To: <7c41e150-8d75-cc5d-2815-2fd3198b6b4a@pengutronix.de> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT039:EE_|SJ0PR12MB6686:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c698069-48fb-4143-265e-08dad2f58dd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GMAoqicvC30KIFeHqppkmpU2ieLJTIISAgHCUW0CRs4p0SPjKNCHac97a7BznnqiM62MZxGbGuRGAw41xqKt/W7iZhVYdDcJYJukXI5gIWKCHYq9egCUvCAgzhQHIoxONWIcQY17T7g5QLOsU/iHz+MIr5puDZzWwqc+zF9rLB6/Mj3mVjON0cwxQNaxQpYAKCzWP3IyUmyYdYxyBtcpXWPoubHwxuEZBRuT9hlZiwXVwwRDORaHYsqXOVi2AQam5na36Qn7+In73GwTZG7XzIUY7thZVNU/bHyzr9BT0to87AM0Be/oso55ZOLY0mD1HymiV1EdpVsrxrEUzg55GPgz6jy9TNC2V6+mpJDAh3/dnXduqIRw0WZm1e+5clIMCN3h6MB+VX5oIE27hxoPIPYdpgXokiQO8nL37CTOTQwW5q+A+9uKFga7xzlf9yqObWQP3M0ju1oZFGFFMkTHw7fa0wCpTZUmDJIMFrr608SRONBQbD8hF7MkD8ldg5HJRWubM9WZDDJzuGTK8dhHbPwP6ZIDI5/T7SQtzF8ayPjsFsofNEoIXDlXZMQxsFFDErwcblQl6Sg7lurK1vTq/N4Fq9rcOZHBsa7/bSIOkKYo9WjYXabCI3HhSiFxj5jEPMqcwytYNkP5aAaP+EvXkIc14Epo03q1ccIxp5wn/IL9TC4jLcFNVx/fVTYwrSpPCm30yku7l/VVtw9F7KfwNZEcQCvF+BdqxsL/z4rSz4zrHQlDii3MOGi4wjo+q9rWtg6tBD2SmJ9RjCIU1KqBdg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(356005)(81166007)(82740400003)(36756003)(86362001)(31696002)(54906003)(316002)(40460700003)(16576012)(110136005)(40480700001)(44832011)(70586007)(8676002)(41300700001)(5660300002)(70206006)(4326008)(478600001)(2906002)(8936002)(83380400001)(53546011)(6666004)(26005)(36860700001)(82310400005)(336012)(16526019)(186003)(2616005)(47076005)(31686004)(426003)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 17:08:50.9214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c698069-48fb-4143-265e-08dad2f58dd2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6686 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_090859_165748_CC842D89 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 11/30/22 18:02, Ahmad Fatoum wrote: > Hello! > > On 23.10.22 23:56, Michael Grzeschik wrote: >> Since we need to support legacy phys with the dwc3 controller, >> we enable this quirk on the zynqmp platforms. > > Slightly off-topic question below. > >> >> Signed-off-by: Michael Grzeschik >> --- >> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> index a549265e55f6e7..7c1af75f33a05b 100644 >> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> @@ -825,6 +825,7 @@ dwc3_0: usb@fe200000 { >> clock-names = "bus_early", "ref"; >> iommus = <&smmu 0x860>; >> snps,quirk-frame-length-adjustment = <0x20>; >> + snps,resume-hs-terminations; >> /* dma-coherent; */ > > Is it possible to configure coherent DMA for the device and this is currently > not done or how should this comment be interpreted? I didn't try it for a while but before you start a53 you can enable CCI and then dma-coherent flags should be enabled. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel