From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A138EC5519F for ; Mon, 30 Nov 2020 09:39:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25A14207BC for ; Mon, 30 Nov 2020 09:39:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c1hMsBU4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25A14207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gj5XwC5hID1juAIcGvJ5IpTGxm2/R+a0UK2TdzEeQFY=; b=c1hMsBU4xyuUBXEzNLdpHmzIT qgka3v3C6uJafoP5z0FUJD33QB1wKEfXFUGB+j400EAXCrRdkns1S7TmL1ykzMGg+DqIsg8dellf3 cOM5ltepEWzNxVjqSdryAxNi9cn5GEELbnBHrKGWHibBZXTbV86ZrBJUUjinl+7qZrDg5ZKvHKRhu 5oMshgldWXSbx0lnoMpE3/oG/SyuoGpvLV53xIILD+98kjmP5HjNIh1dDJ53U/2GO3BNZtUk7EKkO i0b0HVori0YWbzM6ZlnhXkNJGcPYzHpLKaa1i4Apl4NLVJgLm9kW4ajO2Bz0Pw5k82YzbArqCcSBW 3F50hwH6w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjfdI-0001qM-Ij; Mon, 30 Nov 2020 09:38:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjfdE-0001pL-Hk for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 09:38:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B6898101E; Mon, 30 Nov 2020 01:38:03 -0800 (PST) Received: from [10.57.56.151] (unknown [10.57.56.151]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C83B93F23F; Mon, 30 Nov 2020 01:38:00 -0800 (PST) Subject: Re: [PATCH v4 02/25] coresight: etm4x: Skip accessing TRCPDCR in save/restore To: Mathieu Poirier References: <20201119164547.2982871-1-suzuki.poulose@arm.com> <20201119164547.2982871-3-suzuki.poulose@arm.com> <20201127185522.GB1092947@xps15> From: Suzuki K Poulose Message-ID: <136f420d-7848-3ba3-fbb0-9f7edee1377b@arm.com> Date: Mon, 30 Nov 2020 09:37:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201127185522.GB1092947@xps15> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_043804_721826_7329C10A X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Prakash Ranjan , anshuman.khandual@arm.com, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tingwei Zhang , jonathan.zhouwen@huawei.com, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/27/20 6:55 PM, Mathieu Poirier wrote: > On Thu, Nov 19, 2020 at 04:45:24PM +0000, Suzuki K Poulose wrote: >> When the ETM is affected by Qualcomm errata, modifying the >> TRCPDCR could cause the system hang. Even though this is >> taken care of during enable/disable ETM, the ETM state >> save/restore could still access the TRCPDCR. Make sure >> we skip the access during the save/restore. >> >> Found by code inspection. >> >> Fixes: commit 02510a5aa78df45 ("coresight: etm4x: Add support to skip trace unit power up") > > https://elixir.bootlin.com/linux/v5.10-rc5/source/Documentation/process/submitting-patches.rst#L121 Thanks, I will remove the "commit". Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel