* [PATCH] mfd: twl4030: allow IRQ wake enable to succeed on subchip IRQs
@ 2013-05-31 21:44 Kevin Hilman
2013-06-17 23:47 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hilman @ 2013-05-31 21:44 UTC (permalink / raw)
To: linux-arm-kernel
The genirq IRQ wake method will default to failure if the irq_chip
does not provide a set_wake method. However, for TWL4030 sub-chip
IRQs, we want the wake enable to succeed even though we don't provide
a set_wake method. This allows sub-chip IRQs to still be flagged as
wakeup capable, and allow them to wakeup from suspend (or abort
suspend if they fire during suspend.)
To fix, use the IRQCHIP_SKIP_SET_WAKE flag in the irq_chip.
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
drivers/mfd/twl4030-irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index a5f9888..3fa7df2 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -573,6 +573,7 @@ static struct irq_chip twl4030_sih_irq_chip = {
.irq_set_type = twl4030_sih_set_type,
.irq_bus_lock = twl4030_sih_bus_lock,
.irq_bus_sync_unlock = twl4030_sih_bus_sync_unlock,
+ .flags = IRQCHIP_SKIP_SET_WAKE,
};
/*----------------------------------------------------------------------*/
--
1.8.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] mfd: twl4030: allow IRQ wake enable to succeed on subchip IRQs
2013-05-31 21:44 [PATCH] mfd: twl4030: allow IRQ wake enable to succeed on subchip IRQs Kevin Hilman
@ 2013-06-17 23:47 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2013-06-17 23:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kevin,
On Fri, May 31, 2013 at 02:44:54PM -0700, Kevin Hilman wrote:
> The genirq IRQ wake method will default to failure if the irq_chip
> does not provide a set_wake method. However, for TWL4030 sub-chip
> IRQs, we want the wake enable to succeed even though we don't provide
> a set_wake method. This allows sub-chip IRQs to still be flagged as
> wakeup capable, and allow them to wakeup from suspend (or abort
> suspend if they fire during suspend.)
>
> To fix, use the IRQCHIP_SKIP_SET_WAKE flag in the irq_chip.
>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to mfd-next, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-17 23:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 21:44 [PATCH] mfd: twl4030: allow IRQ wake enable to succeed on subchip IRQs Kevin Hilman
2013-06-17 23:47 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).