From: jiada_wang@mentor.com (Jiada Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] clk: implement clk_unregister
Date: Mon, 3 Jun 2013 17:37:06 +0900 [thread overview]
Message-ID: <1370248626-3760-1-git-send-email-jiada_wang@mentor.com> (raw)
Currently clk_unregister is unimplemented, it is required in case
sub modules want actually remove clk device registered by clk_register.
This patch adds the implementation of clk_unregister.
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
drivers/clk/clk.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 57 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 934cfd1..0b9e13c 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -342,6 +342,25 @@ out:
return ret;
}
+ /**
+ * clk_debug_unregister - remove a clk node from the debugfs clk tree
+ * @clk: the clk being removed from the debugfs clk tree
+ *
+ * Dynamically removes a clk and all it's children clk nodes from the
+ * debugfs clk tree if clk->dentry points to debugfs created by
+ * clk_debug_register in __clk_init.
+ *
+ * Caller must hold prepare_lock.
+ *
+ */
+static void clk_debug_unregister(struct clk *clk)
+{
+ if (!clk || !clk->dentry)
+ return;
+
+ debugfs_remove_recursive(clk->dentry);
+}
+
/**
* clk_debug_reparent - reparent clk node in the debugfs clk tree
* @clk: the clk being reparented
@@ -432,6 +451,9 @@ static inline int clk_debug_register(struct clk *clk) { return 0; }
static inline void clk_debug_reparent(struct clk *clk, struct clk *new_parent)
{
}
+static inline void clk_debug_unregister(struct clk *clk)
+{
+}
#endif
/* caller must hold prepare_lock */
@@ -1790,9 +1812,42 @@ EXPORT_SYMBOL_GPL(clk_register);
* clk_unregister - unregister a currently registered clock
* @clk: clock to unregister
*
- * Currently unimplemented.
*/
-void clk_unregister(struct clk *clk) {}
+void clk_unregister(struct clk *clk)
+{
+ int i;
+
+ if (!clk)
+ return;
+
+ mutex_lock(&prepare_lock);
+ if (clk->prepare_count) {
+ pr_debug("%s: can't unregister clk %s, it is prepared\n",
+ __func__, clk->name);
+ goto out;
+ }
+
+ if (!hlist_empty(&clk->children)) {
+ pr_debug("%s: clk %s has registered children\n",
+ __func__, clk->name);
+ goto out;
+ }
+
+ clk_debug_unregister(clk);
+
+ hlist_del_init(&clk->child_node);
+
+ kfree(clk->parents);
+ i = clk->num_parents;
+ while (--i >= 0)
+ kfree(clk->parent_names[i]);
+ kfree(clk->parent_names);
+ kfree(clk->name);
+ kfree(clk);
+out:
+ mutex_unlock(&prepare_lock);
+ return;
+}
EXPORT_SYMBOL_GPL(clk_unregister);
static void devm_clk_release(struct device *dev, void *res)
--
1.8.1.1
next reply other threads:[~2013-06-03 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 8:37 Jiada Wang [this message]
2013-06-03 9:11 ` [PATCH v3] clk: implement clk_unregister Uwe Kleine-König
[not found] ` <857E9EDCA6C0904DB3357321AA9123EB6246498A@NA-MBX-03.mgc.mentorg.com>
2013-06-04 7:29 ` Jiada Wang
2013-06-03 9:46 ` Russell King - ARM Linux
[not found] ` <857E9EDCA6C0904DB3357321AA9123EB6246497F@NA-MBX-03.mgc.mentorg.com>
2013-06-04 7:43 ` Jiada Wang
2013-07-17 11:28 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370248626-3760-1-git-send-email-jiada_wang@mentor.com \
--to=jiada_wang@mentor.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).