[PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

[PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

[Stephen Boyd]

Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver,
2013-03-04) was based on an older kernel where __devinit still
existed. Remove the erroneous __devinit marking.

Cc: David Brown <davidb@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/gpio/gpio-msm-v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
index c798585a..fb2cc90 100644
--- a/drivers/gpio/gpio-msm-v1.c
+++ b/drivers/gpio/gpio-msm-v1.c
@@ -630,7 +630,7 @@ static struct irq_chip msm_gpio_irq_chip = {
 	.irq_set_type  = msm_gpio_irq_set_type,
 };
 
-static int __devinit gpio_msm_v1_probe(struct platform_device *pdev)
+static int gpio_msm_v1_probe(struct platform_device *pdev)
 {
 	int i, j = 0;
 	const struct platform_device_id *dev_id = platform_get_device_id(pdev);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

[Linus Walleij]

On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:

> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver,
> 2013-03-04) was based on an older kernel where __devinit still
> existed. Remove the erroneous __devinit marking.
>
> Cc: David Brown <davidb@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Patch applied.

Yours,
Linus Walleij

[PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

[Stephen Boyd]

On 06/16/13 22:54, Linus Walleij wrote:
> On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>
>> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver,
>> 2013-03-04) was based on an older kernel where __devinit still
>> existed. Remove the erroneous __devinit marking.
>>
>> Cc: David Brown <davidb@codeaurora.org>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Patch applied.
>
>

Thanks. It looks like David picked this up and sent it off to arm-soc
last week. Cc'ing Olof for awareness of a possible duplicate.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

[PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

[Linus Walleij]

On Mon, Jun 17, 2013 at 7:14 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 06/16/13 22:54, Linus Walleij wrote:
>> On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>>
>>> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver,
>>> 2013-03-04) was based on an older kernel where __devinit still
>>> existed. Remove the erroneous __devinit marking.
>>>
>>> Cc: David Brown <davidb@codeaurora.org>
>>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> Patch applied.
>
> Thanks. It looks like David picked this up and sent it off to arm-soc
> last week. Cc'ing Olof for awareness of a possible duplicate.

Did that get ack by some GPIO maintainer?

This needs to go through the GPIO tree, but I
guess GIT will survive if it ends up in two trees.

Yours,
Linus Walleij

[PATCH] gpio: msm-v1: Remove errant __devinit to fix compile

[Olof Johansson]

On Tue, Jun 18, 2013 at 11:16:17AM +0200, Linus Walleij wrote:
> On Mon, Jun 17, 2013 at 7:14 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 06/16/13 22:54, Linus Walleij wrote:
> >> On Tue, Jun 4, 2013 at 9:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> >>
> >>> Commit 7bce696 (gpio: Make gpio-msm-v1 into a platform driver,
> >>> 2013-03-04) was based on an older kernel where __devinit still
> >>> existed. Remove the erroneous __devinit marking.
> >>>
> >>> Cc: David Brown <davidb@codeaurora.org>
> >>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> >> Patch applied.
> >
> > Thanks. It looks like David picked this up and sent it off to arm-soc
> > last week. Cc'ing Olof for awareness of a possible duplicate.
> 
> Did that get ack by some GPIO maintainer?
> 
> This needs to go through the GPIO tree, but I
> guess GIT will survive if it ends up in two trees.

Nope, and it slipped through the cracks. More and more patches that we see lack
proper acks, and it's becoming a problem. I have to go search for them on the
lists and see if they came in without being tagged on the patch, etc.

Time to get more strict on that, obviously. :(

But yeah, one duplicate trivial patch like this shouldn't be an issue.


-Olof