From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] ARM: imx: clk-pllv3: change wait method for PLL lock
Date: Fri, 7 Jun 2013 16:19:06 +0800 [thread overview]
Message-ID: <1370593146-14025-1-git-send-email-peter.chen@freescale.com> (raw)
For some unknown reasons, the jiffies will be updated more
than one tick at every short time. Eg, at this code:
After timeout = jiffies + msecs_to_jiffies(10),
the interrupt occurs, and the softirq updates jiffies (eg, + 2 jiffies),
then return back from interrupt, the time between above operations
are tiny, the PLL is still not locked, but the timeout condition is satisfied.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
Changes for v2:
- According to Russell King's suggestion, change code for more reasonable
for timeout condition.
- Change commit log.
arch/arm/mach-imx/clk-pllv3.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/clk-pllv3.c b/arch/arm/mach-imx/clk-pllv3.c
index d09bc3d..52e54df 100644
--- a/arch/arm/mach-imx/clk-pllv3.c
+++ b/arch/arm/mach-imx/clk-pllv3.c
@@ -16,6 +16,7 @@
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/err.h>
+#include <linux/delay.h>
#include "clk.h"
#define PLL_NUM_OFFSET 0x10
@@ -48,7 +49,7 @@ struct clk_pllv3 {
static int clk_pllv3_prepare(struct clk_hw *hw)
{
struct clk_pllv3 *pll = to_clk_pllv3(hw);
- unsigned long timeout = jiffies + msecs_to_jiffies(10);
+ int count = 100;
u32 val;
val = readl_relaxed(pll->base);
@@ -60,9 +61,14 @@ static int clk_pllv3_prepare(struct clk_hw *hw)
writel_relaxed(val, pll->base);
/* Wait for PLL to lock */
- while (!(readl_relaxed(pll->base) & BM_PLL_LOCK))
- if (time_after(jiffies, timeout))
- return -ETIMEDOUT;
+ do {
+ if (readl_relaxed(pll->base) & BM_PLL_LOCK)
+ break;
+ udelay(100);
+ } while (count--);
+
+ if (count == 0 && !(readl_relaxed(pll->base) & BM_PLL_LOCK))
+ return -ETIMEDOUT;
return 0;
}
--
1.7.0.4
next reply other threads:[~2013-06-07 8:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 8:19 Peter Chen [this message]
2013-06-07 8:24 ` [PATCH v2 1/1] ARM: imx: clk-pllv3: change wait method for PLL lock Uwe Kleine-König
2013-06-07 8:31 ` Peter Chen
2013-06-07 8:35 ` Uwe Kleine-König
2013-06-07 8:43 ` Peter Chen
2013-06-07 8:49 ` Uwe Kleine-König
2013-06-07 11:07 ` Shawn Guo
2013-06-08 1:09 ` Peter Chen
2013-07-14 0:43 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370593146-14025-1-git-send-email-peter.chen@freescale.com \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).