From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: versatile: don't mark pen as __INIT
Date: Mon, 10 Jun 2013 16:07:24 +0100 [thread overview]
Message-ID: <1370876844-6599-1-git-send-email-mark.rutland@arm.com> (raw)
When booting fewer cores than are physically present on a versatile
platform (e.g. when passing maxcpus=N on the command line), some
secondary cores may remain in the holding pen, which is marked __INIT.
Late in the boot process, the memory comprising the holding pen will be
released to the kernel for more general use, and may be overwritten with
arbitrary data, which can cause the held secondaries to start behaving
unpredictably. This can lead to all manner of odd behaviour from the
kernel.
Instead don't mark the section as __INIT. This means we can't reuse the
pen memory, but we won't get secondaries corrupting the rest of the
kernel.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Pawel Moll <pawel.moll@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
---
arch/arm/plat-versatile/headsmp.S | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S
index b178d44..2677bc3 100644
--- a/arch/arm/plat-versatile/headsmp.S
+++ b/arch/arm/plat-versatile/headsmp.S
@@ -11,8 +11,6 @@
#include <linux/linkage.h>
#include <linux/init.h>
- __INIT
-
/*
* Realview/Versatile Express specific entry point for secondary CPUs.
* This provides a "holding pen" into which all secondary cores are held
--
1.8.1.1
next reply other threads:[~2013-06-10 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 15:07 Mark Rutland [this message]
2013-06-10 15:35 ` [PATCH] arm: versatile: don't mark pen as __INIT Jonathan Austin
2013-06-10 18:39 ` Stephen Boyd
2013-06-10 18:52 ` Mark Rutland
2013-06-10 19:09 ` Stephen Boyd
2013-06-10 19:22 ` Stephen Boyd
2013-06-10 20:39 ` Lorenzo Pieralisi
2013-06-10 21:23 ` Stephen Boyd
2013-06-10 23:24 ` Russell King - ARM Linux
2013-06-11 9:04 ` Mark Rutland
2013-06-11 15:43 ` Nicolas Pitre
2013-06-17 10:10 ` Mark Rutland
2013-06-17 11:25 ` Nicolas Pitre
2013-06-20 14:10 ` Mark Rutland
2013-06-18 13:26 ` Jon Medhurst (Tixy)
2013-06-18 15:13 ` Russell King - ARM Linux
2013-06-18 15:28 ` Jon Medhurst (Tixy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370876844-6599-1-git-send-email-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).