From: josephl@nvidia.com (Joseph Lo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] ARM: tegra114: cpuidle: add powered-down state
Date: Thu, 13 Jun 2013 10:13:39 +0800 [thread overview]
Message-ID: <1371089619.1681.21.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <51B8B2C8.1090006@wwwdotorg.org>
On Thu, 2013-06-13 at 01:41 +0800, Stephen Warren wrote:
> On 06/04/2013 03:40 PM, Daniel Lezcano wrote:
> > On 06/04/2013 12:48 PM, Joseph Lo wrote:
> >> This supports CPU core power down on each CPU when CPU idle. When CPU go
> >> into this state, it saves it's context and needs a proper configuration
> >> in flow controller to power gate the CPU when CPU runs into WFI
> >> instruction. And the CPU also needs to set the IRQ as CPU power down idle
> >> wake up event in flow controller.
> >>
> >> Signed-off-by: Joseph Lo <josephl@nvidia.com>
> >
> > I would like to understand why there is a WARN with the
> > CPUIDLE_FLAG_TIMER_STOP flag set before queuing this patch and ensure it
> > is not the tree hiding the forest.
>
> Joseph, are you planning to post an updated series or respond to resolve
> Daniel's question?
I need more time to investigate the detail about what caused the WARN
when apply the flag. And what's the difference if we didn't enable
CONFIG_CPU_IDLE_MULTIPLE_DRIVERS, then it only applies
CLOCK_EVT_NOTIFY_BROADCAST_ON on CPU0. Why if I am moving the
clockevent_notify of CLOCK_EVT_NOTIFY_BROADCAST_EXIT before
"local_irq_enable" in the
"cpuidle_enter_state" (drivers/cpuidle/cpuidle.c), then the warning
message gone?
Daniel,
Because I need more time to figure it out, are you OK if I can post
another patch to apply CPUIDLE_FLAG_TIMER_STOP flag for all Tegra CPU
Idle drivers later? (Once we know what's the problem behind this)
Stephen,
I don't have an update of this series, if Daniel is OK if I can post
another patch to apply TIMER_STOP flag for all Tegra idle drivers.
Thanks,
Joseph
next prev parent reply other threads:[~2013-06-13 2:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 10:47 [PATCH V2 0/3] ARM: tegra114: cpuidle: add power down state Joseph Lo
2013-06-04 10:47 ` [PATCH V2 1/3] ARM: tegra114: Reprogram GIC CPU interface to bypass IRQ on CPU PM entry Joseph Lo
2013-06-04 10:47 ` [PATCH V2 2/3] ARM: tegra114: add low level support for CPU idle powered-down mode Joseph Lo
2013-06-04 10:48 ` [PATCH V2 3/3] ARM: tegra114: cpuidle: add powered-down state Joseph Lo
2013-06-04 21:40 ` Daniel Lezcano
2013-06-12 17:41 ` Stephen Warren
2013-06-13 2:13 ` Joseph Lo [this message]
2013-06-13 9:30 ` Daniel Lezcano
2013-06-13 14:32 ` Joseph Lo
2013-06-13 15:02 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371089619.1681.21.camel@jlo-ubuntu-64.nvidia.com \
--to=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).