* [PATCH] ARM: dts: Enable RTC node for exynos5250
@ 2013-06-14 5:56 Tushar Behera
2013-06-14 15:01 ` Doug Anderson
0 siblings, 1 reply; 6+ messages in thread
From: Tushar Behera @ 2013-06-14 5:56 UTC (permalink / raw)
To: linux-arm-kernel
The kernel dump produced by s3c-rtc driver as reported by
commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5")
are no longer reproducible in latest kernel.
Hence it would be good to re-enable RTC support for EXYNOS5250.
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
arch/arm/boot/dts/exynos5250.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 0673524..ce4a150 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -188,7 +188,6 @@
interrupts = <0 43 0>, <0 44 0>;
clocks = <&clock 337>;
clock-names = "rtc";
- status = "disabled";
};
tmu at 10060000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: Enable RTC node for exynos5250
2013-06-14 5:56 [PATCH] ARM: dts: Enable RTC node for exynos5250 Tushar Behera
@ 2013-06-14 15:01 ` Doug Anderson
2013-06-17 3:11 ` Tushar Behera
0 siblings, 1 reply; 6+ messages in thread
From: Doug Anderson @ 2013-06-14 15:01 UTC (permalink / raw)
To: linux-arm-kernel
Tushar,
On Thu, Jun 13, 2013 at 10:56 PM, Tushar Behera
<tushar.behera@linaro.org> wrote:
> The kernel dump produced by s3c-rtc driver as reported by
> commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5")
> are no longer reproducible in latest kernel.
>
> Hence it would be good to re-enable RTC support for EXYNOS5250.
>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 1 -
> 1 file changed, 1 deletion(-)
I would prefer we not commit this.
The original commit wasn't just about avoiding the bug (though that
was a nice side effect). My understanding is that the SoC dtsi file
ought to have most peripherals disabled by default and individual
board dts files should enable the peripherals that they want. I think
exynos5250 is particularly bad about this right now (it starts with
most peripherals enabled) but that should probably be fixed...
If my understanding is wrong, others on the list should definitely speak up! :)
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: Enable RTC node for exynos5250
2013-06-14 15:01 ` Doug Anderson
@ 2013-06-17 3:11 ` Tushar Behera
2013-06-17 4:09 ` [PATCH V2] ARM: dts: Enable RTC node for Arndale Tushar Behera
0 siblings, 1 reply; 6+ messages in thread
From: Tushar Behera @ 2013-06-17 3:11 UTC (permalink / raw)
To: linux-arm-kernel
On 14 June 2013 20:31, Doug Anderson <dianders@chromium.org> wrote:
> Tushar,
>
> On Thu, Jun 13, 2013 at 10:56 PM, Tushar Behera
> <tushar.behera@linaro.org> wrote:
>> The kernel dump produced by s3c-rtc driver as reported by
>> commit 522ccdb6fd0e ("ARM: dts: Disable the RTC by default on exynos5")
>> are no longer reproducible in latest kernel.
>>
>> Hence it would be good to re-enable RTC support for EXYNOS5250.
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>
> I would prefer we not commit this.
>
> The original commit wasn't just about avoiding the bug (though that
I thought the intention of the original commit was just that. :-)
> was a nice side effect). My understanding is that the SoC dtsi file
> ought to have most peripherals disabled by default and individual
> board dts files should enable the peripherals that they want. I think
> exynos5250 is particularly bad about this right now (it starts with
> most peripherals enabled) but that should probably be fixed...
>
I agree, all the peripherals should be fixed for this, not just RTC.
> If my understanding is wrong, others on the list should definitely speak up! :)
>
Let me know if you still prefer to keep RTC node disabled on exynos5250.dtsi.
In that case, I would enable it only for Arndale.
> -Doug
Thanks.
--
Tushar Behera
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] ARM: dts: Enable RTC node for Arndale
2013-06-17 3:11 ` Tushar Behera
@ 2013-06-17 4:09 ` Tushar Behera
2013-06-17 14:55 ` Doug Anderson
2013-06-17 15:10 ` Kukjin Kim
0 siblings, 2 replies; 6+ messages in thread
From: Tushar Behera @ 2013-06-17 4:09 UTC (permalink / raw)
To: linux-arm-kernel
The issues reported in commit 522ccdb6fd0e ("ARM: dts: Disable the RTC
by default on exynos5") are no longer reproduced on EXYNOS5250 based
Arndale board. Hence re-enabling RTC support for Arndale board.
This is helpful for testing S2R on Arndale board.
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
Changes for V2:
* RTC node is enabled only for Arndale board. Earlier it was enabled
in exynos5250.dtsi.
arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 02cfc76..b38080a 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -449,4 +449,8 @@
clock-frequency = <24000000>;
};
};
+
+ rtc {
+ status = "okay";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2] ARM: dts: Enable RTC node for Arndale
2013-06-17 4:09 ` [PATCH V2] ARM: dts: Enable RTC node for Arndale Tushar Behera
@ 2013-06-17 14:55 ` Doug Anderson
2013-06-17 15:10 ` Kukjin Kim
1 sibling, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2013-06-17 14:55 UTC (permalink / raw)
To: linux-arm-kernel
Tushar,
On Sun, Jun 16, 2013 at 9:09 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> The issues reported in commit 522ccdb6fd0e ("ARM: dts: Disable the RTC
> by default on exynos5") are no longer reproduced on EXYNOS5250 based
> Arndale board. Hence re-enabling RTC support for Arndale board.
>
> This is helpful for testing S2R on Arndale board.
>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> Changes for V2:
> * RTC node is enabled only for Arndale board. Earlier it was enabled
> in exynos5250.dtsi.
>
> arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++++
> 1 file changed, 4 insertions(+)
Looks good! I'll send up one for snow too.
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] ARM: dts: Enable RTC node for Arndale
2013-06-17 4:09 ` [PATCH V2] ARM: dts: Enable RTC node for Arndale Tushar Behera
2013-06-17 14:55 ` Doug Anderson
@ 2013-06-17 15:10 ` Kukjin Kim
1 sibling, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-06-17 15:10 UTC (permalink / raw)
To: linux-arm-kernel
On 06/17/13 13:09, Tushar Behera wrote:
> The issues reported in commit 522ccdb6fd0e ("ARM: dts: Disable the RTC
> by default on exynos5") are no longer reproduced on EXYNOS5250 based
> Arndale board. Hence re-enabling RTC support for Arndale board.
>
> This is helpful for testing S2R on Arndale board.
>
> Signed-off-by: Tushar Behera<tushar.behera@linaro.org>
> ---
> Changes for V2:
> * RTC node is enabled only for Arndale board. Earlier it was enabled
> in exynos5250.dtsi.
>
> arch/arm/boot/dts/exynos5250-arndale.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> index 02cfc76..b38080a 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -449,4 +449,8 @@
> clock-frequency =<24000000>;
> };
> };
> +
> + rtc {
> + status = "okay";
> + };
> };
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-17 15:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-14 5:56 [PATCH] ARM: dts: Enable RTC node for exynos5250 Tushar Behera
2013-06-14 15:01 ` Doug Anderson
2013-06-17 3:11 ` Tushar Behera
2013-06-17 4:09 ` [PATCH V2] ARM: dts: Enable RTC node for Arndale Tushar Behera
2013-06-17 14:55 ` Doug Anderson
2013-06-17 15:10 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).