From: ambresh@ti.com (Ambresh K)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 0/3] Fix to clk framework while handling orphan clks
Date: Mon, 17 Jun 2013 14:09:41 +0530 [thread overview]
Message-ID: <1371458384-23936-1-git-send-email-ambresh@ti.com> (raw)
From: Ambresh K <ambresh@ti.com>
On a possible HW bug or in-correct configuration of MUX register's in
bootloader; might return a value greater than available parent clocks
for a MUX clk.
Sensing invalid parent index, clk_mux_get_parent returns -EINVALID.
Due to function's "u8" return type it will get converted into signed value,
thus causing following pointer dereference on test platform.
M[ 0.000000] dra7xx_clk_init: clk init (gpu_core_gclk_mux)^M
^M[ 0.000000] Unable to handle kernel NULL pointer dereference at virtual
address 00000000^M
^M[ 0.000000] pgd = c0004000^M
^M[ 0.000000] [00000000] *pgd=00000000^M
^M[ 0.000000] Internal error: Oops: 5 [#1] SMP ARM^M
^M[ 0.000000] Modules linked in:^M
^M[ 0.000000] CPU: 0 Not tainted (3.8.4-gb746a7c-dirty #59)^M
^M[ 0.000000] PC is at strcmp+0x8/0x34^M
Changes since v1:
- Fixed review comments.
- Fixed return type of .get_parent callback function.
Ambresh K (3):
clk: fix clk_mux_get_parent return's signed value
clk: skip re-parenting orphan clk
ARM: OMAP2+: clk: Fix return type of callbacks
arch/arm/mach-omap2/clkt_clksel.c | 2 +-
arch/arm/mach-omap2/clkt_dpll.c | 2 +-
arch/arm/mach-omap2/clock.h | 4 ++--
drivers/clk/clk-mux.c | 2 +-
drivers/clk/clk.c | 16 +++++++++++++++-
include/linux/clk-provider.h | 6 +++---
6 files changed, 23 insertions(+), 9 deletions(-)
--
1.7.4.1
next reply other threads:[~2013-06-17 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 8:39 Ambresh K [this message]
2013-06-17 8:39 ` [PATCH V2 1/3] clk: fix clk_mux_get_parent return's signed value Ambresh K
2013-06-17 8:39 ` [PATCH V2 2/3] clk: skip re-parenting orphan clk Ambresh K
2013-06-17 8:39 ` [PATCH V2 3/3] ARM: OMAP2+: clk: Fix return type of callbacks Ambresh K
2013-06-21 18:13 ` Mike Turquette
2013-06-24 4:51 ` Ambresh K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371458384-23936-1-git-send-email-ambresh@ti.com \
--to=ambresh@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).