* [PATCH] ARM: OMAP2: reboot: Include common.h to fix build error
@ 2013-06-19 17:46 Axel Lin
2013-06-20 5:59 ` Mohammed, Afzal
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-06-19 17:46 UTC (permalink / raw)
To: linux-arm-kernel
Include common.h which will include linux/reboot.h to fix below build error.
CC arch/arm/mach-omap2/omap4-restart.o
arch/arm/mach-omap2/omap4-restart.c:21:28: warning: 'enum reboot_mode' declared inside parameter list [enabled by default]
arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 ('mode') has incomplete type
arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Seems this build error is introduced by commit 7507d035f3cf40c
"reboot: arm: change reboot_mode to use enum reboot_mode"
This patch is against linux-next 20130619.
arch/arm/mach-omap2/omap4-restart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
index 652adde..7306d9b 100644
--- a/arch/arm/mach-omap2/omap4-restart.c
+++ b/arch/arm/mach-omap2/omap4-restart.c
@@ -9,6 +9,7 @@
#include <linux/types.h>
#include "prminst44xx.h"
+#include "common.h"
/**
* omap44xx_restart - trigger a software restart of the SoC
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: OMAP2: reboot: Include common.h to fix build error
2013-06-19 17:46 [PATCH] ARM: OMAP2: reboot: Include common.h to fix build error Axel Lin
@ 2013-06-20 5:59 ` Mohammed, Afzal
0 siblings, 0 replies; 2+ messages in thread
From: Mohammed, Afzal @ 2013-06-20 5:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, Jun 19, 2013 at 23:16:41, Axel Lin wrote:
> Include common.h which will include linux/reboot.h to fix below build error.
>
> CC arch/arm/mach-omap2/omap4-restart.o
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: 'enum reboot_mode' declared inside parameter list [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 ('mode') has incomplete type
> arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> make[1]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Seems this build error is introduced by commit 7507d035f3cf40c
> "reboot: arm: change reboot_mode to use enum reboot_mode"
>
> This patch is against linux-next 20130619.
> diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c
> index 652adde..7306d9b 100644
> --- a/arch/arm/mach-omap2/omap4-restart.c
> +++ b/arch/arm/mach-omap2/omap4-restart.c
> @@ -9,6 +9,7 @@
>
> #include <linux/types.h>
> #include "prminst44xx.h"
> +#include "common.h"
Arnd has posted a patch [1] that includes reboot.h directly for
multiple platforms including this one.
Regards
Afzal
[1] https://lkml.org/lkml/2013/6/19/498
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-20 5:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-19 17:46 [PATCH] ARM: OMAP2: reboot: Include common.h to fix build error Axel Lin
2013-06-20 5:59 ` Mohammed, Afzal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).