[PATCH 0/6] ARM: dts: imx27 Phytec PhyCARD-S

[PATCH 0/6] ARM: dts: imx27 Phytec PhyCARD-S

[Markus Pargmann]

Hi,

This series adds some device nodes for imx27 and a board file for Phytec
PhyCARD-S. It is based on shawn's branch "imx/dt".

Regards,

Markus


Fabio Estevam (2):
      ARM: mx27: Replace clk_register_clkdev with clock DT lookup
      ARM: imx27: Use 'AITC' for the interrupt controller name

Markus Pargmann (4):
      ARM: dts: imx27: Add imx framebuffer device
      ARM: dts: imx27: Add 1-wire
      ARM: dts: imx27 cpufreq-cpu0 frequencies
      ARM: dts: Add device tree support for phycard pca100

 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/imx27-phytec-phycard-S.dts | 195 +++++++++++++++++++++++++++
 arch/arm/boot/dts/imx27.dtsi                 |  54 +++++++-
 arch/arm/mach-imx/Kconfig                    |   1 +
 4 files changed, 248 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-S.dts

[PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup

[Markus Pargmann]

From: Fabio Estevam <fabio.estevam@freescale.com>

Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
task for the clock devices easier.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
[Markus Pargmann: Add gpio clocks]
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 0695264..48c263c 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -208,6 +208,8 @@
 				#gpio-cells = <2>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				clocks = <&clks 47>;
+				clock-names = "ipg";
 			};
 
 			gpio2: gpio at 10015100 {
@@ -218,6 +220,8 @@
 				#gpio-cells = <2>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				clocks = <&clks 47>;
+				clock-names = "ipg";
 			};
 
 			gpio3: gpio at 10015200 {
@@ -228,6 +232,8 @@
 				#gpio-cells = <2>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				clocks = <&clks 47>;
+				clock-names = "ipg";
 			};
 
 			gpio4: gpio at 10015300 {
@@ -238,6 +244,8 @@
 				#gpio-cells = <2>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				clocks = <&clks 47>;
+				clock-names = "ipg";
 			};
 
 			gpio5: gpio at 10015400 {
@@ -248,6 +256,8 @@
 				#gpio-cells = <2>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				clocks = <&clks 47>;
+				clock-names = "ipg";
 			};
 
 			gpio6: gpio at 10015500 {
@@ -258,6 +268,8 @@
 				#gpio-cells = <2>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
+				clocks = <&clks 47>;
+				clock-names = "ipg";
 			};
 
 			cspi3: cspi at 10017000 {
-- 
1.8.2.1

Re: [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup

[Alexander Shiyan]

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
> task for the clock devices easier.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> [Markus Pargmann: Add gpio clocks]
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 0695264..48c263c 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -208,6 +208,8 @@
>  				#gpio-cells = <2>;
>  				interrupt-controller;
>  				#interrupt-cells = <2>;
> +				clocks = <&clks 47>;
> +				clock-names = "ipg";

Clock is not used in the gpio driver, so I doubt the usefulness of this patch.

---

[PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup

[Fabio Estevam]

On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
>> task for the clock devices easier.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> [Markus Pargmann: Add gpio clocks]
>> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
>> ---
>>  arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
>> index 0695264..48c263c 100644
>> --- a/arch/arm/boot/dts/imx27.dtsi
>> +++ b/arch/arm/boot/dts/imx27.dtsi
>> @@ -208,6 +208,8 @@
>>                               #gpio-cells = <2>;
>>                               interrupt-controller;
>>                               #interrupt-cells = <2>;
>> +                             clocks = <&clks 47>;
>> +                             clock-names = "ipg";
>
> Clock is not used in the gpio driver, so I doubt the usefulness of this patch.

I think you meant "this hunk", right?

My original patch did not have this part. It was added by Markus as
mentioned in the commit log, and I agree we should go with the
original version that did not add the gpio clock.

[PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup

[Fabio Estevam]

On Thu, Jun 20, 2013 at 12:35 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
>>> task for the clock devices easier.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>> [Markus Pargmann: Add gpio clocks]
>>> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
>>> ---
>>>  arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
>>> index 0695264..48c263c 100644
>>> --- a/arch/arm/boot/dts/imx27.dtsi
>>> +++ b/arch/arm/boot/dts/imx27.dtsi
>>> @@ -208,6 +208,8 @@
>>>                               #gpio-cells = <2>;
>>>                               interrupt-controller;
>>>                               #interrupt-cells = <2>;
>>> +                             clocks = <&clks 47>;
>>> +                             clock-names = "ipg";
>>
>> Clock is not used in the gpio driver, so I doubt the usefulness of this patch.
>
> I think you meant "this hunk", right?
>
> My original patch did not have this part. It was added by Markus as
> mentioned in the commit log, and I agree we should go with the
> original version that did not add the gpio clock.

Just checked and my original patch has already been applied:

commit c20736f1aba75bd4251e96ef3f487beebbaf41cc
Author: Fabio Estevam <fabio.estevam@freescale.com>
Date:   Wed Nov 28 15:55:30 2012 -0200

    ARM: mx27: Replace clk_register_clkdev with clock DT lookup

    Similarly as it was done for mx6q, use a DT lookup in order to make maintain
    task for the clock devices easier.

    Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
    Tested-by: Markus Pargmann <mpa@pengutronix.de>
    Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

, and it does not add the gpio clocks.

[PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup

[Markus Pargmann]

On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote:
> On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
> >> task for the clock devices easier.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> [Markus Pargmann: Add gpio clocks]
> >> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> >> ---
> >>  arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
> >>  1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> >> index 0695264..48c263c 100644
> >> --- a/arch/arm/boot/dts/imx27.dtsi
> >> +++ b/arch/arm/boot/dts/imx27.dtsi
> >> @@ -208,6 +208,8 @@
> >>                               #gpio-cells = <2>;
> >>                               interrupt-controller;
> >>                               #interrupt-cells = <2>;
> >> +                             clocks = <&clks 47>;
> >> +                             clock-names = "ipg";
> >
> > Clock is not used in the gpio driver, so I doubt the usefulness of this patch.
> 
> I think you meant "this hunk", right?
> 
> My original patch did not have this part. It was added by Markus as
> mentioned in the commit log, and I agree we should go with the
> original version that did not add the gpio clock.

I somehow missed that your patch was applied in march. gpio clocks are
not mentioned in the binding documentation, so I drop this one
completely.

Thanks,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH 2/6] ARM: imx27: Use 'AITC' for the interrupt controller name

[Markus Pargmann]

From: Fabio Estevam <festevam@gmail.com>

On the MX27 Reference Manual the interrupt controller is named AITC:
ARM926EJ-S Interrupt Controller

So use the AITC term instead of AVIC.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Origin: id:1334193132-18944-2-git-send-email-festevam at gmail.com
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 48c263c..4f76453 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -30,8 +30,8 @@
 		spi2 = &cspi3;
 	};
 
-	avic: avic-interrupt-controller at e0000000 {
-		compatible = "fsl,imx27-avic", "fsl,avic";
+	aitc: aitc-interrupt-controller at e0000000 {
+		compatible = "fsl,imx27-aitc", "fsl,avic";
 		interrupt-controller;
 		#interrupt-cells = <1>;
 		reg = <0x10040000 0x1000>;
@@ -51,7 +51,7 @@
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "simple-bus";
-		interrupt-parent = <&avic>;
+		interrupt-parent = <&aitc>;
 		ranges;
 
 		aipi at 10000000 { /* AIPI1 */
-- 
1.8.2.1

[PATCH 3/6] ARM: dts: imx27: Add imx framebuffer device

[Markus Pargmann]

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 4f76453..044004a 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -354,6 +354,15 @@
 			reg = <0x10020000 0x20000>;
 			ranges;
 
+			imxfb: fb at 10021000 {
+				compatible = "fsl,imx27-fb", "fsl,imx21-fb";
+				interrupts = <61>;
+				reg = <0x10021000 0x1000>;
+				clocks = <&clks 36>, <&clks 65>, <&clks 59>;
+				clock-names = "ipg", "ahb", "per";
+				status = "disabled";
+			};
+
 			coda: coda at 10023000 {
 				compatible = "fsl,imx27-vpu";
 				reg = <0x10023000 0x0200>;
-- 
1.8.2.1

[PATCH 4/6] ARM: dts: imx27: Add 1-wire

[Markus Pargmann]

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 044004a..e883e77 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -110,6 +110,14 @@
 				clock-names = "ipg", "per";
 			};
 
+			owire: owire at 10009000 {
+				compatible = "fsl,imx21-owire";
+				reg = <0x10009000 0x1000>;
+				clocks = <&clks 35>;
+				clock-names = "ipg";
+				status = "disabled";
+			};
+
 			uart1: serial at 1000a000 {
 				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
 				reg = <0x1000a000 0x1000>;
-- 
1.8.2.1

Re: [PATCH 4/6] ARM: dts: imx27: Add 1-wire

[Alexander Shiyan]

> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx27.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 044004a..e883e77 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -110,6 +110,14 @@
>  				clock-names = "ipg", "per";
>  			};
>  
> +			owire: owire at 10009000 {
> +				compatible = "fsl,imx21-owire";

I think you should use "fsl,imx27-owire", "fsl,imx21-owire" here.

> +				reg = <0x10009000 0x1000>;
> +				clocks = <&clks 35>;
> +				clock-names = "ipg";
> +				status = "disabled";
> +			};
> +
>  			uart1: serial at 1000a000 {
>  				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
>  				reg = <0x1000a000 0x1000>;
> -- 


---

[PATCH 4/6] ARM: dts: imx27: Add 1-wire

[Markus Pargmann]

On Thu, Jun 20, 2013 at 07:17:34PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx27.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index 044004a..e883e77 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -110,6 +110,14 @@
> >  				clock-names = "ipg", "per";
> >  			};
> >  
> > +			owire: owire at 10009000 {
> > +				compatible = "fsl,imx21-owire";
> 
> I think you should use "fsl,imx27-owire", "fsl,imx21-owire" here.

Fixed, thank you

Markus

> 
> > +				reg = <0x10009000 0x1000>;
> > +				clocks = <&clks 35>;
> > +				clock-names = "ipg";
> > +				status = "disabled";
> > +			};
> > +
> >  			uart1: serial at 1000a000 {
> >  				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
> >  				reg = <0x1000a000 0x1000>;
> > -- 
> 
> 
> ---

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Markus Pargmann]

Set operating-points for imx27. There is no regulator support, so the
voltages are 0. The frequencies should be the same for all imx27 boards,
so it is defined here and can be overwritten if necessary.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index e883e77..3ebd98a 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -47,6 +47,25 @@
 		};
 	};
 
+	cpus {
+		#size-cells = <0>;
+		#address-cells = <1>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "fsl,imx27", "arm,arm926ejs";
+			reg = <0>;
+			operating-points = <
+				/* kHz  uV (No regulator support) */
+				133000  0
+				399000  0
+			>;
+			clock-latency = <61036>; /* two CLK32 periods */
+			clocks = <&clks 18>;
+			clock-names = "cpu";
+		};
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
1.8.2.1

[PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Shawn Guo]

On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote:
> Set operating-points for imx27. There is no regulator support, so the
> voltages are 0. The frequencies should be the same for all imx27 boards,
> so it is defined here and can be overwritten if necessary.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index e883e77..3ebd98a 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -47,6 +47,25 @@
>  		};
>  	};
>  
> +	cpus {
> +		#size-cells = <0>;
> +		#address-cells = <1>;
> +
> +		cpu at 0 {
> +			device_type = "cpu";
> +			compatible = "fsl,imx27", "arm,arm926ejs";

>From what Documentation/devicetree/bindings/arm/cpus.txt tells, it
should be "arm,arm926".  Also, why do you put "fsl,imx27" there?
"imx27" is a SoC name not cpu core.

Shawn

> +			reg = <0>;
> +			operating-points = <
> +				/* kHz  uV (No regulator support) */
> +				133000  0
> +				399000  0
> +			>;
> +			clock-latency = <61036>; /* two CLK32 periods */
> +			clocks = <&clks 18>;
> +			clock-names = "cpu";
> +		};
> +	};
> +
>  	soc {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -- 
> 1.8.2.1
> 

Re[2]: [PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Alexander Shiyan]

> On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote:
> > Set operating-points for imx27. There is no regulator support, so the
> > voltages are 0. The frequencies should be the same for all imx27 boards,
> > so it is defined here and can be overwritten if necessary.
> > 
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx27.dtsi | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index e883e77..3ebd98a 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -47,6 +47,25 @@
> >  		};
> >  	};
> >  
> > +	cpus {
> > +		#size-cells = <0>;
> > +		#address-cells = <1>;
> > +
> > +		cpu at 0 {
> > +			device_type = "cpu";
> > +			compatible = "fsl,imx27", "arm,arm926ejs";
> 
> From what Documentation/devicetree/bindings/arm/cpus.txt tells, it
> should be "arm,arm926".  Also, why do you put "fsl,imx27" there?
> "imx27" is a SoC name not cpu core.

I think Markus take this ARM property from one of existing DTS.

shc at shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi
at91sam9260.dtsi:                       compatible = "arm,arm926ejs";
at91sam9263.dtsi:                       compatible = "arm,arm926ejs";
at91sam9g45.dtsi:                       compatible = "arm,arm926ejs";
at91sam9n12.dtsi:                       compatible = "arm,arm926ejs";
at91sam9x5.dtsi:                        compatible = "arm,arm926ejs";
imx23.dtsi:                     compatible = "arm,arm926ejs";
imx28.dtsi:                     compatible = "arm,arm926ejs";
lpc32xx.dtsi:                   compatible = "arm,arm926ejs";
s3c2416.dtsi:                   compatible = "arm,arm926ejs";
spear3xx.dtsi:                  compatible = "arm,arm926ejs";
spear600.dtsi:                  compatible = "arm,arm926ejs";
wm8505.dtsi:                    compatible = "arm,arm926ejs";

So, documentation need to be updated or these values should be fixed.
Another solution  is specify compatible string as:
compatible = "arm,arm926ejs", "arm,arm926";
What you think about this?

---

[PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Shawn Guo]

On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote:
> > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote:
> > > +	cpus {
> > > +		#size-cells = <0>;
> > > +		#address-cells = <1>;
> > > +
> > > +		cpu at 0 {
> > > +			device_type = "cpu";
> > > +			compatible = "fsl,imx27", "arm,arm926ejs";
> > 
> > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it
> > should be "arm,arm926".  Also, why do you put "fsl,imx27" there?
> > "imx27" is a SoC name not cpu core.
> 
> I think Markus take this ARM property from one of existing DTS.
> 
> shc at shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi
> at91sam9260.dtsi:                       compatible = "arm,arm926ejs";
> at91sam9263.dtsi:                       compatible = "arm,arm926ejs";
> at91sam9g45.dtsi:                       compatible = "arm,arm926ejs";
> at91sam9n12.dtsi:                       compatible = "arm,arm926ejs";
> at91sam9x5.dtsi:                        compatible = "arm,arm926ejs";
> imx23.dtsi:                     compatible = "arm,arm926ejs";
> imx28.dtsi:                     compatible = "arm,arm926ejs";
> lpc32xx.dtsi:                   compatible = "arm,arm926ejs";
> s3c2416.dtsi:                   compatible = "arm,arm926ejs";
> spear3xx.dtsi:                  compatible = "arm,arm926ejs";
> spear600.dtsi:                  compatible = "arm,arm926ejs";
> wm8505.dtsi:                    compatible = "arm,arm926ejs";
> 
> So, documentation need to be updated or these values should be fixed.
> Another solution  is specify compatible string as:
> compatible = "arm,arm926ejs", "arm,arm926";
> What you think about this?

I assume that the compatible string in the binding doc has been reviewed
and agreed by people, so we should fix the existing users before kernel
starts using it to for matching something.

Lorenzo, comment?

Shawn

[PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Lorenzo Pieralisi]

On Fri, Jun 21, 2013 at 06:23:46AM +0100, Shawn Guo wrote:
> On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote:
> > > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote:
> > > > +	cpus {
> > > > +		#size-cells = <0>;
> > > > +		#address-cells = <1>;
> > > > +
> > > > +		cpu at 0 {
> > > > +			device_type = "cpu";
> > > > +			compatible = "fsl,imx27", "arm,arm926ejs";
> > > 
> > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it
> > > should be "arm,arm926".  Also, why do you put "fsl,imx27" there?
> > > "imx27" is a SoC name not cpu core.
> > 
> > I think Markus take this ARM property from one of existing DTS.
> > 
> > shc at shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi
> > at91sam9260.dtsi:                       compatible = "arm,arm926ejs";
> > at91sam9263.dtsi:                       compatible = "arm,arm926ejs";
> > at91sam9g45.dtsi:                       compatible = "arm,arm926ejs";
> > at91sam9n12.dtsi:                       compatible = "arm,arm926ejs";
> > at91sam9x5.dtsi:                        compatible = "arm,arm926ejs";
> > imx23.dtsi:                     compatible = "arm,arm926ejs";
> > imx28.dtsi:                     compatible = "arm,arm926ejs";
> > lpc32xx.dtsi:                   compatible = "arm,arm926ejs";
> > s3c2416.dtsi:                   compatible = "arm,arm926ejs";
> > spear3xx.dtsi:                  compatible = "arm,arm926ejs";
> > spear600.dtsi:                  compatible = "arm,arm926ejs";
> > wm8505.dtsi:                    compatible = "arm,arm926ejs";
> > 
> > So, documentation need to be updated or these values should be fixed.
> > Another solution  is specify compatible string as:
> > compatible = "arm,arm926ejs", "arm,arm926";
> > What you think about this?
> 
> I assume that the compatible string in the binding doc has been reviewed
> and agreed by people, so we should fix the existing users before kernel
> starts using it to for matching something.
> 
> Lorenzo, comment?

I patched them all and changes are queued through arm-soc, according to the
latest bindings that should get merged this cycle and are available here:

git://linux-arm.org/linux-2.6-lp.git dt-cpus-bindings

If you are queuing dts updates please follow rules in there, waiting for
that document to get merged.

Lorenzo

[PATCH 5/6] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Markus Pargmann]

On Fri, Jun 21, 2013 at 09:47:40AM +0100, Lorenzo Pieralisi wrote:
> On Fri, Jun 21, 2013 at 06:23:46AM +0100, Shawn Guo wrote:
> > On Fri, Jun 21, 2013 at 08:54:53AM +0400, Alexander Shiyan wrote:
> > > > On Thu, Jun 20, 2013 at 04:50:14PM +0200, Markus Pargmann wrote:
> > > > > +	cpus {
> > > > > +		#size-cells = <0>;
> > > > > +		#address-cells = <1>;
> > > > > +
> > > > > +		cpu at 0 {
> > > > > +			device_type = "cpu";
> > > > > +			compatible = "fsl,imx27", "arm,arm926ejs";
> > > > 
> > > > From what Documentation/devicetree/bindings/arm/cpus.txt tells, it
> > > > should be "arm,arm926".  Also, why do you put "fsl,imx27" there?
> > > > "imx27" is a SoC name not cpu core.
> > > 
> > > I think Markus take this ARM property from one of existing DTS.
> > > 
> > > shc at shc /home/git/linux-mx27/arch/arm/boot/dts $ grep arm926 *.dtsi
> > > at91sam9260.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9263.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9g45.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9n12.dtsi:                       compatible = "arm,arm926ejs";
> > > at91sam9x5.dtsi:                        compatible = "arm,arm926ejs";
> > > imx23.dtsi:                     compatible = "arm,arm926ejs";
> > > imx28.dtsi:                     compatible = "arm,arm926ejs";
> > > lpc32xx.dtsi:                   compatible = "arm,arm926ejs";
> > > s3c2416.dtsi:                   compatible = "arm,arm926ejs";
> > > spear3xx.dtsi:                  compatible = "arm,arm926ejs";
> > > spear600.dtsi:                  compatible = "arm,arm926ejs";
> > > wm8505.dtsi:                    compatible = "arm,arm926ejs";
> > > 
> > > So, documentation need to be updated or these values should be fixed.
> > > Another solution  is specify compatible string as:
> > > compatible = "arm,arm926ejs", "arm,arm926";
> > > What you think about this?
> > 
> > I assume that the compatible string in the binding doc has been reviewed
> > and agreed by people, so we should fix the existing users before kernel
> > starts using it to for matching something.
> > 
> > Lorenzo, comment?
> 
> I patched them all and changes are queued through arm-soc, according to the
> latest bindings that should get merged this cycle and are available here:
> 
> git://linux-arm.org/linux-2.6-lp.git dt-cpus-bindings
> 
> If you are queuing dts updates please follow rules in there, waiting for
> that document to get merged.
> 
> Lorenzo
> 

Okay, I changed it to "arm,arm926ej-s" and removed "reg" as described in
the dt-cpus-bindings branch documentation.

Thanks,

Markus

> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH 6/6] ARM: dts: Add device tree support for phycard pca100

[Markus Pargmann]

Based on patches from:

Steffen Trumtrar <s.trumtrar@pengutronix.de>:
 - Original patch
 - ARM: dts: Set partition offsets for phycard
 - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
 - ARM: imx27-phytec-phycard-S.dts: resize nand partitions

Jan Luebbe <jlu@pengutronix.de>:
 - ARM: dts: Enable bad block table in NAND

Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/imx27-phytec-phycard-S.dts | 195 +++++++++++++++++++++++++++
 arch/arm/mach-imx/Kconfig                    |   1 +
 3 files changed, 197 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-S.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b3a8661..e8fb0bc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx27-pdk.dtb \
 	imx27-phytec-phycore-som.dtb \
 	imx27-phytec-phycore-rdk.dtb \
+	imx27-phytec-phycard-S.dtb \
 	imx31-bug.dtb \
 	imx51-apf51.dtb \
 	imx51-apf51dev.dtb \
diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-S.dts b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
new file mode 100644
index 0000000..dc3a93b
--- /dev/null
+++ b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
@@ -0,0 +1,195 @@
+/*
+ * Copyright 2012 Sascha Hauer, Uwe Kleine-K?nig and Steffen Trumtrar, Pengutronix
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx27.dtsi"
+
+/ {
+	model = "Phytec pca100";
+	compatible = "phytec,imx27-pca100", "fsl,imx27";
+
+	memory {
+		device_type = "memory";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		reg = <0x0 0x08000000>;   // 128MB
+	};
+
+	soc {
+		aipi at 10000000 { /* aipi */
+			wdog at 10002000 {
+				status = "okay";
+			};
+
+			owire at 10009000 {
+				status = "okay";
+			};
+
+			serial at 1000a000 {
+				fsl,uart-has-rtscts;
+				status = "okay";
+			};
+
+			serial at 1000b000 {
+				fsl,uart-has-rtscts;
+				status = "okay";
+			};
+
+			serial at 1000c000 {
+				fsl,uart-has-rtscts;
+				status = "okay";
+			};
+
+			cspi at 1000e000 {
+				fsl,spi-num-chipselects = <2>;
+				cs-gpios = <&gpio4 28 0>,
+					<&gpio4 27 0>;
+				status = "okay";
+			};
+
+			i2c at 10012000 {
+				status = "okay";
+				ioexpander at 41 {
+					compatible = "nxp,pca9536";
+					reg = <0x41>;
+				};
+				rtc at 51 {
+					compatible = "nxp,pcf8563";
+					reg = <0x51>;
+				};
+				dimmer at 60 {
+					compatible = "nxp,pca9530";
+					reg = <0x60>;
+					pwm = <1 1>;
+					psc = <1 1>;
+					leds = <&led0 &led1>;
+					led0: led0 {
+						label = "pba-lcd_brightness";
+						default-state = "off";
+						type = "led";
+					};
+					led1: led1 {
+						label = "pba-free_use";
+						default-state = "off";
+						type = "led";
+					};
+				};
+			};
+
+			sdhci at 10014000 {
+				cd-gpios = <&gpio3 29 0>;
+				status = "okay";
+			};
+
+			gpio at 10015000 {
+				status = "okay";
+			};
+
+			gpio at 10015100 {
+				status = "okay";
+			};
+
+			gpio at 10015200 {
+				status = "okay";
+			};
+
+			gpio at 10015300 {
+				status = "okay";
+			};
+
+			gpio at 10015400 {
+				status = "okay";
+			};
+
+			gpio at 10015500 {
+				status = "okay";
+			};
+
+			i2c at 1001d000 {
+				status = "okay";
+
+				lm75 at 4a {
+					compatible = "national,lm75";
+					reg = <0x4a>;
+				};
+
+				rtc at 51 {
+					compatible = "nxp,pcf8563";
+					reg = <0x51>;
+				};
+
+				at24 at 52 {
+					compatible = "at,24c32";
+					pagesize = <32>;
+					reg = <0x52>;
+				};
+			};
+		};
+
+		aipi at 10020000 { /* AIPI2 */
+			fb at 10021000 {
+				status = "okay";
+				display = <&display0>;
+			};
+
+			ethernet at 1002b000 {
+				status = "okay";
+			};
+		}; /* AIPI */
+
+		nand at d8000000 {
+			status = "okay";
+			nand-bus-width = <8>;
+			nand-ecc-mode = "hw";
+			nand-on-flash-bbt;
+
+			barebox at 0 {
+				label = "barebox";
+				reg = <0x0 0x80000>;
+			};
+
+			bareboxenv at 80000 {
+				label = "bareboxenv";
+				reg = <0x80000 0x80000>;
+			};
+
+			kernel at 100000 {
+				label = "kernel";
+				reg = <0x100000 0x500000>;
+			};
+
+			rootfs at 500000 {
+				label = "rootfs";
+				reg = <0x500000 0x7b00000>;
+			};
+		};
+	};
+
+	display0: display0 {
+		model = "Primeview-PD050VL1";
+		native-mode = <&timing_disp0>;
+		bits-per-pixel = <16>;		/* non-standard but required */
+		fsl,pcr = <0xf0c88080>;	/* non-standard but required */
+		display-timings {
+			timing_disp0: 640x480 {
+				hactive = <640>;
+				vactive = <480>;
+				hback-porch = <112>;
+				hfront-porch = <36>;
+				hsync-len = <32>;
+				vback-porch = <33>;
+				vfront-porch = <33>;
+				vsync-len = <2>;
+				clock-frequency = <25000000>;
+			};
+		};
+	};
+};
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index f25cf88..5372337 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -441,6 +441,7 @@ config MACH_IMX27IPCAM
 config MACH_IMX27_DT
 	bool "Support i.MX27 platforms from device tree"
 	select SOC_IMX27
+	select IMX_HAVE_PLATFORM_MXC_NAND
 	help
 	  Include support for Freescale i.MX27 based platforms
 	  using the device tree for discovery
-- 
1.8.2.1

[PATCH 6/6] ARM: dts: Add device tree support for phycard pca100

[Markus Pargmann]

On Thu, Jun 20, 2013 at 04:50:15PM +0200, Markus Pargmann wrote:
> Based on patches from:
> 
> Steffen Trumtrar <s.trumtrar@pengutronix.de>:
>  - Original patch
>  - ARM: dts: Set partition offsets for phycard
>  - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
>  - ARM: imx27-phytec-phycard-S.dts: resize nand partitions
> 
> Jan Luebbe <jlu@pengutronix.de>:
>  - ARM: dts: Enable bad block table in NAND
> 
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Jan Luebbe <jlu@pengutronix.de>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/Makefile                   |   1 +
>  arch/arm/boot/dts/imx27-phytec-phycard-S.dts | 195 +++++++++++++++++++++++++++
>  arch/arm/mach-imx/Kconfig                    |   1 +
>  3 files changed, 197 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b3a8661..e8fb0bc 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>  	imx27-pdk.dtb \
>  	imx27-phytec-phycore-som.dtb \
>  	imx27-phytec-phycore-rdk.dtb \
> +	imx27-phytec-phycard-S.dtb \
>  	imx31-bug.dtb \
>  	imx51-apf51.dtb \
>  	imx51-apf51dev.dtb \
> diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-S.dts b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> new file mode 100644
> index 0000000..dc3a93b
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> @@ -0,0 +1,195 @@
> +/*
> + * Copyright 2012 Sascha Hauer, Uwe Kleine-K?nig and Steffen Trumtrar, Pengutronix
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +#include "imx27.dtsi"
> +
> +/ {
> +	model = "Phytec pca100";
> +	compatible = "phytec,imx27-pca100", "fsl,imx27";
> +
> +	memory {
> +		device_type = "memory";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		reg = <0x0 0x08000000>;   // 128MB
> +	};
> +
> +	soc {
> +		aipi at 10000000 { /* aipi */
> +			wdog at 10002000 {
> +				status = "okay";
> +			};
> +
> +			owire at 10009000 {
> +				status = "okay";
> +			};
> +
> +			serial at 1000a000 {
> +				fsl,uart-has-rtscts;
> +				status = "okay";
> +			};
> +
> +			serial at 1000b000 {
> +				fsl,uart-has-rtscts;
> +				status = "okay";
> +			};
> +
> +			serial at 1000c000 {
> +				fsl,uart-has-rtscts;
> +				status = "okay";
> +			};
> +
> +			cspi at 1000e000 {
> +				fsl,spi-num-chipselects = <2>;
> +				cs-gpios = <&gpio4 28 0>,
> +					<&gpio4 27 0>;
> +				status = "okay";
> +			};
> +
> +			i2c at 10012000 {
> +				status = "okay";
> +				ioexpander at 41 {
> +					compatible = "nxp,pca9536";
> +					reg = <0x41>;
> +				};
> +				rtc at 51 {
> +					compatible = "nxp,pcf8563";
> +					reg = <0x51>;
> +				};
> +				dimmer at 60 {
> +					compatible = "nxp,pca9530";
> +					reg = <0x60>;
> +					pwm = <1 1>;
> +					psc = <1 1>;
> +					leds = <&led0 &led1>;
> +					led0: led0 {
> +						label = "pba-lcd_brightness";
> +						default-state = "off";
> +						type = "led";
> +					};
> +					led1: led1 {
> +						label = "pba-free_use";
> +						default-state = "off";
> +						type = "led";
> +					};
> +				};
> +			};
> +
> +			sdhci at 10014000 {
> +				cd-gpios = <&gpio3 29 0>;
> +				status = "okay";
> +			};
> +
> +			gpio at 10015000 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015100 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015200 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015300 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015400 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015500 {
> +				status = "okay";
> +			};
> +
> +			i2c at 1001d000 {
> +				status = "okay";
> +
> +				lm75 at 4a {
> +					compatible = "national,lm75";
> +					reg = <0x4a>;
> +				};
> +
> +				rtc at 51 {
> +					compatible = "nxp,pcf8563";
> +					reg = <0x51>;
> +				};
> +
> +				at24 at 52 {
> +					compatible = "at,24c32";
> +					pagesize = <32>;
> +					reg = <0x52>;
> +				};
> +			};
> +		};
> +
> +		aipi at 10020000 { /* AIPI2 */
> +			fb at 10021000 {
> +				status = "okay";
> +				display = <&display0>;
> +			};
> +
> +			ethernet at 1002b000 {
> +				status = "okay";
> +			};
> +		}; /* AIPI */
> +
> +		nand at d8000000 {
> +			status = "okay";
> +			nand-bus-width = <8>;
> +			nand-ecc-mode = "hw";
> +			nand-on-flash-bbt;
> +
> +			barebox at 0 {
> +				label = "barebox";
> +				reg = <0x0 0x80000>;
> +			};
> +
> +			bareboxenv at 80000 {
> +				label = "bareboxenv";
> +				reg = <0x80000 0x80000>;
> +			};
> +
> +			kernel at 100000 {
> +				label = "kernel";
> +				reg = <0x100000 0x500000>;
> +			};
> +
> +			rootfs at 500000 {
> +				label = "rootfs";
> +				reg = <0x500000 0x7b00000>;
> +			};
> +		};
> +	};
> +
> +	display0: display0 {
> +		model = "Primeview-PD050VL1";
> +		native-mode = <&timing_disp0>;
> +		bits-per-pixel = <16>;		/* non-standard but required */
> +		fsl,pcr = <0xf0c88080>;	/* non-standard but required */
> +		display-timings {
> +			timing_disp0: 640x480 {
> +				hactive = <640>;
> +				vactive = <480>;
> +				hback-porch = <112>;
> +				hfront-porch = <36>;
> +				hsync-len = <32>;
> +				vback-porch = <33>;
> +				vfront-porch = <33>;
> +				vsync-len = <2>;
> +				clock-frequency = <25000000>;
> +			};
> +		};
> +	};
> +};
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index f25cf88..5372337 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -441,6 +441,7 @@ config MACH_IMX27IPCAM
>  config MACH_IMX27_DT
>  	bool "Support i.MX27 platforms from device tree"
>  	select SOC_IMX27
> +	select IMX_HAVE_PLATFORM_MXC_NAND

This select is not necessary. I will send a new version at the weekend.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH 6/6] ARM: dts: Add device tree support for phycard pca100

[Alexander Shiyan]

> Based on patches from:
> 
> Steffen Trumtrar <s.trumtrar@pengutronix.de>:
>  - Original patch
>  - ARM: dts: Set partition offsets for phycard
>  - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
>  - ARM: imx27-phytec-phycard-S.dts: resize nand partitions
> 
> Jan Luebbe <jlu@pengutronix.de>:
>  - ARM: dts: Enable bad block table in NAND
> 
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Jan Luebbe <jlu@pengutronix.de>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
...
> +			gpio at 10015000 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015100 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015200 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015300 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015400 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015500 {
> +				status = "okay";
> +			};

No need setup status for devices which not disabled in imx27.dts

---

[PATCH 6/6] ARM: dts: Add device tree support for phycard pca100

[Markus Pargmann]

On Thu, Jun 20, 2013 at 07:21:10PM +0400, Alexander Shiyan wrote:
> > Based on patches from:
> > 
> > Steffen Trumtrar <s.trumtrar@pengutronix.de>:
> >  - Original patch
> >  - ARM: dts: Set partition offsets for phycard
> >  - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
> >  - ARM: imx27-phytec-phycard-S.dts: resize nand partitions
> > 
> > Jan Luebbe <jlu@pengutronix.de>:
> >  - ARM: dts: Enable bad block table in NAND
> > 
> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > Cc: Jan Luebbe <jlu@pengutronix.de>
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ...
> > +			gpio at 10015000 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015100 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015200 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015300 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015400 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015500 {
> > +				status = "okay";
> > +			};
> 
> No need setup status for devices which not disabled in imx27.dts

Thanks, I removed all unnecessary nodes, gpio and wdog.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH 6/6] ARM: dts: Add device tree support for phycard pca100

[Shawn Guo]

On Thu, Jun 20, 2013 at 04:50:15PM +0200, Markus Pargmann wrote:
> Based on patches from:
> 
> Steffen Trumtrar <s.trumtrar@pengutronix.de>:
>  - Original patch
>  - ARM: dts: Set partition offsets for phycard
>  - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
>  - ARM: imx27-phytec-phycard-S.dts: resize nand partitions
> 
> Jan Luebbe <jlu@pengutronix.de>:
>  - ARM: dts: Enable bad block table in NAND
> 
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Jan Luebbe <jlu@pengutronix.de>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/Makefile                   |   1 +
>  arch/arm/boot/dts/imx27-phytec-phycard-S.dts | 195 +++++++++++++++++++++++++++
>  arch/arm/mach-imx/Kconfig                    |   1 +
>  3 files changed, 197 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b3a8661..e8fb0bc 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
>  	imx27-pdk.dtb \
>  	imx27-phytec-phycore-som.dtb \
>  	imx27-phytec-phycore-rdk.dtb \
> +	imx27-phytec-phycard-S.dtb \
>  	imx31-bug.dtb \
>  	imx51-apf51.dtb \
>  	imx51-apf51dev.dtb \
> diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-S.dts b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> new file mode 100644
> index 0000000..dc3a93b
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> @@ -0,0 +1,195 @@
> +/*
> + * Copyright 2012 Sascha Hauer, Uwe Kleine-K?nig and Steffen Trumtrar, Pengutronix
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +#include "imx27.dtsi"
> +
> +/ {
> +	model = "Phytec pca100";
> +	compatible = "phytec,imx27-pca100", "fsl,imx27";
> +
> +	memory {
> +		device_type = "memory";

It's been covered by skeleton.dtsi.

> +		#address-cells = <1>;
> +		#size-cells = <1>;

They are only needed if there are child nodes with "reg" property.

> +		reg = <0x0 0x08000000>;   // 128MB
> +	};
> +
> +	soc {
> +		aipi at 10000000 { /* aipi */
> +			wdog at 10002000 {
> +				status = "okay";
> +			};

We now use node label in board dts files to refer to the nodes defined
in soc dts.

> +
> +			owire at 10009000 {
> +				status = "okay";
> +			};
> +
> +			serial at 1000a000 {
> +				fsl,uart-has-rtscts;
> +				status = "okay";
> +			};
> +
> +			serial at 1000b000 {
> +				fsl,uart-has-rtscts;
> +				status = "okay";
> +			};
> +
> +			serial at 1000c000 {
> +				fsl,uart-has-rtscts;
> +				status = "okay";
> +			};
> +
> +			cspi at 1000e000 {
> +				fsl,spi-num-chipselects = <2>;
> +				cs-gpios = <&gpio4 28 0>,
> +					<&gpio4 27 0>;
> +				status = "okay";
> +			};
> +
> +			i2c at 10012000 {
> +				status = "okay";
> +				ioexpander at 41 {
> +					compatible = "nxp,pca9536";
> +					reg = <0x41>;
> +				};

Please put blank line before and after node.

> +				rtc at 51 {
> +					compatible = "nxp,pcf8563";
> +					reg = <0x51>;
> +				};
> +				dimmer at 60 {
> +					compatible = "nxp,pca9530";
> +					reg = <0x60>;

> +					pwm = <1 1>;
> +					psc = <1 1>;
> +					leds = <&led0 &led1>;

Are these documented/accepted bindings?

> +					led0: led0 {
> +						label = "pba-lcd_brightness";
> +						default-state = "off";
> +						type = "led";

What is this "type" property used for?  Is it documented?

> +					};
> +					led1: led1 {
> +						label = "pba-free_use";
> +						default-state = "off";
> +						type = "led";
> +					};
> +				};
> +			};
> +
> +			sdhci at 10014000 {
> +				cd-gpios = <&gpio3 29 0>;
> +				status = "okay";
> +			};
> +
> +			gpio at 10015000 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015100 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015200 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015300 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015400 {
> +				status = "okay";
> +			};
> +
> +			gpio at 10015500 {
> +				status = "okay";
> +			};
> +
> +			i2c at 1001d000 {
> +				status = "okay";
> +
> +				lm75 at 4a {
> +					compatible = "national,lm75";
> +					reg = <0x4a>;
> +				};
> +
> +				rtc at 51 {
> +					compatible = "nxp,pcf8563";
> +					reg = <0x51>;
> +				};
> +
> +				at24 at 52 {
> +					compatible = "at,24c32";
> +					pagesize = <32>;
> +					reg = <0x52>;
> +				};
> +			};
> +		};
> +
> +		aipi at 10020000 { /* AIPI2 */
> +			fb at 10021000 {
> +				status = "okay";

Please let it be the last property in the node.

> +				display = <&display0>;
> +			};
> +
> +			ethernet at 1002b000 {
> +				status = "okay";
> +			};
> +		}; /* AIPI */
> +
> +		nand at d8000000 {
> +			status = "okay";

Ditto

> +			nand-bus-width = <8>;
> +			nand-ecc-mode = "hw";
> +			nand-on-flash-bbt;
> +
> +			barebox at 0 {
> +				label = "barebox";
> +				reg = <0x0 0x80000>;
> +			};
> +
> +			bareboxenv at 80000 {
> +				label = "bareboxenv";
> +				reg = <0x80000 0x80000>;
> +			};
> +
> +			kernel at 100000 {
> +				label = "kernel";
> +				reg = <0x100000 0x500000>;
> +			};
> +
> +			rootfs at 500000 {
> +				label = "rootfs";
> +				reg = <0x500000 0x7b00000>;
> +			};

People are against the idea of putting partition layout in device tree.

> +		};
> +	};
> +
> +	display0: display0 {
> +		model = "Primeview-PD050VL1";
> +		native-mode = <&timing_disp0>;
> +		bits-per-pixel = <16>;		/* non-standard but required */
> +		fsl,pcr = <0xf0c88080>;	/* non-standard but required */

Has the code/document for these non-standard properties been accepted?

Shawn

> +		display-timings {
> +			timing_disp0: 640x480 {
> +				hactive = <640>;
> +				vactive = <480>;
> +				hback-porch = <112>;
> +				hfront-porch = <36>;
> +				hsync-len = <32>;
> +				vback-porch = <33>;
> +				vfront-porch = <33>;
> +				vsync-len = <2>;
> +				clock-frequency = <25000000>;
> +			};
> +		};
> +	};
> +};
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index f25cf88..5372337 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -441,6 +441,7 @@ config MACH_IMX27IPCAM
>  config MACH_IMX27_DT
>  	bool "Support i.MX27 platforms from device tree"
>  	select SOC_IMX27
> +	select IMX_HAVE_PLATFORM_MXC_NAND
>  	help
>  	  Include support for Freescale i.MX27 based platforms
>  	  using the device tree for discovery
> -- 
> 1.8.2.1
> 

[PATCH 6/6] ARM: dts: Add device tree support for phycard pca100

[Markus Pargmann]

On Fri, Jun 21, 2013 at 11:46:05AM +0800, Shawn Guo wrote:
> On Thu, Jun 20, 2013 at 04:50:15PM +0200, Markus Pargmann wrote:
> > Based on patches from:
> > 
> > Steffen Trumtrar <s.trumtrar@pengutronix.de>:
> >  - Original patch
> >  - ARM: dts: Set partition offsets for phycard
> >  - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
> >  - ARM: imx27-phytec-phycard-S.dts: resize nand partitions
> > 
> > Jan Luebbe <jlu@pengutronix.de>:
> >  - ARM: dts: Enable bad block table in NAND
> > 
> > Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > Cc: Jan Luebbe <jlu@pengutronix.de>
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/Makefile                   |   1 +
> >  arch/arm/boot/dts/imx27-phytec-phycard-S.dts | 195 +++++++++++++++++++++++++++
> >  arch/arm/mach-imx/Kconfig                    |   1 +
> >  3 files changed, 197 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index b3a8661..e8fb0bc 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -105,6 +105,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
> >  	imx27-pdk.dtb \
> >  	imx27-phytec-phycore-som.dtb \
> >  	imx27-phytec-phycore-rdk.dtb \
> > +	imx27-phytec-phycard-S.dtb \
> >  	imx31-bug.dtb \
> >  	imx51-apf51.dtb \
> >  	imx51-apf51dev.dtb \
> > diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-S.dts b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> > new file mode 100644
> > index 0000000..dc3a93b
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx27-phytec-phycard-S.dts
> > @@ -0,0 +1,195 @@
> > +/*
> > + * Copyright 2012 Sascha Hauer, Uwe Kleine-K?nig and Steffen Trumtrar, Pengutronix
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 or later at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx27.dtsi"
> > +
> > +/ {
> > +	model = "Phytec pca100";
> > +	compatible = "phytec,imx27-pca100", "fsl,imx27";
> > +
> > +	memory {
> > +		device_type = "memory";
> 
> It's been covered by skeleton.dtsi.
> 
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> 
> They are only needed if there are child nodes with "reg" property.

Removed

> 
> > +		reg = <0x0 0x08000000>;   // 128MB
> > +	};
> > +
> > +	soc {
> > +		aipi at 10000000 { /* aipi */
> > +			wdog at 10002000 {
> > +				status = "okay";
> > +			};
> 
> We now use node label in board dts files to refer to the nodes defined
> in soc dts.

I replaced all node identifiers with their labels.

> 
> > +
> > +			owire at 10009000 {
> > +				status = "okay";
> > +			};
> > +
> > +			serial at 1000a000 {
> > +				fsl,uart-has-rtscts;
> > +				status = "okay";
> > +			};
> > +
> > +			serial at 1000b000 {
> > +				fsl,uart-has-rtscts;
> > +				status = "okay";
> > +			};
> > +
> > +			serial at 1000c000 {
> > +				fsl,uart-has-rtscts;
> > +				status = "okay";
> > +			};
> > +
> > +			cspi at 1000e000 {
> > +				fsl,spi-num-chipselects = <2>;
> > +				cs-gpios = <&gpio4 28 0>,
> > +					<&gpio4 27 0>;
> > +				status = "okay";
> > +			};
> > +
> > +			i2c at 10012000 {
> > +				status = "okay";
> > +				ioexpander at 41 {
> > +					compatible = "nxp,pca9536";
> > +					reg = <0x41>;
> > +				};
> 
> Please put blank line before and after node.

Fixed

> 
> > +				rtc at 51 {
> > +					compatible = "nxp,pcf8563";
> > +					reg = <0x51>;
> > +				};
> > +				dimmer at 60 {
> > +					compatible = "nxp,pca9530";
> > +					reg = <0x60>;
> 
> > +					pwm = <1 1>;
> > +					psc = <1 1>;
> > +					leds = <&led0 &led1>;
> 
> Are these documented/accepted bindings?

No, sorry, I forgot to remove them.

> 
> > +					led0: led0 {
> > +						label = "pba-lcd_brightness";
> > +						default-state = "off";
> > +						type = "led";
> 
> What is this "type" property used for?  Is it documented?
> 
> > +					};
> > +					led1: led1 {
> > +						label = "pba-free_use";
> > +						default-state = "off";
> > +						type = "led";
> > +					};
> > +				};
> > +			};
> > +
> > +			sdhci at 10014000 {
> > +				cd-gpios = <&gpio3 29 0>;
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015000 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015100 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015200 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015300 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015400 {
> > +				status = "okay";
> > +			};
> > +
> > +			gpio at 10015500 {
> > +				status = "okay";
> > +			};
> > +
> > +			i2c at 1001d000 {
> > +				status = "okay";
> > +
> > +				lm75 at 4a {
> > +					compatible = "national,lm75";
> > +					reg = <0x4a>;
> > +				};
> > +
> > +				rtc at 51 {
> > +					compatible = "nxp,pcf8563";
> > +					reg = <0x51>;
> > +				};
> > +
> > +				at24 at 52 {
> > +					compatible = "at,24c32";
> > +					pagesize = <32>;
> > +					reg = <0x52>;
> > +				};
> > +			};
> > +		};
> > +
> > +		aipi at 10020000 { /* AIPI2 */
> > +			fb at 10021000 {
> > +				status = "okay";
> 
> Please let it be the last property in the node.

Fixed.

> 
> > +				display = <&display0>;
> > +			};
> > +
> > +			ethernet at 1002b000 {
> > +				status = "okay";
> > +			};
> > +		}; /* AIPI */
> > +
> > +		nand at d8000000 {
> > +			status = "okay";
> 
> Ditto
> 
> > +			nand-bus-width = <8>;
> > +			nand-ecc-mode = "hw";
> > +			nand-on-flash-bbt;
> > +
> > +			barebox at 0 {
> > +				label = "barebox";
> > +				reg = <0x0 0x80000>;
> > +			};
> > +
> > +			bareboxenv at 80000 {
> > +				label = "bareboxenv";
> > +				reg = <0x80000 0x80000>;
> > +			};
> > +
> > +			kernel at 100000 {
> > +				label = "kernel";
> > +				reg = <0x100000 0x500000>;
> > +			};
> > +
> > +			rootfs at 500000 {
> > +				label = "rootfs";
> > +				reg = <0x500000 0x7b00000>;
> > +			};
> 
> People are against the idea of putting partition layout in device tree.

Removed.

> 
> > +		};
> > +	};
> > +
> > +	display0: display0 {
> > +		model = "Primeview-PD050VL1";
> > +		native-mode = <&timing_disp0>;
> > +		bits-per-pixel = <16>;		/* non-standard but required */
> > +		fsl,pcr = <0xf0c88080>;	/* non-standard but required */
> 
> Has the code/document for these non-standard properties been accepted?

Yes, it was accepted:
https://patchwork.kernel.org/patch/2614951/

Thank you,

Markus

> 
> Shawn
> 
> > +		display-timings {
> > +			timing_disp0: 640x480 {
> > +				hactive = <640>;
> > +				vactive = <480>;
> > +				hback-porch = <112>;
> > +				hfront-porch = <36>;
> > +				hsync-len = <32>;
> > +				vback-porch = <33>;
> > +				vfront-porch = <33>;
> > +				vsync-len = <2>;
> > +				clock-frequency = <25000000>;
> > +			};
> > +		};
> > +	};
> > +};
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index f25cf88..5372337 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -441,6 +441,7 @@ config MACH_IMX27IPCAM
> >  config MACH_IMX27_DT
> >  	bool "Support i.MX27 platforms from device tree"
> >  	select SOC_IMX27
> > +	select IMX_HAVE_PLATFORM_MXC_NAND
> >  	help
> >  	  Include support for Freescale i.MX27 based platforms
> >  	  using the device tree for discovery
> > -- 
> > 1.8.2.1
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |