* [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt
@ 2013-06-21 22:39 Stephen Warren
2013-06-24 2:40 ` Joseph Lo
2013-06-25 18:17 ` Olof Johansson
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Warren @ 2013-06-21 22:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Stephen Warren <swarren@nvidia.com>
tegra_pmc_parse_dt() references __initconst data. Fix it to be __init.
This matches its only usage; a call from tegra_pmc_init() which is
already __init. This fixes:
WARNING: vmlinux.o(.text.unlikely+0x580): Section mismatch in reference
from the function tegra_pmc_parse_dt() to the (unknown reference)
.init.rodata:(unknown)
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/mach-tegra/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
index 32360e5..eb3fa4a 100644
--- a/arch/arm/mach-tegra/pmc.c
+++ b/arch/arm/mach-tegra/pmc.c
@@ -234,7 +234,7 @@ static const struct of_device_id matches[] __initconst = {
{ }
};
-static void tegra_pmc_parse_dt(void)
+static void __init tegra_pmc_parse_dt(void)
{
struct device_node *np;
u32 prop;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt
2013-06-21 22:39 [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt Stephen Warren
@ 2013-06-24 2:40 ` Joseph Lo
2013-06-24 15:19 ` Stephen Warren
2013-06-25 18:17 ` Olof Johansson
1 sibling, 1 reply; 4+ messages in thread
From: Joseph Lo @ 2013-06-24 2:40 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, 2013-06-22 at 06:39 +0800, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> tegra_pmc_parse_dt() references __initconst data. Fix it to be __init.
> This matches its only usage; a call from tegra_pmc_init() which is
> already __init. This fixes:
>
> WARNING: vmlinux.o(.text.unlikely+0x580): Section mismatch in reference
> from the function tegra_pmc_parse_dt() to the (unknown reference)
> .init.rodata:(unknown)
>
Hi Stephen,
Just curious, I don't see this warning message on my system. Does this
cause by some other patch or something else?
Thanks,
Joseph
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt
2013-06-24 2:40 ` Joseph Lo
@ 2013-06-24 15:19 ` Stephen Warren
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2013-06-24 15:19 UTC (permalink / raw)
To: linux-arm-kernel
On 06/23/2013 08:40 PM, Joseph Lo wrote:
> On Sat, 2013-06-22 at 06:39 +0800, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> tegra_pmc_parse_dt() references __initconst data. Fix it to be __init.
>> This matches its only usage; a call from tegra_pmc_init() which is
>> already __init. This fixes:
>>
>> WARNING: vmlinux.o(.text.unlikely+0x580): Section mismatch in reference
>> from the function tegra_pmc_parse_dt() to the (unknown reference)
>> .init.rodata:(unknown)
>>
> Hi Stephen,
>
> Just curious, I don't see this warning message on my system. Does this
> cause by some other patch or something else?
The warning only shows up with CONFIG_DEBUG_SECTION_MISMATCH=y, which
isn't in tegra_defconfig.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt
2013-06-21 22:39 [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt Stephen Warren
2013-06-24 2:40 ` Joseph Lo
@ 2013-06-25 18:17 ` Olof Johansson
1 sibling, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2013-06-25 18:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jun 21, 2013 at 04:39:07PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> tegra_pmc_parse_dt() references __initconst data. Fix it to be __init.
> This matches its only usage; a call from tegra_pmc_init() which is
> already __init. This fixes:
>
> WARNING: vmlinux.o(.text.unlikely+0x580): Section mismatch in reference
> from the function tegra_pmc_parse_dt() to the (unknown reference)
> .init.rodata:(unknown)
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
Applied to fixes-non-critical.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-25 18:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-21 22:39 [PATCH] ARM: tegra: fix section mismatch in tegra_pmc_parse_dt Stephen Warren
2013-06-24 2:40 ` Joseph Lo
2013-06-24 15:19 ` Stephen Warren
2013-06-25 18:17 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).