[PATCH v3 0/5] ARM: dts: imx27 Phytec phyCARD-S

[PATCH v3 0/5] ARM: dts: imx27 Phytec phyCARD-S

[Markus Pargmann]

Hi,

This series adds some device nodes for imx27 and board files for Phytec
phyCARD-S SOM and RDK. It is based on shawn's branch "imx/dt".

Regards,

Markus

Changes in v3:
 - Removed unnecessary clock-names from owire node
 - Update memory offset

Changes in v2:
 - Removed already accepted clocks patch
   "ARM: mx27: Replace clk_register_clkdev with clock DT lookup"
 - pca100 board file was splitted into two parts SOM and RDK
 - other changes described in patch notes

Fabio Estevam (1):
      ARM: imx27: Use 'AITC' for the interrupt controller name

Markus Pargmann (4):
      ARM: dts: imx27: Add imx framebuffer device
      ARM: dts: imx27: Add 1-wire
      ARM: dts: imx27 cpufreq-cpu0 frequencies
      ARM: dts: Add device tree support for phycard pca100

 arch/arm/boot/dts/Makefile                       |  2 +
 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 62 ++++++++++++++++++++
 arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts | 72 ++++++++++++++++++++++++
 arch/arm/boot/dts/imx27.dtsi                     | 40 ++++++++++++-
 4 files changed, 173 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
 create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts

[PATCH v3 1/5] ARM: imx27: Use 'AITC' for the interrupt controller name

[Markus Pargmann]

From: Fabio Estevam <festevam@gmail.com>

On the MX27 Reference Manual the interrupt controller is named AITC:
ARM926EJ-S Interrupt Controller

So use the AITC term instead of AVIC.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Origin: id:1334193132-18944-2-git-send-email-festevam at gmail.com
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 0695264..8603886 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -30,8 +30,8 @@
 		spi2 = &cspi3;
 	};
 
-	avic: avic-interrupt-controller at e0000000 {
-		compatible = "fsl,imx27-avic", "fsl,avic";
+	aitc: aitc-interrupt-controller at e0000000 {
+		compatible = "fsl,imx27-aitc", "fsl,avic";
 		interrupt-controller;
 		#interrupt-cells = <1>;
 		reg = <0x10040000 0x1000>;
@@ -51,7 +51,7 @@
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "simple-bus";
-		interrupt-parent = <&avic>;
+		interrupt-parent = <&aitc>;
 		ranges;
 
 		aipi at 10000000 { /* AIPI1 */
-- 
1.8.2.1

[PATCH v3 2/5] ARM: dts: imx27: Add imx framebuffer device

[Markus Pargmann]

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 arch/arm/boot/dts/imx27.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 8603886..10dcbd3 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -342,6 +342,15 @@
 			reg = <0x10020000 0x20000>;
 			ranges;
 
+			imxfb: fb at 10021000 {
+				compatible = "fsl,imx27-fb", "fsl,imx21-fb";
+				interrupts = <61>;
+				reg = <0x10021000 0x1000>;
+				clocks = <&clks 36>, <&clks 65>, <&clks 59>;
+				clock-names = "ipg", "ahb", "per";
+				status = "disabled";
+			};
+
 			coda: coda at 10023000 {
 				compatible = "fsl,imx27-vpu";
 				reg = <0x10023000 0x0200>;
-- 
1.8.2.1

Re: [PATCH v3 2/5] ARM: dts: imx27: Add imx framebuffer device

[Alexander Shiyan]

> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx27.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 8603886..10dcbd3 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -342,6 +342,15 @@
>  			reg = <0x10020000 0x20000>;
>  			ranges;
>  
> +			imxfb: fb at 10021000 {

If it can be fixed while applying, it would be right to use just "fb" here.
We now use a lot of devices without "imx"-prefix, so I do not see any need to use it here.

> +				compatible = "fsl,imx27-fb", "fsl,imx21-fb";
> +				interrupts = <61>;
> +				reg = <0x10021000 0x1000>;
> +				clocks = <&clks 36>, <&clks 65>, <&clks 59>;
> +				clock-names = "ipg", "ahb", "per";
> +				status = "disabled";
> +			};
> +

---

[PATCH v3 2/5] ARM: dts: imx27: Add imx framebuffer device

[Shawn Guo]

On Fri, Jun 28, 2013 at 07:10:06PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx27.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index 8603886..10dcbd3 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -342,6 +342,15 @@
> >  			reg = <0x10020000 0x20000>;
> >  			ranges;
> >  
> > +			imxfb: fb at 10021000 {
> 
> If it can be fixed while applying, it would be right to use just "fb" here.
> We now use a lot of devices without "imx"-prefix, so I do not see any need to use it here.

I actually prefer to use the block name if it's not a thing defined by
ePAPR.  In this case, it's "lcdc".  But since "fb" is already used in
compatible.  Okay, I fixed it up by dropping "imx" prefix.

Applied the whole series, thanks.

Shawn

Re[2]: [PATCH v3 2/5] ARM: dts: imx27: Add imx framebuffer device

[Alexander Shiyan]

> On Fri, Jun 28, 2013 at 07:10:06PM +0400, Alexander Shiyan wrote:
> > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > > ---
> > >  arch/arm/boot/dts/imx27.dtsi | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > > index 8603886..10dcbd3 100644
> > > --- a/arch/arm/boot/dts/imx27.dtsi
> > > +++ b/arch/arm/boot/dts/imx27.dtsi
> > > @@ -342,6 +342,15 @@
> > >  			reg = <0x10020000 0x20000>;
> > >  			ranges;
> > >  
> > > +			imxfb: fb at 10021000 {
> > 
> > If it can be fixed while applying, it would be right to use just "fb" here.
> > We now use a lot of devices without "imx"-prefix, so I do not see any need to use it here.
> 
> I actually prefer to use the block name if it's not a thing defined by
> ePAPR.  In this case, it's "lcdc".  But since "fb" is already used in
> compatible.  Okay, I fixed it up by dropping "imx" prefix.

i.MX27 have a SLCDC module, so perhaps your proposed option (lcdc) is better.

---

[PATCH v3 3/5] ARM: dts: imx27: Add 1-wire

[Markus Pargmann]

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---

Notes:
    Changes in v3:
     - Removed clock-names, not necessary for this driver.
    
    Changes in v2:
     - Add fsl,imx27-owire as first entry in the compatibility list.

 arch/arm/boot/dts/imx27.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 10dcbd3..a79f173 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -110,6 +110,13 @@
 				clock-names = "ipg", "per";
 			};
 
+			owire: owire at 10009000 {
+				compatible = "fsl,imx27-owire", "fsl,imx21-owire";
+				reg = <0x10009000 0x1000>;
+				clocks = <&clks 35>;
+				status = "disabled";
+			};
+
 			uart1: serial at 1000a000 {
 				compatible = "fsl,imx27-uart", "fsl,imx21-uart";
 				reg = <0x1000a000 0x1000>;
-- 
1.8.2.1

[PATCH v3 4/5] ARM: dts: imx27 cpufreq-cpu0 frequencies

[Markus Pargmann]

Set operating-points for imx27. There is no regulator support, so the
voltages are 0. The frequencies should be the same for all imx27 boards,
so it is defined here and can be overwritten if necessary.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---

Notes:
    Changes in v2:
     - Update compatibility list of cpu node
     - Simplify cpu node

 arch/arm/boot/dts/imx27.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index a79f173..9617d6c 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -47,6 +47,24 @@
 		};
 	};
 
+	cpus {
+		#size-cells = <0>;
+		#address-cells = <1>;
+
+		cpu {
+			device_type = "cpu";
+			compatible = "arm,arm926ej-s";
+			operating-points = <
+				/* kHz  uV (No regulator support) */
+				133000  0
+				399000  0
+			>;
+			clock-latency = <61036>; /* two CLK32 periods */
+			clocks = <&clks 18>;
+			clock-names = "cpu";
+		};
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
1.8.2.1

[PATCH v3 5/5] ARM: dts: Add device tree support for phycard pca100

[Markus Pargmann]

Board files for Phytec phyCARD-S "System on Module" and "Rapid
Development Kit".

Based on patches from:

Steffen Trumtrar <s.trumtrar@pengutronix.de>:
 - Original patch
 - ARM: dts: Set partition offsets for phycard
 - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
 - ARM: imx27-phytec-phycard-S.dts: resize nand partitions

Jan Luebbe <jlu@pengutronix.de>:
 - ARM: dts: Enable bad block table in NAND

Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---

Notes:
    Changes in v3:
     - Fix memory offset
    
    Changes in v2:
     - Remove unnecessary Kconfig nand selection.
     - Style fixes
     - Replace node identifiers with node labels
     - Fix compatibility of cpu node
     - Remove device node for not mainlined dimmer driver
     - Remove nand partition table
     - Remove memory node
     - Splitted board file into "system on module" and "rapid development kit"

 arch/arm/boot/dts/Makefile                       |  2 +
 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 62 ++++++++++++++++++++
 arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts | 72 ++++++++++++++++++++++++
 3 files changed, 136 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
 create mode 100644 arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index b3a8661..707c192 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -105,6 +105,8 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx27-pdk.dtb \
 	imx27-phytec-phycore-som.dtb \
 	imx27-phytec-phycore-rdk.dtb \
+	imx27-phytec-phycard-s-som.dtb \
+	imx27-phytec-phycard-s-rdk.dtb \
 	imx31-bug.dtb \
 	imx51-apf51.dtb \
 	imx51-apf51dev.dtb \
diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
new file mode 100644
index 0000000..bf11429
--- /dev/null
+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts
@@ -0,0 +1,62 @@
+/*
+ * Copyright 2012 Markus Pargmann, Pengutronix
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+#include "imx27-phytec-phycard-s-som.dts"
+
+/ {
+	model = "Phytec pca100 rapid development kit";
+	compatible = "phytec,imx27-pca100-rdk", "phytec,imx27-pca100", "fsl,imx27";
+
+	display: display {
+		model = "Primeview-PD050VL1";
+		native-mode = <&timing0>;
+		bits-per-pixel = <16>;  /* non-standard but required */
+		fsl,pcr = <0xf0c88080>;	/* non-standard but required */
+		display-timings {
+			timing0: 640x480 {
+				hactive = <640>;
+				vactive = <480>;
+				hback-porch = <112>;
+				hfront-porch = <36>;
+				hsync-len = <32>;
+				vback-porch = <33>;
+				vfront-porch = <33>;
+				vsync-len = <2>;
+				clock-frequency = <25000000>;
+			};
+		};
+	};
+};
+
+&imxfb {
+	display = <&display>;
+	status = "okay";
+};
+
+&sdhci2 {
+	cd-gpios = <&gpio3 29 0>;
+	status = "okay";
+};
+
+&uart1 {
+	fsl,uart-has-rtscts;
+	status = "okay";
+};
+
+&uart2 {
+	fsl,uart-has-rtscts;
+	status = "okay";
+};
+
+&uart3 {
+	fsl,uart-has-rtscts;
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
new file mode 100644
index 0000000..ec52b6d
--- /dev/null
+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
@@ -0,0 +1,72 @@
+/*
+ * Copyright 2012 Sascha Hauer, Uwe Kleine-K?nig, Steffen Trumtrar
+ * and Markus Pargmann, Pengutronix
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "imx27.dtsi"
+
+/ {
+	model = "Phytec pca100";
+	compatible = "phytec,imx27-pca100", "fsl,imx27";
+
+	memory {
+		reg = <0xa0000000 0x08000000>; /* 128MB */
+	};
+};
+
+&cspi1 {
+	fsl,spi-num-chipselects = <2>;
+	cs-gpios = <&gpio4 28 0>,
+		<&gpio4 27 0>;
+	status = "okay";
+};
+
+&fec {
+	status = "okay";
+};
+
+&i2c1 {
+	status = "okay";
+
+	ioexpander at 41 {
+		compatible = "nxp,pca9536";
+		reg = <0x41>;
+	};
+
+	rtc at 51 {
+		compatible = "nxp,pcf8563";
+		reg = <0x51>;
+	};
+};
+
+&i2c2 {
+	status = "okay";
+
+	lm75 at 4a {
+		compatible = "national,lm75";
+		reg = <0x4a>;
+	};
+
+	rtc at 51 {
+		compatible = "nxp,pcf8563";
+		reg = <0x51>;
+	};
+
+	at24 at 52 {
+		compatible = "at,24c32";
+		pagesize = <32>;
+		reg = <0x52>;
+	};
+};
+
+&owire {
+	status = "okay";
+};
-- 
1.8.2.1

Re: [PATCH v3 5/5] ARM: dts: Add device tree support for phycard pca100

[Alexander Shiyan]

> Board files for Phytec phyCARD-S "System on Module" and "Rapid
> Development Kit".
> 
> Based on patches from:
> 
> Steffen Trumtrar <s.trumtrar@pengutronix.de>:
>  - Original patch
>  - ARM: dts: Set partition offsets for phycard
>  - ARM: dts: Use CSPI1 instead of CSPI2 on phycard pca100
>  - ARM: imx27-phytec-phycard-S.dts: resize nand partitions
...
> diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
...
> +&i2c1 {
> +	status = "okay";
> +
> +	ioexpander at 41 {
> +		compatible = "nxp,pca9536";
> +		reg = <0x41>;
> +	};
> +
> +	rtc at 51 {
> +		compatible = "nxp,pcf8563";
> +		reg = <0x51>;
> +	};
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +
> +	lm75 at 4a {
> +		compatible = "national,lm75";
> +		reg = <0x4a>;
> +	};
> +
> +	rtc at 51 {
> +		compatible = "nxp,pcf8563";
> +		reg = <0x51>;
> +	};

Really two identical RTC on I2C1 & I2C2 or it is typo?

---

[PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC

[Markus Pargmann]

Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
"ARM: dts: Add device tree support for phycard pca100".

Remove wrong I2C RTC node.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---

Thanks, Alexander, you are right. I2C2 has no RTC.

Regards,

Markus

 arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
index ec52b6d..01ee807 100644
--- a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
+++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
@@ -55,11 +55,6 @@
 		reg = <0x4a>;
 	};
 
-	rtc at 51 {
-		compatible = "nxp,pcf8563";
-		reg = <0x51>;
-	};
-
 	at24 at 52 {
 		compatible = "at,24c32";
 		pagesize = <32>;
-- 
1.8.2.1

[PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC

[Shawn Guo]

On Fri, Jul 05, 2013 at 03:45:09PM +0200, Markus Pargmann wrote:
> Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e

The commit ID is not stable.  I just dropped it and applied the patch.

Shawn

> "ARM: dts: Add device tree support for phycard pca100".
> 
> Remove wrong I2C RTC node.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> 
> Thanks, Alexander, you are right. I2C2 has no RTC.
> 
> Regards,
> 
> Markus
> 
>  arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
> index ec52b6d..01ee807 100644
> --- a/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
> +++ b/arch/arm/boot/dts/imx27-phytec-phycard-s-som.dts
> @@ -55,11 +55,6 @@
>  		reg = <0x4a>;
>  	};
>  
> -	rtc at 51 {
> -		compatible = "nxp,pcf8563";
> -		reg = <0x51>;
> -	};
> -
>  	at24 at 52 {
>  		compatible = "at,24c32";
>  		pagesize = <32>;
> -- 
> 1.8.2.1
> 

Re: [PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC

[Alexander Shiyan]

> Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
> "ARM: dts: Add device tree support for phycard pca100".
> 
> Remove wrong I2C RTC node.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> 
> Thanks, Alexander, you are right. I2C2 has no RTC.
...

There are a couple of comments on this file.

I think that the OWIRE should be moved to the RDK.

ioexpander must contain "gpio-controller" at least, and for use it further,
it is necessary to define the label for this node.

Thanks.

---

[PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC

[Markus Pargmann]

On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote:
> > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
> > "ARM: dts: Add device tree support for phycard pca100".
> > 
> > Remove wrong I2C RTC node.
> > 
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> > 
> > Thanks, Alexander, you are right. I2C2 has no RTC.
> ...
> 
> There are a couple of comments on this file.
> 
> I think that the OWIRE should be moved to the RDK.

I moved OWIRE and i2c1 to RDK. Both are not used on the SOM.

> ioexpander must contain "gpio-controller" at least, and for use it further,
> it is necessary to define the label for this node.

I checked all I2C devices in the board schematics. There is actually no
ioexpander. I don't know why it was added. I will send some I2C patches
later.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re[2]: [PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC

[Alexander Shiyan]

> On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote:
> > > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
> > > "ARM: dts: Add device tree support for phycard pca100".
> > > 
> > > Remove wrong I2C RTC node.
> > > 
> > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > > ---
> > > 
> > > Thanks, Alexander, you are right. I2C2 has no RTC.
> > ...
> > 
> > There are a couple of comments on this file.
> > 
> > I think that the OWIRE should be moved to the RDK.
> 
> I moved OWIRE and i2c1 to RDK. Both are not used on the SOM.
> 
> > ioexpander must contain "gpio-controller" at least, and for use it further,
> > it is necessary to define the label for this node.
> 
> I checked all I2C devices in the board schematics. There is actually no
> ioexpander. I don't know why it was added. I will send some I2C patches
> later.

Perhaps the chip is mounted on the camera module.
A similar IC is exist on PCM-970 camera addon device.
If so, the device should also be moved to RDK.

---

[PATCH] ARM: dts: imx27 phyCARD-S remove wrong I2C RTC

[Markus Pargmann]

On Sun, Jul 07, 2013 at 02:31:41PM +0400, Alexander Shiyan wrote:
> > On Sat, Jul 06, 2013 at 12:51:58PM +0400, Alexander Shiyan wrote:
> > > > Fixup of commit 7874d595b78e431f0f661d2fe47625649308a52e
> > > > "ARM: dts: Add device tree support for phycard pca100".
> > > > 
> > > > Remove wrong I2C RTC node.
> > > > 
> > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > > > ---
> > > > 
> > > > Thanks, Alexander, you are right. I2C2 has no RTC.
> > > ...
> > > 
> > > There are a couple of comments on this file.
> > > 
> > > I think that the OWIRE should be moved to the RDK.
> > 
> > I moved OWIRE and i2c1 to RDK. Both are not used on the SOM.
> > 
> > > ioexpander must contain "gpio-controller" at least, and for use it further,
> > > it is necessary to define the label for this node.
> > 
> > I checked all I2C devices in the board schematics. There is actually no
> > ioexpander. I don't know why it was added. I will send some I2C patches
> > later.
> 
> Perhaps the chip is mounted on the camera module.
> A similar IC is exist on PCM-970 camera addon device.
> If so, the device should also be moved to RDK.

Yes that's possible. But in that case I think the ioexpander should be
removed from both dts files because the Phytec phyCARD-S RDK does not
include a camera module.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH v3 0/5] ARM: dts: imx27 Phytec phyCARD-S

[Sascha Hauer]

On Fri, Jun 28, 2013 at 04:50:32PM +0200, Markus Pargmann wrote:
> Hi,
> 
> This series adds some device nodes for imx27 and board files for Phytec
> phyCARD-S SOM and RDK. It is based on shawn's branch "imx/dt".

Looks good to me.

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |