* [PATCH] ARM: dove: fix missing __init section of dove_mpp_gpio_mode
@ 2013-07-01 14:56 Sebastian Hesselbarth
2013-07-25 15:25 ` Jason Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Hesselbarth @ 2013-07-01 14:56 UTC (permalink / raw)
To: linux-arm-kernel
Legacy dove_mpp_gpio_mode calls orion_gpio_set_valid which is in
__init section. Offending function is not, so this causes a section
mismatch. To fix the mismatch, also move dove_mpp_gpio_mode to
__init section.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
arch/arm/mach-dove/mpp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-dove/mpp.c b/arch/arm/mach-dove/mpp.c
index 60bd729..8a433a5 100644
--- a/arch/arm/mach-dove/mpp.c
+++ b/arch/arm/mach-dove/mpp.c
@@ -47,7 +47,7 @@ static const struct dove_mpp_grp dove_mpp_grp[] = {
/* Enable gpio for a range of pins. mode should be a combination of
GPIO_OUTPUT_OK | GPIO_INPUT_OK */
-static void dove_mpp_gpio_mode(int start, int end, int gpio_mode)
+static void __init dove_mpp_gpio_mode(int start, int end, int gpio_mode)
{
int i;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: dove: fix missing __init section of dove_mpp_gpio_mode
2013-07-01 14:56 [PATCH] ARM: dove: fix missing __init section of dove_mpp_gpio_mode Sebastian Hesselbarth
@ 2013-07-25 15:25 ` Jason Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Jason Cooper @ 2013-07-25 15:25 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 01, 2013 at 04:56:12PM +0200, Sebastian Hesselbarth wrote:
> Legacy dove_mpp_gpio_mode calls orion_gpio_set_valid which is in
> __init section. Offending function is not, so this causes a section
> mismatch. To fix the mismatch, also move dove_mpp_gpio_mode to
> __init section.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> arch/arm/mach-dove/mpp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to mvebu/fixes-non-critical
thx,
Jason.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-25 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-01 14:56 [PATCH] ARM: dove: fix missing __init section of dove_mpp_gpio_mode Sebastian Hesselbarth
2013-07-25 15:25 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).