From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Date: Fri, 5 Jul 2013 16:39:33 -0700 [thread overview]
Message-ID: <1373067573-29946-1-git-send-email-sboyd@codeaurora.org> (raw)
In a uniprocessor implementation the interrupt processor targets
registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
gic_get_cpumask() will print a critical message saying
GIC CPU mask not found - kernel will fail to boot.
if these registers all read as zero, but there won't actually be
a problem on uniprocessor systems and the kernel will boot just
fine. Skip this check if we're running a UP kernel or if we
detect that the hardware only supports a single processor.
Cc: Nicolas Pitre <nico@linaro.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
Maybe we should just drop the check entirely? It looks like it may
just be debug code that won't ever trigger in practice, even on the
11MPCore that caused this code to be introduced.
drivers/irqchip/irq-gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 19ceaa6..589c760 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -368,7 +368,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
break;
}
- if (!mask)
+ if (!mask && num_possible_cpus() > 1)
pr_crit("GIC CPU mask not found - kernel will fail to boot.\n");
return mask;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next reply other threads:[~2013-07-05 23:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 23:39 Stephen Boyd [this message]
2013-07-12 11:13 ` [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system Javi Merino
2013-07-12 12:10 ` Stephen Boyd
2013-07-17 21:53 ` Stephen Boyd
2013-07-17 22:34 ` Nicolas Pitre
2013-07-17 22:36 ` Stephen Boyd
2013-07-17 22:53 ` Nicolas Pitre
2013-07-17 23:06 ` Stephen Boyd
2013-08-22 18:43 ` Stephen Boyd
2013-08-22 18:59 ` Nicolas Pitre
2013-08-23 4:35 ` Stephen Boyd
2013-08-23 4:51 ` Nicolas Pitre
2013-08-23 9:15 ` Russell King - ARM Linux
2013-07-20 7:27 ` Bedia, Vaibhav
2013-07-23 17:01 ` Stephen Boyd
-- strict thread matches above, loose matches on Subject: below --
2015-01-31 0:43 Stephen Boyd
2015-01-31 7:09 ` Felipe Balbi
2015-02-12 3:51 ` Nishanth Menon
2015-02-01 21:25 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373067573-29946-1-git-send-email-sboyd@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).