* [PATCH] ARM: dts: i.MX51: Add WEIM node
@ 2013-07-06 7:02 Alexander Shiyan
2013-07-08 2:33 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2013-07-06 7:02 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds the missing (Wireless External Interface Module) WEIM
devicetree node for i.MX51 CPUs.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx51.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 0ca62be..e71976e4 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -745,6 +745,23 @@
status = "disabled";
};
+ weim: weim at 83fda000 {
+ #address-cells = <2>;
+ #size-cells = <1>;
+ compatible = "fsl,imx51-weim";
+ reg = <0x83fda000 0x1000>;
+ clocks = <&clks 0>;
+ ranges = <
+ 0 0 0xb0000000 0x08000000
+ 1 0 0xb8000000 0x08000000
+ 2 0 0xc0000000 0x08000000
+ 3 0 0xc8000000 0x04000000
+ 4 0 0xcc000000 0x02000000
+ 5 0 0xce000000 0x02000000
+ >;
+ status = "disabled";
+ };
+
nfc: nand at 83fdb000 {
compatible = "fsl,imx51-nand";
reg = <0x83fdb000 0x1000 0xcfff0000 0x10000>;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: i.MX51: Add WEIM node
2013-07-06 7:02 [PATCH] ARM: dts: i.MX51: Add WEIM node Alexander Shiyan
@ 2013-07-08 2:33 ` Shawn Guo
2013-07-08 4:29 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2013-07-08 2:33 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jul 06, 2013 at 11:02:22AM +0400, Alexander Shiyan wrote:
> This patch adds the missing (Wireless External Interface Module) WEIM
> devicetree node for i.MX51 CPUs.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx51.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> index 0ca62be..e71976e4 100644
> --- a/arch/arm/boot/dts/imx51.dtsi
> +++ b/arch/arm/boot/dts/imx51.dtsi
> @@ -745,6 +745,23 @@
> status = "disabled";
> };
>
> + weim: weim at 83fda000 {
> + #address-cells = <2>;
> + #size-cells = <1>;
> + compatible = "fsl,imx51-weim";
> + reg = <0x83fda000 0x1000>;
> + clocks = <&clks 0>;
Is it correct? I think there should be a physical clock for weim.
Shawn
> + ranges = <
> + 0 0 0xb0000000 0x08000000
> + 1 0 0xb8000000 0x08000000
> + 2 0 0xc0000000 0x08000000
> + 3 0 0xc8000000 0x04000000
> + 4 0 0xcc000000 0x02000000
> + 5 0 0xce000000 0x02000000
> + >;
> + status = "disabled";
> + };
> +
> nfc: nand at 83fdb000 {
> compatible = "fsl,imx51-nand";
> reg = <0x83fdb000 0x1000 0xcfff0000 0x10000>;
> --
> 1.8.1.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re[2]: [PATCH] ARM: dts: i.MX51: Add WEIM node
2013-07-08 2:33 ` Shawn Guo
@ 2013-07-08 4:29 ` Alexander Shiyan
2013-07-09 3:27 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2013-07-08 4:29 UTC (permalink / raw)
To: linux-arm-kernel
> On Sat, Jul 06, 2013 at 11:02:22AM +0400, Alexander Shiyan wrote:
> > This patch adds the missing (Wireless External Interface Module) WEIM
> > devicetree node for i.MX51 CPUs.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/boot/dts/imx51.dtsi | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> > index 0ca62be..e71976e4 100644
> > --- a/arch/arm/boot/dts/imx51.dtsi
> > +++ b/arch/arm/boot/dts/imx51.dtsi
> > @@ -745,6 +745,23 @@
> > status = "disabled";
> > };
> >
> > + weim: weim at 83fda000 {
> > + #address-cells = <2>;
> > + #size-cells = <1>;
> > + compatible = "fsl,imx51-weim";
> > + reg = <0x83fda000 0x1000>;
> > + clocks = <&clks 0>;
>
> Is it correct? I think there should be a physical clock for weim.
Yes, but properly clock for weim is missing in the clk subsystem,
so I think at this point it is OK. Adding a properly clock should be a separate patch.
Thanks.
---
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: i.MX51: Add WEIM node
2013-07-08 4:29 ` Re[2]: " Alexander Shiyan
@ 2013-07-09 3:27 ` Shawn Guo
2013-07-09 11:18 ` Alexander Shiyan
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2013-07-09 3:27 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 08, 2013 at 08:29:43AM +0400, Alexander Shiyan wrote:
> > > @@ -745,6 +745,23 @@
> > > status = "disabled";
> > > };
> > >
> > > + weim: weim at 83fda000 {
> > > + #address-cells = <2>;
> > > + #size-cells = <1>;
> > > + compatible = "fsl,imx51-weim";
> > > + reg = <0x83fda000 0x1000>;
> > > + clocks = <&clks 0>;
> >
> > Is it correct? I think there should be a physical clock for weim.
>
> Yes, but properly clock for weim is missing in the clk subsystem,
> so I think at this point it is OK. Adding a properly clock should be a separate patch.
I've seen emi_slow and emi_fast clocks implemented in clk-imx51-imx53.c.
Neither is the clock for weim?
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: i.MX51: Add WEIM node
2013-07-09 3:27 ` Shawn Guo
@ 2013-07-09 11:18 ` Alexander Shiyan
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Shiyan @ 2013-07-09 11:18 UTC (permalink / raw)
To: linux-arm-kernel
> On Mon, Jul 08, 2013 at 08:29:43AM +0400, Alexander Shiyan wrote:
> > > > @@ -745,6 +745,23 @@
> > > > status = "disabled";
> > > > };
> > > >
> > > > + weim: weim at 83fda000 {
> > > > + #address-cells = <2>;
> > > > + #size-cells = <1>;
> > > > + compatible = "fsl,imx51-weim";
> > > > + reg = <0x83fda000 0x1000>;
> > > > + clocks = <&clks 0>;
> > >
> > > Is it correct? I think there should be a physical clock for weim.
> >
> > Yes, but properly clock for weim is missing in the clk subsystem,
> > so I think at this point it is OK. Adding a properly clock should be a separate patch.
>
> I've seen emi_slow and emi_fast clocks implemented in clk-imx51-imx53.c.
> Neither is the clock for weim?
I reviewed the documentation, emi_fast clock is used for DDR, emi_slow for WEIM,
so will post the revised patch.
Thanks.
---
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-09 11:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-06 7:02 [PATCH] ARM: dts: i.MX51: Add WEIM node Alexander Shiyan
2013-07-08 2:33 ` Shawn Guo
2013-07-08 4:29 ` Re[2]: " Alexander Shiyan
2013-07-09 3:27 ` Shawn Guo
2013-07-09 11:18 ` Alexander Shiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).