linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: fix a memleak when freeing maps
@ 2013-07-22 23:45 Linus Walleij
  2013-07-23 16:01 ` Stephen Warren
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2013-07-22 23:45 UTC (permalink / raw)
  To: linux-arm-kernel

We forgot to free the node itself when free:ing a map.

Reported-by: xulinuxkernel <xulinuxkernel@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 5b272bf..2a00239 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1193,6 +1193,7 @@ void pinctrl_unregister_map(struct pinctrl_map const *map)
 	list_for_each_entry(maps_node, &pinctrl_maps, node) {
 		if (maps_node->maps == map) {
 			list_del(&maps_node->node);
+			kfree(maps_node);
 			mutex_unlock(&pinctrl_maps_mutex);
 			return;
 		}
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] pinctrl: fix a memleak when freeing maps
  2013-07-22 23:45 [PATCH] pinctrl: fix a memleak when freeing maps Linus Walleij
@ 2013-07-23 16:01 ` Stephen Warren
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2013-07-23 16:01 UTC (permalink / raw)
  To: linux-arm-kernel

On 07/22/2013 04:45 PM, Linus Walleij wrote:
> We forgot to free the node itself when free:ing a map.
> 
> Reported-by: xulinuxkernel <xulinuxkernel@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Stephen Warren <swarren@nvidia.com>

The full name in the reported-by doesn't look accurate, but I suppose
that isn't an s-o-b entry, so it's not a big deal.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-23 16:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-22 23:45 [PATCH] pinctrl: fix a memleak when freeing maps Linus Walleij
2013-07-23 16:01 ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).