From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/13] ARM: bL_switcher: ability to enable and disable the switcher via sysfs
Date: Mon, 22 Jul 2013 23:31:25 -0400 [thread overview]
Message-ID: <1374550289-25305-10-git-send-email-nicolas.pitre@linaro.org> (raw)
In-Reply-To: <1374550289-25305-1-git-send-email-nicolas.pitre@linaro.org>
The /sys/kernel/bL_switcher/enable file allows to enable or disable
the switcher by writing 1 or 0 to it respectively. It is still enabled
by default on boot.
Signed-off-by: Nicolas Pitre <nico@linaro.org>
---
arch/arm/common/bL_switcher.c | 171 +++++++++++++++++++++++++++++++++++++++---
1 file changed, 160 insertions(+), 11 deletions(-)
diff --git a/arch/arm/common/bL_switcher.c b/arch/arm/common/bL_switcher.c
index 34eff3bc25..abeeff5520 100644
--- a/arch/arm/common/bL_switcher.c
+++ b/arch/arm/common/bL_switcher.c
@@ -24,6 +24,7 @@
#include <linux/tick.h>
#include <linux/mm.h>
#include <linux/string.h>
+#include <linux/sysfs.h>
#include <linux/irqchip/arm-gic.h>
#include <asm/smp_plat.h>
@@ -226,6 +227,7 @@ struct bL_thread {
struct task_struct *task;
wait_queue_head_t wq;
int wanted_cluster;
+ struct completion started;
};
static struct bL_thread bL_threads[MAX_CPUS_PER_CLUSTER];
@@ -237,6 +239,7 @@ static int bL_switcher_thread(void *arg)
int cluster;
sched_setscheduler_nocheck(current, SCHED_FIFO, ¶m);
+ complete(&t->started);
do {
if (signal_pending(current))
@@ -252,7 +255,7 @@ static int bL_switcher_thread(void *arg)
return 0;
}
-static struct task_struct * __init bL_switcher_thread_create(int cpu, void *arg)
+static struct task_struct *bL_switcher_thread_create(int cpu, void *arg)
{
struct task_struct *task;
@@ -301,9 +304,11 @@ EXPORT_SYMBOL_GPL(bL_switch_request);
* Activation and configuration code.
*/
+static unsigned int bL_switcher_active;
+static unsigned int bL_switcher_cpu_original_cluster[MAX_CPUS_PER_CLUSTER];
static cpumask_t bL_switcher_removed_logical_cpus;
-static void __init bL_switcher_restore_cpus(void)
+static void bL_switcher_restore_cpus(void)
{
int i;
@@ -311,7 +316,7 @@ static void __init bL_switcher_restore_cpus(void)
cpu_up(i);
}
-static int __init bL_switcher_halve_cpus(void)
+static int bL_switcher_halve_cpus(void)
{
int cpu, cluster, i, ret;
cpumask_t cluster_mask[2], common_mask;
@@ -355,8 +360,10 @@ static int __init bL_switcher_halve_cpus(void)
* is equal to their physical CPU number. This is
* not perfect but good enough for now.
*/
- if (cpu == i)
+ if (cpu == i) {
+ bL_switcher_cpu_original_cluster[cpu] = cluster;
continue;
+ }
}
ret = cpu_down(i);
@@ -370,18 +377,18 @@ static int __init bL_switcher_halve_cpus(void)
return 0;
}
-static int __init bL_switcher_init(void)
+static int bL_switcher_enable(void)
{
int cpu, ret;
- pr_info("big.LITTLE switcher initializing\n");
-
- if (MAX_NR_CLUSTERS != 2) {
- pr_err("%s: only dual cluster systems are supported\n", __func__);
- return -EINVAL;
+ cpu_hotplug_driver_lock();
+ if (bL_switcher_active) {
+ cpu_hotplug_driver_unlock();
+ return 0;
}
- cpu_hotplug_driver_lock();
+ pr_info("big.LITTLE switcher initializing\n");
+
ret = bL_switcher_halve_cpus();
if (ret) {
cpu_hotplug_driver_unlock();
@@ -391,13 +398,155 @@ static int __init bL_switcher_init(void)
for_each_online_cpu(cpu) {
struct bL_thread *t = &bL_threads[cpu];
init_waitqueue_head(&t->wq);
+ init_completion(&t->started);
t->wanted_cluster = -1;
t->task = bL_switcher_thread_create(cpu, t);
}
+
+ bL_switcher_active = 1;
cpu_hotplug_driver_unlock();
pr_info("big.LITTLE switcher initialized\n");
return 0;
}
+#ifdef CONFIG_SYSFS
+
+static void bL_switcher_disable(void)
+{
+ unsigned int cpu, cluster, i;
+ struct bL_thread *t;
+ struct task_struct *task;
+
+ cpu_hotplug_driver_lock();
+ if (!bL_switcher_active) {
+ cpu_hotplug_driver_unlock();
+ return;
+ }
+ bL_switcher_active = 0;
+
+ /*
+ * To deactivate the switcher, we must shut down the switcher
+ * threads to prevent any other requests from being accepted.
+ * Then, if the final cluster for given logical CPU is not the
+ * same as the original one, we'll recreate a switcher thread
+ * just for the purpose of switching the CPU back without any
+ * possibility for interference from external requests.
+ */
+ for_each_online_cpu(cpu) {
+ BUG_ON(cpu != (cpu_logical_map(cpu) & 0xff));
+ t = &bL_threads[cpu];
+ task = t->task;
+ t->task = NULL;
+ if (!task || IS_ERR(task))
+ continue;
+ kthread_stop(task);
+ /* no more switch may happen on this CPU at this point */
+ cluster = MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1);
+ if (cluster == bL_switcher_cpu_original_cluster[cpu])
+ continue;
+ init_completion(&t->started);
+ t->wanted_cluster = bL_switcher_cpu_original_cluster[cpu];
+ task = bL_switcher_thread_create(cpu, t);
+ if (!IS_ERR(task)) {
+ wait_for_completion(&t->started);
+ kthread_stop(task);
+ cluster = MPIDR_AFFINITY_LEVEL(cpu_logical_map(cpu), 1);
+ if (cluster == bL_switcher_cpu_original_cluster[cpu])
+ continue;
+ }
+ /* If execution gets here, we're in trouble. */
+ pr_crit("%s: unable to restore original cluster for CPU %d\n",
+ __func__, cpu);
+ for_each_cpu(i, &bL_switcher_removed_logical_cpus) {
+ if ((cpu_logical_map(i) & 0xff) != cpu)
+ continue;
+ pr_crit("%s: CPU %d can't be restored\n",
+ __func__, i);
+ cpumask_clear_cpu(i, &bL_switcher_removed_logical_cpus);
+ break;
+ }
+ }
+
+ bL_switcher_restore_cpus();
+ cpu_hotplug_driver_unlock();
+}
+
+static ssize_t bL_switcher_active_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ return sprintf(buf, "%u\n", bL_switcher_active);
+}
+
+static ssize_t bL_switcher_active_store(struct kobject *kobj,
+ struct kobj_attribute *attr, const char *buf, size_t count)
+{
+ int ret;
+
+ switch (buf[0]) {
+ case '0':
+ bL_switcher_disable();
+ ret = 0;
+ break;
+ case '1':
+ ret = bL_switcher_enable();
+ break;
+ default:
+ ret = -EINVAL;
+ }
+
+ return (ret >= 0) ? count : ret;
+}
+
+static struct kobj_attribute bL_switcher_active_attr =
+ __ATTR(active, 0644, bL_switcher_active_show, bL_switcher_active_store);
+
+static struct attribute *bL_switcher_attrs[] = {
+ &bL_switcher_active_attr.attr,
+ NULL,
+};
+
+static struct attribute_group bL_switcher_attr_group = {
+ .attrs = bL_switcher_attrs,
+};
+
+static struct kobject *bL_switcher_kobj;
+
+static int __init bL_switcher_sysfs_init(void)
+{
+ int ret;
+
+ bL_switcher_kobj = kobject_create_and_add("bL_switcher", kernel_kobj);
+ if (!bL_switcher_kobj)
+ return -ENOMEM;
+ ret = sysfs_create_group(bL_switcher_kobj, &bL_switcher_attr_group);
+ if (ret)
+ kobject_put(bL_switcher_kobj);
+ return ret;
+}
+
+#endif /* CONFIG_SYSFS */
+
+static int __init bL_switcher_init(void)
+{
+ int ret;
+
+ if (MAX_NR_CLUSTERS != 2) {
+ pr_err("%s: only dual cluster systems are supported\n", __func__);
+ return -EINVAL;
+ }
+
+ ret = bL_switcher_enable();
+ if (ret)
+ return ret;
+
+#ifdef CONFIG_SYSFS
+ ret = bL_switcher_sysfs_init();
+ if (ret)
+ pr_err("%s: unable to create sysfs entry\n", __func__);
+#endif
+
+ return 0;
+}
+
late_initcall(bL_switcher_init);
--
1.8.1.2
next prev parent reply other threads:[~2013-07-23 3:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 3:31 [PATCH 00/13] The big.LITTLE In-Kernel Switcher (IKS), part 1 Nicolas Pitre
2013-07-23 3:31 ` [PATCH 01/13] ARM: suspend: use hash of cpu_logical_map value to index into save array Nicolas Pitre
2013-07-24 16:47 ` Dave Martin
2013-07-24 18:55 ` Nicolas Pitre
2013-07-25 10:55 ` Dave Martin
2013-07-25 16:06 ` Nicolas Pitre
2013-07-26 11:31 ` Lorenzo Pieralisi
2013-07-26 14:41 ` Nicolas Pitre
2013-07-26 15:34 ` Dave Martin
2013-07-26 15:43 ` Nicolas Pitre
2013-07-26 15:45 ` Dave Martin
2013-07-26 17:04 ` Lorenzo Pieralisi
2013-07-26 19:19 ` Nicolas Pitre
2013-07-29 11:50 ` Lorenzo Pieralisi
2013-07-30 2:08 ` Nicolas Pitre
2013-07-30 9:15 ` Dave Martin
2013-07-23 3:31 ` [PATCH 02/13] ARM: gic: add CPU migration support Nicolas Pitre
2013-07-25 11:44 ` Jonathan Austin
2013-07-25 19:11 ` Nicolas Pitre
2013-07-23 3:31 ` [PATCH 03/13] ARM: b.L: core switcher code Nicolas Pitre
2013-07-25 17:15 ` Jonathan Austin
2013-07-25 20:20 ` Nicolas Pitre
2013-07-26 10:45 ` Lorenzo Pieralisi
2013-07-26 14:29 ` Nicolas Pitre
2013-07-26 14:53 ` Russell King - ARM Linux
2013-07-26 15:10 ` Nicolas Pitre
2013-07-23 3:31 ` [PATCH 04/13] ARM: bL_switcher: add clockevent save/restore support Nicolas Pitre
2013-07-23 3:31 ` [PATCH 05/13] ARM: bL_switcher: move to dedicated threads rather than workqueues Nicolas Pitre
2013-07-26 15:18 ` Lorenzo Pieralisi
2013-07-26 15:39 ` Nicolas Pitre
2013-07-23 3:31 ` [PATCH 06/13] ARM: bL_switcher: simplify stack isolation Nicolas Pitre
2013-07-23 3:31 ` [PATCH 07/13] ARM: bL_switcher: hot-unplug half of the available CPUs Nicolas Pitre
2013-07-23 3:31 ` [PATCH 08/13] ARM: bL_switcher: do not hardcode GIC IDs in the code Nicolas Pitre
2013-07-23 3:31 ` Nicolas Pitre [this message]
2013-07-23 3:31 ` [PATCH 10/13] ARM: bL_switcher: add kernel cmdline param to disable the switcher on boot Nicolas Pitre
2013-07-23 3:31 ` [PATCH 11/13] ARM: bL_switcher: veto CPU hotplug requests when the switcher is active Nicolas Pitre
2013-07-31 10:30 ` Lorenzo Pieralisi
2013-08-05 4:25 ` Nicolas Pitre
2013-07-23 3:31 ` [PATCH 12/13] ARM: bL_switcher: remove assumptions between logical and physical CPUs Nicolas Pitre
2013-07-30 16:30 ` Lorenzo Pieralisi
2013-07-30 19:15 ` Nicolas Pitre
2013-07-31 9:41 ` Lorenzo Pieralisi
2013-07-23 3:31 ` [PATCH 13/13] ARM: bL_switcher: add a simple /dev user interface for debugging purposes Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374550289-25305-10-git-send-email-nicolas.pitre@linaro.org \
--to=nicolas.pitre@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).