[PATCH] ARM: dts: imx53-qsb: Make USBH1 functional

[PATCH] ARM: dts: imx53-qsb: Make USBH1 functional

[Fabio Estevam]

mx53qsb uses GPIO7_8 to turn on VBUS, so add support for it.

Also specify the PHY type in the device tree.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
In order to test USBH1 the following patch is also needed:
"[PATCH] chipidea: core: Move hw_phymode_configure() into probe"

Just sent it to the linux-usb list.

 arch/arm/boot/dts/imx53-qsb.dts | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index eedd27e..e97ddae 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -93,6 +93,15 @@
 			regulator-max-microvolt = <3200000>;
 			regulator-always-on;
 		};
+
+		reg_usb_vbus: usb_vbus {
+			compatible = "regulator-fixed";
+			regulator-name = "usb_vbus";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			gpio = <&gpio7 8 0>;
+			enable-active-high;
+		};
 	};
 
 	sound {
@@ -145,6 +154,7 @@
 				MX53_PAD_EIM_DA12__GPIO3_12       0x80000000
 				MX53_PAD_EIM_DA13__GPIO3_13       0x80000000
 				MX53_PAD_PATA_DA_0__GPIO7_6       0x80000000
+				MX53_PAD_PATA_DA_2__GPIO7_8	  0x80000000
 				MX53_PAD_GPIO_16__GPIO7_11        0x80000000
 			>;
 		};
@@ -302,7 +312,9 @@
 };
 
 &usbh1 {
-       status = "okay";
+	vbus-supply = <&reg_usb_vbus>;
+	phy_type = "utmi";
+	status = "okay";
 };
 
 &usbotg {
-- 
1.8.1.2

[PATCH] ARM: dts: imx53-qsb: Make USBH1 functional

[Arnaud Patard (Rtp)]

Fabio Estevam <fabio.estevam@freescale.com> writes:
Hi,

[...]

> @@ -302,7 +312,9 @@
>  };
>  
>  &usbh1 {
> -       status = "okay";
> +	vbus-supply = <&reg_usb_vbus>;
> +	phy_type = "utmi";
> +	status = "okay";
>  };
>  
>  &usbotg {

why not putting the vbus supply on the otg node too ?

Other than this point, works for me.

Tested-by: Arnaud Patard <arnaud.patard@rtp-net.org>

[PATCH] ARM: dts: imx53-qsb: Make USBH1 functional

[Fabio Estevam]

Hi Arnaud,

On Fri, Jul 26, 2013 at 4:32 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> Fabio Estevam <fabio.estevam@freescale.com> writes:
> Hi,
>
> [...]
>
>> @@ -302,7 +312,9 @@
>>  };
>>
>>  &usbh1 {
>> -       status = "okay";
>> +     vbus-supply = <&reg_usb_vbus>;
>> +     phy_type = "utmi";
>> +     status = "okay";
>>  };
>>
>>  &usbotg {
>
> why not putting the vbus supply on the otg node too ?

I think it would be better to use the otg port as peripheral mode
(after Peter Chen's patches get accepted), so that's why I did not
place the regulatoe into the otg node.

If I recall correctly usb role switch does not work on this board, so
better to use peripheral on otg port and host in USBH1.

Regards,

Fabio Estevam

[PATCH] ARM: dts: imx53-qsb: Make USBH1 functional

[Shawn Guo]

On Thu, Jul 25, 2013 at 06:18:33PM -0300, Fabio Estevam wrote:
> mx53qsb uses GPIO7_8 to turn on VBUS, so add support for it.
> 
> Also specify the PHY type in the device tree.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks.