* [PATCH] xen/arm: missing put_cpu in xen_percpu_init
@ 2013-07-29 16:06 Julien Grall
2013-08-02 17:18 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2013-07-29 16:06 UTC (permalink / raw)
To: linux-arm-kernel
When CONFIG_PREEMPT is enabled, Linux will not be able to boot and warn:
[ 4.127825] ------------[ cut here ]------------
[ 4.133376] WARNING: at init/main.c:699 do_one_initcall+0x150/0x158()
[ 4.140738] initcall xen_init_events+0x0/0x10c returned with preemption imbalance
This is because xen_percpu_init uses get_cpu but doesn't have the corresponding
put_cpu.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
arch/arm/xen/enlighten.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index f71c37e..dc9f284 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -170,6 +170,7 @@ static void __init xen_percpu_init(void *unused)
per_cpu(xen_vcpu, cpu) = vcpup;
enable_percpu_irq(xen_events_irq, 0);
+ put_cpu();
}
static void xen_restart(char str, const char *cmd)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] xen/arm: missing put_cpu in xen_percpu_init
2013-07-29 16:06 [PATCH] xen/arm: missing put_cpu in xen_percpu_init Julien Grall
@ 2013-08-02 17:18 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2013-08-02 17:18 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 29 Jul 2013, Julien Grall wrote:
> When CONFIG_PREEMPT is enabled, Linux will not be able to boot and warn:
> [ 4.127825] ------------[ cut here ]------------
> [ 4.133376] WARNING: at init/main.c:699 do_one_initcall+0x150/0x158()
> [ 4.140738] initcall xen_init_events+0x0/0x10c returned with preemption imbalance
>
> This is because xen_percpu_init uses get_cpu but doesn't have the corresponding
> put_cpu.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Ops. Thanks for catching the bug.
I'll add this to my queue.
> arch/arm/xen/enlighten.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index f71c37e..dc9f284 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -170,6 +170,7 @@ static void __init xen_percpu_init(void *unused)
> per_cpu(xen_vcpu, cpu) = vcpup;
>
> enable_percpu_irq(xen_events_irq, 0);
> + put_cpu();
> }
>
> static void xen_restart(char str, const char *cmd)
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-02 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-29 16:06 [PATCH] xen/arm: missing put_cpu in xen_percpu_init Julien Grall
2013-08-02 17:18 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).