linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] pinctrl: imx: work around select input quirk
@ 2013-08-01  4:22 Shawn Guo
  2013-08-01  4:22 ` [PATCH 2/2] ARM: dts: imx6q: add quirky select input for USB_OTG_ID Shawn Guo
  2013-08-01  6:51 ` [PATCH 1/2] pinctrl: imx: work around select input quirk Peter Chen
  0 siblings, 2 replies; 12+ messages in thread
From: Shawn Guo @ 2013-08-01  4:22 UTC (permalink / raw)
  To: linux-arm-kernel

The select input for some pin may not be implemented using the regular
select input register but the general purpose register.  A real example
is that imx6q designers found the select input for USB OTG ID pin is
missing at the very late stage, and can not add a new select input
register but have to use a general purpose register bit to implement it.

The patch adds a workaround for such select input quirk by interpreting
the input_val cell of pin function ID in a different way, so that all
the info that needed for setting up select input bits in general purpose
register could be decoded from there.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 drivers/pinctrl/pinctrl-imx.c |   25 ++++++++++++++++++++++++-
 1 files changed, 24 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index 57a4eb0..6ebe2e9 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -241,7 +241,30 @@ static int imx_pmx_enable(struct pinctrl_dev *pctldev, unsigned selector,
 
 		/* some pins also need select input setting, set it if found */
 		if (input_reg[i]) {
-			writel(input_val[i], ipctl->base + input_reg[i]);
+			u32 val = input_val[i];
+			/*
+			 * If the select input value begins with 0xff, the value
+			 * will be interpreted as below.
+			 *     31     23      15      7        0
+			 *     | 0xff | shift | width | select |
+			 * It's used to work around the problem that the select
+			 * input for some pin is not implemented in the select
+			 * input register but in some general purpose register.
+			 * We encode the select input value, width and shift of
+			 * the bit field into input_val cell of pin function ID
+			 * in device tree, and then decode them here for setting
+			 * up the select input bits in general purpose register.
+			 */
+			if (val >> 24 == 0xff) {
+				u8 select = val & 0xff;
+				u8 width = (val >> 8) & 0xff;
+				u8 shift = (val >> 16) & 0xff;
+				u32 mask = ((1 << width) - 1) << shift;
+				val = readl(ipctl->base + input_reg[i]);
+				val &= ~mask;
+				val |= select << shift;
+			}
+			writel(val, ipctl->base + input_reg[i]);
 			dev_dbg(ipctl->dev,
 				"==>select_input: offset 0x%x val 0x%x\n",
 				input_reg[i], input_val[i]);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-08-13  6:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-01  4:22 [PATCH 1/2] pinctrl: imx: work around select input quirk Shawn Guo
2013-08-01  4:22 ` [PATCH 2/2] ARM: dts: imx6q: add quirky select input for USB_OTG_ID Shawn Guo
2013-08-07 18:34   ` Linus Walleij
2013-08-08  1:27     ` Shawn Guo
2013-08-13  6:18       ` Linus Walleij
2013-08-01  6:51 ` [PATCH 1/2] pinctrl: imx: work around select input quirk Peter Chen
2013-08-01  7:08   ` Shawn Guo
2013-08-01  8:32     ` Peter Chen
2013-08-04 12:54       ` Shawn Guo
2013-08-05  1:14         ` Peter Chen
2013-08-05  3:26           ` Shawn Guo
2013-08-05  1:35             ` Peter Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).