* [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
@ 2013-08-01 11:27 Chen Baozi
2013-08-05 15:26 ` Chen Baozi
0 siblings, 1 reply; 6+ messages in thread
From: Chen Baozi @ 2013-08-01 11:27 UTC (permalink / raw)
To: linux-arm-kernel
The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
rather than INCREMENTER_NUMERATOR_OFFSET.
Signed-off-by: Chen Baozi <baozich@gmail.com>
---
arch/arm/mach-omap2/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
index b37e1fc..9265e03 100644
--- a/arch/arm/mach-omap2/timer.c
+++ b/arch/arm/mach-omap2/timer.c
@@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
reg |= num;
__raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
- reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
+ reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
NUMERATOR_DENUMERATOR_MASK;
reg |= den;
__raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
2013-08-01 11:27 [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD Chen Baozi
@ 2013-08-05 15:26 ` Chen Baozi
2013-08-07 11:09 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Chen Baozi @ 2013-08-05 15:26 UTC (permalink / raw)
To: linux-arm-kernel
ping?
On Aug 1, 2013, at 7:27 PM, Chen Baozi <baozich@gmail.com> wrote:
> The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
> rather than INCREMENTER_NUMERATOR_OFFSET.
>
> Signed-off-by: Chen Baozi <baozich@gmail.com>
> ---
> arch/arm/mach-omap2/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index b37e1fc..9265e03 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
> reg |= num;
> __raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
>
> - reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
> + reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
> NUMERATOR_DENUMERATOR_MASK;
> reg |= den;
> __raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
> --
> 1.8.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
2013-08-05 15:26 ` Chen Baozi
@ 2013-08-07 11:09 ` Tony Lindgren
2013-08-07 13:35 ` Chen Baozi
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2013-08-07 11:09 UTC (permalink / raw)
To: linux-arm-kernel
* Chen Baozi <baozich@gmail.com> [130805 08:33]:
> ping?
>
> On Aug 1, 2013, at 7:27 PM, Chen Baozi <baozich@gmail.com> wrote:
>
> > The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
> > rather than INCREMENTER_NUMERATOR_OFFSET.
Maybe describe what exactly happens without this fix?
Also we should get few acks for this for the -rc series.
Regards,
Tony
> > Signed-off-by: Chen Baozi <baozich@gmail.com>
> > ---
> > arch/arm/mach-omap2/timer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> > index b37e1fc..9265e03 100644
> > --- a/arch/arm/mach-omap2/timer.c
> > +++ b/arch/arm/mach-omap2/timer.c
> > @@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
> > reg |= num;
> > __raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
> >
> > - reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
> > + reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
> > NUMERATOR_DENUMERATOR_MASK;
> > reg |= den;
> > __raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
> > --
> > 1.8.1.4
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
2013-08-07 11:09 ` Tony Lindgren
@ 2013-08-07 13:35 ` Chen Baozi
0 siblings, 0 replies; 6+ messages in thread
From: Chen Baozi @ 2013-08-07 13:35 UTC (permalink / raw)
To: linux-arm-kernel
On Aug 7, 2013, at 7:09 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Chen Baozi <baozich@gmail.com> [130805 08:33]:
>> ping?
>>
>> On Aug 1, 2013, at 7:27 PM, Chen Baozi <baozich@gmail.com> wrote:
>>
>>> The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
>>> rather than INCREMENTER_NUMERATOR_OFFSET.
>
> Maybe describe what exactly happens without this fix?
I think it is more likely a typo, since
INCREMENTER_DENUMERATOR_RELOAD[23:17] is reserved. It seems
that it won't make much trouble without this fix because
the useful [11:0] bit is mask and set the right value later.
Cheers,
Baozi
>
> Also we should get few acks for this for the -rc series.
>
> Regards,
>
> Tony
>
>>> Signed-off-by: Chen Baozi <baozich@gmail.com>
>>> ---
>>> arch/arm/mach-omap2/timer.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
>>> index b37e1fc..9265e03 100644
>>> --- a/arch/arm/mach-omap2/timer.c
>>> +++ b/arch/arm/mach-omap2/timer.c
>>> @@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
>>> reg |= num;
>>> __raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
>>>
>>> - reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
>>> + reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
>>> NUMERATOR_DENUMERATOR_MASK;
>>> reg |= den;
>>> __raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
>>> --
>>> 1.8.1.4
>>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
@ 2013-08-07 14:05 Chen Baozi
2013-08-21 8:03 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Chen Baozi @ 2013-08-07 14:05 UTC (permalink / raw)
To: linux-arm-kernel
The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
rather than INCREMENTER_NUMERATOR_OFFSET.
This is more likely a typo, since INCREMENTER_DENUMERATOR_RELOAD[23:17] is
reserved. It seems that it won't make much trouble without this fix, because
the useful [11:0] bits are mask and set the right value. Anyway, reading
from a right address is better choice.
Signed-off-by: Chen Baozi <baozich@gmail.com>
---
arch/arm/mach-omap2/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
index 1e77f11..ccc5c72 100644
--- a/arch/arm/mach-omap2/timer.c
+++ b/arch/arm/mach-omap2/timer.c
@@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
reg |= num;
__raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
- reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
+ reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
NUMERATOR_DENUMERATOR_MASK;
reg |= den;
__raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
2013-08-07 14:05 Chen Baozi
@ 2013-08-21 8:03 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2013-08-21 8:03 UTC (permalink / raw)
To: linux-arm-kernel
* Chen Baozi <baozich@gmail.com> [130807 07:18]:
> The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
> rather than INCREMENTER_NUMERATOR_OFFSET.
>
> This is more likely a typo, since INCREMENTER_DENUMERATOR_RELOAD[23:17] is
> reserved. It seems that it won't make much trouble without this fix, because
> the useful [11:0] bits are mask and set the right value. Anyway, reading
> from a right address is better choice.
Thanks applying to omap-for-v3.12/fixes-non-critical.
Tony
> Signed-off-by: Chen Baozi <baozich@gmail.com>
> ---
> arch/arm/mach-omap2/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index 1e77f11..ccc5c72 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
> reg |= num;
> __raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
>
> - reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
> + reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
> NUMERATOR_DENUMERATOR_MASK;
> reg |= den;
> __raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
> --
> 1.8.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-21 8:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-01 11:27 [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD Chen Baozi
2013-08-05 15:26 ` Chen Baozi
2013-08-07 11:09 ` Tony Lindgren
2013-08-07 13:35 ` Chen Baozi
-- strict thread matches above, loose matches on Subject: below --
2013-08-07 14:05 Chen Baozi
2013-08-21 8:03 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).