From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 12/12] usb: chipidea: udc: .pullup is valid when vbus is on at CI_HDRC_PULLUP_ON_VBUS
Date: Fri, 2 Aug 2013 16:34:05 +0800 [thread overview]
Message-ID: <1375432445-31918-13-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1375432445-31918-1-git-send-email-peter.chen@freescale.com>
When the flag CI_HDRC_PULLUP_ON_VBUS is set, .pullup should only be
called when the vbus is active. When the CI_HDRC_PULLUP_ON_VBUS
is set, the controller only begins to run when the vbus is on,
So, it is only meaningful software set pullup/pulldown after
the controller begins to run.
Tested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
drivers/usb/chipidea/udc.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 45abf4d..b7ead5f 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1514,6 +1514,10 @@ static int ci_udc_pullup(struct usb_gadget *_gadget, int is_on)
{
struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget);
+ if ((ci->platdata->flags & CI_HDRC_PULLUP_ON_VBUS)
+ && !ci->vbus_active)
+ return -EOPNOTSUPP;
+
if (is_on)
hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS);
else
--
1.7.0.4
next prev parent reply other threads:[~2013-08-02 8:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 8:33 [PATCH v14 00/12] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
2013-08-02 8:33 ` [PATCH v14 01/12] usb: chipidea: move vbus regulator operation to core Peter Chen
2013-08-02 8:33 ` [PATCH v14 02/12] usb: chipidea: host: add vbus regulator control Peter Chen
2013-08-02 8:33 ` [PATCH v14 03/12] usb: chipidea: udc: otg_set_peripheral is useless for some chipidea users Peter Chen
2013-08-02 8:33 ` [PATCH v14 04/12] usb: chipidea: otg: Add otg file used to access otgsc Peter Chen
2013-08-09 13:00 ` Alexander Shishkin
2013-08-09 11:18 ` Peter Chen
2013-08-02 8:33 ` [PATCH v14 05/12] usb: chipidea: Add role init and destory APIs Peter Chen
2013-08-02 8:33 ` [PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG Peter Chen
2013-08-09 12:55 ` Alexander Shishkin
2013-08-09 11:13 ` Peter Chen
2013-08-09 13:21 ` Alexander Shishkin
2013-08-02 8:34 ` [PATCH v14 07/12] usb: chipidea: disable all interrupts and clear all interrupts status Peter Chen
2013-08-02 8:34 ` [PATCH v14 08/12] usb: chipidea: move otg relate things to otg file Peter Chen
2013-08-09 13:09 ` Alexander Shishkin
2013-08-02 8:34 ` [PATCH v14 09/12] usb: chipidea: add vbus interrupt handler Peter Chen
2013-08-02 8:34 ` [PATCH v14 10/12] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts Peter Chen
2013-08-02 8:34 ` [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS Peter Chen
2013-08-09 13:23 ` Alexander Shishkin
2013-08-09 11:46 ` Peter Chen
2013-08-09 12:16 ` Peter Chen
2013-08-02 8:34 ` Peter Chen [this message]
2013-08-06 12:00 ` [PATCH v14 00/12] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375432445-31918-13-git-send-email-peter.chen@freescale.com \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).