linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] ARM: vexpress: TC2 MCPM/SPC cleanups
Date: Tue, 06 Aug 2013 18:06:21 +0100	[thread overview]
Message-ID: <1375808781.12043.98.camel@hornet> (raw)
In-Reply-To: <20130806165459.GB28176@e102568-lin.cambridge.arm.com>

On Tue, 2013-08-06 at 17:55 +0100, Lorenzo Pieralisi wrote:
> > And here comes the V2P-CA15_A7, also known as TC2 ;-) where the
> > interface was re-(or ab-?)used as a "convenient" communication channel
> > between the test chip and the microcontroller. And the SPC is even
> > described as "being merged" with the SCC. Uh...
> 
> Yes, the "merging" of SCC and SPC is the root cause of this hopefully happy
> ended story, they lumped together pieces of HW that should have been kept
> separate.

Show me an SOC when the silicon people didn't try to save silicon area
and pads, for the cost of "solutions" like this...

> > Now, the bottom line. How about keeping the driver look for
> > "arm,vexpress-spc,v2p-ca15_a7" because it's a driver for the SPC bit
> > after all and doing the following in the tree:
> > 
> > scc at 7fff0000 {
> > 	compatible = "arm,vexpress-scc,v2p-ca15_a7", "arm,vexpress-scc";
> > 	reg = <0x7fff0000 0x1000>;
> > 	interrupts = <0 95 4>;
> > 
> > 	spc at b00 {
> > 		compatible = "arm,vexpress-spc,v2p-ca15_a7", "arm,vexpress-spc";
> > 		reg = <0xb00 0x100>;
> > 	};
> > };
> > 
> > This, I believe, would represent the actual situation, require no change
> > in the driver (except for the retirement of SPC_BASE which is good :-)
> > and allowed as, if and when necessary, to drive the SCC as a MFD/syscon
> > device.
> 
> I do need some SCC registers to check the cluster ID against the MPIDR in
> order to carry out powerdown operations. So if we do what you suggest we have
> to change the driver, I would avoid doing that at this stage.

That's what I'm saying - if we do the binding right, you won't have to
change the driver at all. It will do the same 
	of_find_compatible_node(NULL, NULL, "arm,vexpress-spc,v2p-ca15_a7");
as previously.

Pawe?

      reply	other threads:[~2013-08-06 17:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05  4:09 [PATCH 0/3] ARM: vexpress: TC2 MCPM/SPC cleanups Olof Johansson
2013-08-05  4:09 ` [PATCH 1/3] ARM: vexpress: move spc driver back under mach-vexpress Olof Johansson
2013-08-05  9:52   ` Lorenzo Pieralisi
2013-08-05 23:26     ` Olof Johansson
2013-08-06  8:55       ` Lorenzo Pieralisi
2013-08-06 12:28         ` Pawel Moll
2013-08-05  4:09 ` [PATCH 2/3] ARM: vexpress: make spc code TC2-only Olof Johansson
2013-08-05  9:55   ` Lorenzo Pieralisi
2013-08-05 23:28     ` Olof Johansson
2013-08-05  4:09 ` [PATCH 3/3] ARM: vexpress: don't print virtual address in dmesg Olof Johansson
2013-08-05  9:47 ` [PATCH 0/3] ARM: vexpress: TC2 MCPM/SPC cleanups Lorenzo Pieralisi
2013-08-05 16:45   ` Olof Johansson
2013-08-06 16:19   ` Pawel Moll
2013-08-06 16:44     ` Olof Johansson
2013-08-06 17:03       ` Pawel Moll
2013-08-06 17:25         ` Olof Johansson
2013-08-06 17:32           ` Pawel Moll
2013-08-06 17:08       ` Lorenzo Pieralisi
2013-08-06 16:55     ` Lorenzo Pieralisi
2013-08-06 17:06       ` Pawel Moll [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375808781.12043.98.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).