[Repost PATCH] ARM: dts: imx6qdl-wandboard: add gpio lines to wandboard shared dtsi.

[Repost PATCH] ARM: dts: imx6qdl-wandboard: add gpio lines to wandboard shared dtsi.

[Michael Panetta]

This patch adds support to the wandboard shared dts file for the 10 GPIO lines that are exposed on the EDM connector.

Michael Panetta (1):
  Add dts info for wandboard GPIO lines.

 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Signed-off-by: Mike Panetta <panetta.mike@gmail.com>
-- 
1.7.11.7

[PATCH] Add dts info for wandboard GPIO lines.

[Michael Panetta]

---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index a55113e..b40bbe1 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -84,6 +84,23 @@
 			>;
 		};
 	};
+
+	gpio {
+		pinctrl_gpio: gpiogrp {
+			fsl,pins = <
+				MX6QDL_PAD_EIM_DA12__GPIO3_IO12   0x80000000 /* GPIO3_12 EDM pin 255 */
+				MX6QDL_PAD_EIM_DA11__GPIO3_IO11   0x80000000 /* GPIO3_11 EDM pin 256 */
+				MX6QDL_PAD_EIM_DA10__GPIO3_IO10   0x80000000 /* GPIO3_10 EDM pin 257 */
+				MX6QDL_PAD_EIM_D27__GPIO3_IO27    0x80000000 /* GPIO3_27 EDM pin 258 */
+				MX6QDL_PAD_EIM_D26__GPIO3_IO26    0x80000000 /* GPIO3_26 EDM pin 259 */
+				MX6QDL_PAD_EIM_BCLK__GPIO6_IO31   0x80000000 /* GPIO6_31 EDM pin 260 */
+				MX6QDL_PAD_EIM_DA8__GPIO3_IO08    0x80000000 /* GPIO3_8  EDM pin 261 */
+				MX6QDL_PAD_ENET_RX_ER__GPIO1_IO24 0x80000000 /* GPIO1_24 EDM pin 262 */
+				MX6QDL_PAD_GPIO_19__GPIO4_IO05    0x80000000 /* GPIO4_5  EDM pin 263 */
+				MX6QDL_PAD_SD3_RST__GPIO7_IO08    0x80000000 /* GPIO7_8  EDM pin 264 */
+			>;
+		};
+	};
 };
 
 &fec {
-- 
1.7.11.7

[PATCH] Add dts info for wandboard GPIO lines.

[Fabio Estevam]

Hi Michael,

The text you put in the cover letter should be present here in the
commit log of this patch.

On Tue, Aug 6, 2013 at 6:35 PM, Michael Panetta <panetta.mike@gmail.com> wrote:
> ---

You also missed the Signed-off-by line here.

>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

[PATCH] ARM: dts: imx6qdl-wandboard: add gpio lines to wandboard shared dtsi.

[Michael Panetta]

This patch adds support to the wandboard shared dts file for the 10 GPIO lines that are exposed on the EDM connector.

Michael Panetta (1):
  Add dts info for wandboard GPIO lines.

 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

-- 
1.7.11.7

[PATCH] Add dts info for wandboard GPIO lines.

[Michael Panetta]

---
 arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index a55113e..b40bbe1 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -84,6 +84,23 @@
 			>;
 		};
 	};
+
+	gpio {
+		pinctrl_gpio: gpiogrp {
+			fsl,pins = <
+				MX6QDL_PAD_EIM_DA12__GPIO3_IO12   0x80000000 /* GPIO3_12 EDM pin 255 */
+				MX6QDL_PAD_EIM_DA11__GPIO3_IO11   0x80000000 /* GPIO3_11 EDM pin 256 */
+				MX6QDL_PAD_EIM_DA10__GPIO3_IO10   0x80000000 /* GPIO3_10 EDM pin 257 */
+				MX6QDL_PAD_EIM_D27__GPIO3_IO27    0x80000000 /* GPIO3_27 EDM pin 258 */
+				MX6QDL_PAD_EIM_D26__GPIO3_IO26    0x80000000 /* GPIO3_26 EDM pin 259 */
+				MX6QDL_PAD_EIM_BCLK__GPIO6_IO31   0x80000000 /* GPIO6_31 EDM pin 260 */
+				MX6QDL_PAD_EIM_DA8__GPIO3_IO08    0x80000000 /* GPIO3_8  EDM pin 261 */
+				MX6QDL_PAD_ENET_RX_ER__GPIO1_IO24 0x80000000 /* GPIO1_24 EDM pin 262 */
+				MX6QDL_PAD_GPIO_19__GPIO4_IO05    0x80000000 /* GPIO4_5  EDM pin 263 */
+				MX6QDL_PAD_SD3_RST__GPIO7_IO08    0x80000000 /* GPIO7_8  EDM pin 264 */
+			>;
+		};
+	};
 };
 
 &fec {
-- 
1.7.11.7

[PATCH] Add dts info for wandboard GPIO lines.

[Uwe Kleine-König]

Hello,

while starting to use the GPIO lines being available on the JP4
connector of the wand board I stumbled over this patch on the linux arm
kernel mailing list:

On Wed, Jul 31, 2013 at 05:40:47PM -0400, Michael Panetta wrote:
> diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> index a55113e..b40bbe1 100644
> --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
> @@ -84,6 +84,23 @@
>  			>;
>  		};
>  	};
> +
> +	gpio {
> +		pinctrl_gpio: gpiogrp {
> +			fsl,pins = <
> +				MX6QDL_PAD_EIM_DA12__GPIO3_IO12   0x80000000 /* GPIO3_12 EDM pin 255 */

Looking at the "Wandboard User Guide, Revision B1"[1] I'd say EDM pin
255 on the board drives the signal GPIO3_11 and so TP128 on the board.
Instead it's pad MX6QDL_PAD_EIM_DA11 (and so GPIO3_IO11) that is
connected to EDM pin 256 which is called GPIO3_12 for the Wandboard.

Unless I'm failing to read the schematics, this is an unfortunate naming
mismatch that someone might want to fix?!

Best regards
Uwe

PS: The patch was never applied to the mainline kernel.

[1] http://www.wandboard.org/images/downloads/wbquad-revb1-userguide.pdf

> +				MX6QDL_PAD_EIM_DA11__GPIO3_IO11   0x80000000 /* GPIO3_11 EDM pin 256 */
> +				MX6QDL_PAD_EIM_DA10__GPIO3_IO10   0x80000000 /* GPIO3_10 EDM pin 257 */
> +				MX6QDL_PAD_EIM_D27__GPIO3_IO27    0x80000000 /* GPIO3_27 EDM pin 258 */
> +				MX6QDL_PAD_EIM_D26__GPIO3_IO26    0x80000000 /* GPIO3_26 EDM pin 259 */
> +				MX6QDL_PAD_EIM_BCLK__GPIO6_IO31   0x80000000 /* GPIO6_31 EDM pin 260 */
> +				MX6QDL_PAD_EIM_DA8__GPIO3_IO08    0x80000000 /* GPIO3_8  EDM pin 261 */
> +				MX6QDL_PAD_ENET_RX_ER__GPIO1_IO24 0x80000000 /* GPIO1_24 EDM pin 262 */
> +				MX6QDL_PAD_GPIO_19__GPIO4_IO05    0x80000000 /* GPIO4_5  EDM pin 263 */
> +				MX6QDL_PAD_SD3_RST__GPIO7_IO08    0x80000000 /* GPIO7_8  EDM pin 264 */
> +			>;
> +		};
> +	};
>  };

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |