linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: wni@nvidia.com (Wei Ni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 8 Aug 2013 14:56:29 +0800	[thread overview]
Message-ID: <1375944991-29182-2-git-send-email-wni@nvidia.com> (raw)
In-Reply-To: <1375944991-29182-1-git-send-email-wni@nvidia.com>

The device lm90 can be controlled by the vdd rail.
Adding the power control support to power on/off the vdd rail.
And make sure that power is enabled before accessing the device.

Signed-off-by: Wei Ni <wni@nvidia.com>
---
 drivers/hwmon/lm90.c |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index cdff742..306a348 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -89,6 +89,7 @@
 #include <linux/err.h>
 #include <linux/mutex.h>
 #include <linux/sysfs.h>
+#include <linux/regulator/consumer.h>
 
 /*
  * Addresses to scan
@@ -302,6 +303,7 @@ static const struct lm90_params lm90_params[] = {
 struct lm90_data {
 	struct device *hwmon_dev;
 	struct mutex update_lock;
+	struct regulator *lm90_reg;
 	char valid; /* zero until following fields are valid */
 	unsigned long last_updated; /* in jiffies */
 	int kind;
@@ -1391,6 +1393,32 @@ static void lm90_init_client(struct i2c_client *client)
 		i2c_smbus_write_byte_data(client, LM90_REG_W_CONFIG1, config);
 }
 
+static void lm90_power_control(struct i2c_client *client, bool is_enable)
+{
+	struct lm90_data *data = i2c_get_clientdata(client);
+	int ret;
+
+	if (!data->lm90_reg)
+		return;
+
+	mutex_lock(&data->update_lock);
+
+	if (is_enable)
+		ret = regulator_enable(data->lm90_reg);
+	else
+		ret = regulator_disable(data->lm90_reg);
+
+	if (ret < 0)
+		dev_err(&client->dev,
+			"Error in %s rail vdd, error %d\n",
+			(is_enable) ? "enabling" : "disabling", ret);
+	else
+		dev_info(&client->dev, "success in %s rail vdd\n",
+			 (is_enable) ? "enabling" : "disabling");
+
+	mutex_unlock(&data->update_lock);
+}
+
 static int lm90_probe(struct i2c_client *client,
 		      const struct i2c_device_id *id)
 {
@@ -1406,6 +1434,20 @@ static int lm90_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, data);
 	mutex_init(&data->update_lock);
 
+	data->lm90_reg = regulator_get(&client->dev, "vdd");
+	if (IS_ERR_OR_NULL(data->lm90_reg)) {
+		if (PTR_ERR(data->lm90_reg) == -ENODEV)
+			dev_info(&client->dev,
+				 "No regulator found for vdd. Assuming vdd is always powered.");
+		else
+			dev_warn(&client->dev,
+				 "Error [%ld] in getting the regulator handle for vdd.\n",
+				 PTR_ERR(data->lm90_reg));
+		data->lm90_reg = NULL;
+	}
+
+	lm90_power_control(client, true);
+
 	/* Set the device type */
 	data->kind = id->driver_data;
 	if (data->kind == adm1032) {
@@ -1473,6 +1515,10 @@ exit_remove_files:
 	lm90_remove_files(client, data);
 exit_restore:
 	lm90_restore_conf(client, data);
+	lm90_power_control(client, false);
+	if (data->lm90_reg)
+		regulator_put(data->lm90_reg);
+
 	return err;
 }
 
@@ -1483,6 +1529,9 @@ static int lm90_remove(struct i2c_client *client)
 	hwmon_device_unregister(data->hwmon_dev);
 	lm90_remove_files(client, data);
 	lm90_restore_conf(client, data);
+	lm90_power_control(client, false);
+	if (data->lm90_reg)
+		regulator_put(data->lm90_reg);
 
 	return 0;
 }
-- 
1.7.9.5

  reply	other threads:[~2013-08-08  6:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08  6:56 [PATCH v2 0/3] Add power control for lm90 Wei Ni
2013-08-08  6:56 ` Wei Ni [this message]
2013-08-08  7:13   ` [PATCH v2 1/3] hwmon: (lm90) Add power control Alexander Shiyan
2013-08-08  9:26     ` Wei Ni
2013-08-08  8:42   ` Guenter Roeck
2013-08-08  9:47     ` Wei Ni
2013-08-08  9:57       ` Alexander Shiyan
2013-08-08  9:59         ` Wei Ni
2013-08-08 10:07         ` Wei Ni
2013-08-08 11:23       ` Guenter Roeck
2013-08-08 17:33         ` Stephen Warren
2013-08-08 17:59           ` Guenter Roeck
2013-08-08 18:45             ` Stephen Warren
2013-08-08 17:30     ` Stephen Warren
2013-08-08 17:59       ` Guenter Roeck
2013-08-08 19:27       ` Mark Brown
2013-08-08 11:01   ` Mark Brown
2013-08-08 11:25     ` Guenter Roeck
2013-08-08 13:08       ` Mark Brown
2013-08-08 15:21         ` Guenter Roeck
2013-08-08 17:15           ` Mark Brown
2013-08-08 20:00             ` Guenter Roeck
2013-08-08 21:18               ` Mark Brown
2013-08-08 21:30                 ` Guenter Roeck
     [not found]                   ` <1376027820.695103970@f416.i.mail.ru>
2013-08-09 10:27                     ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Mark Brown
2013-08-09 10:50                       ` Alexander Shiyan
2013-08-09 11:09                         ` Mark Brown
2013-08-09  7:23     ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-09 10:56       ` Mark Brown
2013-08-08  6:56 ` [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008 Wei Ni
2013-08-08 17:35   ` Stephen Warren
2013-08-09  6:06     ` Wei Ni
2013-08-08 20:36   ` Sergei Shtylyov
2013-08-08 20:40     ` Stephen Warren
2013-08-08 21:33       ` Guenter Roeck
2013-08-09  6:16         ` Wei Ni
2013-08-08  6:56 ` [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 Wei Ni
2013-08-08 17:37   ` Stephen Warren
2013-08-09  6:10     ` Wei Ni
2013-08-09 16:35       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375944991-29182-2-git-send-email-wni@nvidia.com \
    --to=wni@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).