* [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator
@ 2013-08-09 0:23 Peter Chen
2013-08-09 2:22 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Peter Chen @ 2013-08-09 0:23 UTC (permalink / raw)
To: linux-arm-kernel
We enabled USB host 1, so host 1's vbus should be on to let
host 1 work.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 6e5dfdb..6e9d4d7 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -27,6 +27,15 @@
enable-active-high;
};
+ reg_usb_h1_vbus: usb_h1_vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb_h1_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio1 29 0>;
+ enable-active-high;
+ };
+
reg_audio: wm8962_supply {
compatible = "regulator-fixed";
regulator-name = "wm8962-supply";
@@ -125,6 +134,7 @@
};
&usbh1 {
+ vbus-supply = <®_usb_h1_vbus>;
status = "okay";
};
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator
2013-08-09 0:23 [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator Peter Chen
@ 2013-08-09 2:22 ` Fabio Estevam
2013-08-09 8:05 ` Peter Chen
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2013-08-09 2:22 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 8, 2013 at 9:23 PM, Peter Chen <peter.chen@freescale.com> wrote:
> We enabled USB host 1, so host 1's vbus should be on to let
> host 1 work.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 6e5dfdb..6e9d4d7 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -27,6 +27,15 @@
> enable-active-high;
> };
>
> + reg_usb_h1_vbus: usb_h1_vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb_h1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio1 29 0>;
You should also add en entry into pinctrl_hog for this gpio.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator
2013-08-09 2:22 ` Fabio Estevam
@ 2013-08-09 8:05 ` Peter Chen
2013-08-09 11:27 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Peter Chen @ 2013-08-09 8:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 08, 2013 at 11:22:43PM -0300, Fabio Estevam wrote:
> On Thu, Aug 8, 2013 at 9:23 PM, Peter Chen <peter.chen@freescale.com> wrote:
> > We enabled USB host 1, so host 1's vbus should be on to let
> > host 1 work.
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > ---
> > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 10 ++++++++++
> > 1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > index 6e5dfdb..6e9d4d7 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> > @@ -27,6 +27,15 @@
> > enable-active-high;
> > };
> >
> > + reg_usb_h1_vbus: usb_h1_vbus {
> > + compatible = "regulator-fixed";
> > + regulator-name = "usb_h1_vbus";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpio1 29 0>;
>
> You should also add en entry into pinctrl_hog for this gpio.
>
Thanks, Fabio. What's the rule for adding gpio function for pinctrl
at dts? At pinctrl_hog or the device's pinctrl group?
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator
2013-08-09 8:05 ` Peter Chen
@ 2013-08-09 11:27 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-08-09 11:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Aug 9, 2013 at 5:05 AM, Peter Chen <peter.chen@freescale.com> wrote:
> Thanks, Fabio. What's the rule for adding gpio function for pinctrl
> at dts? At pinctrl_hog or the device's pinctrl group?
pinctrl_hog, as each board may have a different gpio to turn on the regulator.
The pinctrl group is used for group of pins that control a peripheral,
such as spi, uart, mmc, etc.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-09 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 0:23 [PATCH 1/1] ARM: dtsi: imx6qdl-sabresd: Add USB host 1 VBUS regulator Peter Chen
2013-08-09 2:22 ` Fabio Estevam
2013-08-09 8:05 ` Peter Chen
2013-08-09 11:27 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).