* [PATCH] ARM: KVM: Simplify tracepoint text
@ 2013-08-09 3:41 Christoffer Dall
2013-08-10 19:47 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Christoffer Dall @ 2013-08-09 3:41 UTC (permalink / raw)
To: linux-arm-kernel
The tracepoint for kvm_guest_fault was extremely long, make it a
slightly bit shorter.
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
arch/arm/kvm/trace.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/kvm/trace.h b/arch/arm/kvm/trace.h
index a8e73ed..8cbaea2 100644
--- a/arch/arm/kvm/trace.h
+++ b/arch/arm/kvm/trace.h
@@ -59,10 +59,9 @@ TRACE_EVENT(kvm_guest_fault,
__entry->ipa = ipa;
),
- TP_printk("guest fault at PC %#08lx (hxfar %#08lx, "
- "ipa %#16llx, hsr %#08lx",
- __entry->vcpu_pc, __entry->hxfar,
- __entry->ipa, __entry->hsr)
+ TP_printk("ipa 0x%llx, hsr 0x%#08lx, hxfar 0x%#08lx, pc 0x%#08lx",
+ __entry->ipa, __entry->hsr,
+ __entry->hxfar, __entry->vcpu_pc)
);
TRACE_EVENT(kvm_irq_line,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: KVM: Simplify tracepoint text
2013-08-09 3:41 [PATCH] ARM: KVM: Simplify tracepoint text Christoffer Dall
@ 2013-08-10 19:47 ` Sergei Shtylyov
2013-08-12 3:41 ` Christoffer Dall
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2013-08-10 19:47 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 08/09/2013 07:41 AM, Christoffer Dall wrote:
> The tracepoint for kvm_guest_fault was extremely long, make it a
> slightly bit shorter.
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> arch/arm/kvm/trace.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
> diff --git a/arch/arm/kvm/trace.h b/arch/arm/kvm/trace.h
> index a8e73ed..8cbaea2 100644
> --- a/arch/arm/kvm/trace.h
> +++ b/arch/arm/kvm/trace.h
> @@ -59,10 +59,9 @@ TRACE_EVENT(kvm_guest_fault,
> __entry->ipa = ipa;
> ),
>
> - TP_printk("guest fault at PC %#08lx (hxfar %#08lx, "
> - "ipa %#16llx, hsr %#08lx",
> - __entry->vcpu_pc, __entry->hxfar,
> - __entry->ipa, __entry->hsr)
> + TP_printk("ipa 0x%llx, hsr 0x%#08lx, hxfar 0x%#08lx, pc 0x%#08lx",
"0x" and "#" are redundant, they mean the same thing, hexadecimal prefix.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: KVM: Simplify tracepoint text
2013-08-10 19:47 ` Sergei Shtylyov
@ 2013-08-12 3:41 ` Christoffer Dall
0 siblings, 0 replies; 3+ messages in thread
From: Christoffer Dall @ 2013-08-12 3:41 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Aug 10, 2013 at 11:47:25PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 08/09/2013 07:41 AM, Christoffer Dall wrote:
>
> >The tracepoint for kvm_guest_fault was extremely long, make it a
> >slightly bit shorter.
>
> >Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> >---
> > arch/arm/kvm/trace.h | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
>
> >diff --git a/arch/arm/kvm/trace.h b/arch/arm/kvm/trace.h
> >index a8e73ed..8cbaea2 100644
> >--- a/arch/arm/kvm/trace.h
> >+++ b/arch/arm/kvm/trace.h
> >@@ -59,10 +59,9 @@ TRACE_EVENT(kvm_guest_fault,
> > __entry->ipa = ipa;
> > ),
> >
> >- TP_printk("guest fault at PC %#08lx (hxfar %#08lx, "
> >- "ipa %#16llx, hsr %#08lx",
> >- __entry->vcpu_pc, __entry->hxfar,
> >- __entry->ipa, __entry->hsr)
> >+ TP_printk("ipa 0x%llx, hsr 0x%#08lx, hxfar 0x%#08lx, pc 0x%#08lx",
>
> "0x" and "#" are redundant, they mean the same thing, hexadecimal prefix.
>
Duh, indeed, nicely spotted. I'll respin.
Thanks,
-Christoffer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-12 3:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 3:41 [PATCH] ARM: KVM: Simplify tracepoint text Christoffer Dall
2013-08-10 19:47 ` Sergei Shtylyov
2013-08-12 3:41 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).