From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] pinctrl: imx: Catch no fsl,pins property
Date: Fri, 9 Aug 2013 14:20:51 +0200 [thread overview]
Message-ID: <1376050854-3303-3-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1376050854-3303-1-git-send-email-s.hauer@pengutronix.de>
Instead of crashing the kernel print an error message when
the fsl,pins property is missing.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/pinctrl/pinctrl-imx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index b063189..780b197 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -426,6 +426,11 @@ static int imx_pinctrl_parse_groups(struct device_node *np,
* do sanity check and calculate pins number
*/
list = of_get_property(np, "fsl,pins", &size);
+ if (!list) {
+ dev_err(info->dev, "no fsl,pins property in node %s\n", np->full_name);
+ return -EINVAL;
+ }
+
/* we do not check return since it's safe node passed down */
if (!size || size % pin_size) {
dev_err(info->dev, "Invalid fsl,pins property in node %s\n", np->full_name);
--
1.8.4.rc1
next prev parent reply other threads:[~2013-08-09 12:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 12:20 [PATCH] pinctrl: i.MX: Make more robust against devicetree errors Sascha Hauer
2013-08-09 12:20 ` [PATCH 1/5] pinctrl: imx: make error messages more informative Sascha Hauer
2013-08-14 20:33 ` Linus Walleij
2013-08-09 12:20 ` Sascha Hauer [this message]
2013-08-14 20:34 ` [PATCH 2/5] pinctrl: imx: Catch no fsl,pins property Linus Walleij
2013-08-09 12:20 ` [PATCH 3/5] pinctrl: imx: do not fail when parsing a group fails Sascha Hauer
2013-08-14 20:35 ` Linus Walleij
2013-08-09 12:20 ` [PATCH 4/5] pinctrl: imx: do not fail when parsing a function fails Sascha Hauer
2013-08-14 20:37 ` Linus Walleij
2013-08-15 5:04 ` Sascha Hauer
2013-08-15 20:10 ` Linus Walleij
2013-08-09 12:20 ` [PATCH 5/5] pinctrl: imx: Use struct type for pins Sascha Hauer
2013-08-14 20:41 ` Linus Walleij
2013-08-15 5:08 ` Sascha Hauer
2013-08-15 20:11 ` Linus Walleij
2013-08-16 6:37 ` Sascha Hauer
2013-08-16 12:43 ` Linus Walleij
2013-08-12 7:49 ` [PATCH] pinctrl: i.MX: Make more robust against devicetree errors Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376050854-3303-3-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).