linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] pinctrl: imx: do not fail when parsing a function fails
Date: Fri,  9 Aug 2013 14:20:53 +0200	[thread overview]
Message-ID: <1376050854-3303-5-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1376050854-3303-1-git-send-email-s.hauer@pengutronix.de>

When parsing a function fails this is no reason to make the whole
driver fail. Just continue with the next function.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/pinctrl/pinctrl-imx.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index e876122..f3c38e0 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
@@ -520,7 +520,6 @@ static int imx_pinctrl_probe_dt(struct platform_device *pdev,
 {
 	struct device_node *np = pdev->dev.of_node;
 	struct device_node *child;
-	int ret;
 	u32 nfuncs = 0;
 	u32 i = 0;
 
@@ -547,13 +546,8 @@ static int imx_pinctrl_probe_dt(struct platform_device *pdev,
 	if (!info->groups)
 		return -ENOMEM;
 
-	for_each_child_of_node(np, child) {
-		ret = imx_pinctrl_parse_functions(child, info, i++);
-		if (ret) {
-			dev_err(&pdev->dev, "failed to parse function\n");
-			return ret;
-		}
-	}
+	for_each_child_of_node(np, child)
+		imx_pinctrl_parse_functions(child, info, i++);
 
 	return 0;
 }
-- 
1.8.4.rc1

  parent reply	other threads:[~2013-08-09 12:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09 12:20 [PATCH] pinctrl: i.MX: Make more robust against devicetree errors Sascha Hauer
2013-08-09 12:20 ` [PATCH 1/5] pinctrl: imx: make error messages more informative Sascha Hauer
2013-08-14 20:33   ` Linus Walleij
2013-08-09 12:20 ` [PATCH 2/5] pinctrl: imx: Catch no fsl,pins property Sascha Hauer
2013-08-14 20:34   ` Linus Walleij
2013-08-09 12:20 ` [PATCH 3/5] pinctrl: imx: do not fail when parsing a group fails Sascha Hauer
2013-08-14 20:35   ` Linus Walleij
2013-08-09 12:20 ` Sascha Hauer [this message]
2013-08-14 20:37   ` [PATCH 4/5] pinctrl: imx: do not fail when parsing a function fails Linus Walleij
2013-08-15  5:04     ` Sascha Hauer
2013-08-15 20:10       ` Linus Walleij
2013-08-09 12:20 ` [PATCH 5/5] pinctrl: imx: Use struct type for pins Sascha Hauer
2013-08-14 20:41   ` Linus Walleij
2013-08-15  5:08     ` Sascha Hauer
2013-08-15 20:11       ` Linus Walleij
2013-08-16  6:37         ` Sascha Hauer
2013-08-16 12:43           ` Linus Walleij
2013-08-12  7:49 ` [PATCH] pinctrl: i.MX: Make more robust against devicetree errors Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376050854-3303-5-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).