From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 03/13] usb: chipidea: udc: otg_set_peripheral is useless for some chipidea users
Date: Mon, 12 Aug 2013 09:22:49 +0800 [thread overview]
Message-ID: <1376270579-13493-4-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1376270579-13493-1-git-send-email-peter.chen@freescale.com>
It is useless at below cases:
- If we implement both usb host and device at chipidea driver.
- If we don't need phy->otg.
Tested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
drivers/usb/chipidea/udc.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index e475fcd..116c762 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1805,7 +1805,12 @@ static int udc_start(struct ci_hdrc *ci)
if (ci->transceiver) {
retval = otg_set_peripheral(ci->transceiver->otg,
&ci->gadget);
- if (retval)
+ /*
+ * If we implement all USB functions using chipidea drivers,
+ * it doesn't need to call above API, meanwhile, if we only
+ * use gadget function, calling above API is useless.
+ */
+ if (retval && retval != -ENOTSUPP)
goto put_transceiver;
}
--
1.7.1
next prev parent reply other threads:[~2013-08-12 1:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 1:22 [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
2013-08-12 1:22 ` [PATCH v15 01/13] usb: chipidea: move vbus regulator operation to core Peter Chen
2013-08-12 1:22 ` [PATCH v15 02/13] usb: chipidea: host: add vbus regulator control Peter Chen
2013-08-12 1:22 ` Peter Chen [this message]
2013-08-12 1:22 ` [PATCH v15 04/13] usb: chipidea: otg: Add otg file used to access otgsc Peter Chen
2013-08-12 1:22 ` [PATCH v15 05/13] usb: chipidea: Add role init and destroy APIs Peter Chen
2013-08-12 1:22 ` [PATCH v15 06/13] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG Peter Chen
2013-08-12 1:22 ` [PATCH v15 07/13] usb: chipidea: disable all interrupts and clear all interrupts status Peter Chen
2013-08-12 1:22 ` [PATCH v15 08/13] usb: chipidea: move otg related things to otg file Peter Chen
2013-08-12 1:22 ` [PATCH v15 09/13] usb: chipidea: add vbus interrupt handler Peter Chen
2013-08-12 1:22 ` [PATCH v15 10/13] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts Peter Chen
2013-08-12 1:22 ` [PATCH v15 11/13] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS Peter Chen
2013-08-12 1:22 ` [PATCH v15 12/13] usb: chipidea: retire flag CI_HDRC_PULLUP_ON_VBUS Peter Chen
2013-08-12 1:22 ` [PATCH v15 13/13] usb: chipidea: udc: .pullup is valid only when vbus is there Peter Chen
2013-08-13 23:43 ` [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea Peter Chen
2013-08-14 9:48 ` Alexander Shishkin
2013-08-26 16:06 ` Hector Palacios
2013-08-26 16:24 ` Hector Palacios
2013-08-27 2:51 ` Peter Chen
2013-08-27 7:06 ` Hector Palacios
2013-08-27 8:09 ` Alexander Shishkin
2013-08-27 8:12 ` Hector Palacios
2013-08-27 10:20 ` Hector Palacios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376270579-13493-4-git-send-email-peter.chen@freescale.com \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).