From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] MFD: Make VEXPRESS MFD controller depends on VEXPRESS systems
Date: Mon, 12 Aug 2013 14:11:41 +0100 [thread overview]
Message-ID: <1376313101.13400.2.camel@hornet> (raw)
In-Reply-To: <1376312115-10326-1-git-send-email-manjunath.goudar@linaro.org>
On Mon, 2013-08-12 at 13:55 +0100, Manjunath Goudar wrote:
> This patch adds a of_find_node_by_phandle() and of_get_next_parent()
> function declaration dependence on"#ifdef CONFIG_OF" in "include/linux/of.h"
> else part return inline dummy implementations (returning NULL). Without
> this patch,build system can lead to issues. This was discovered during
> randconfig testing,in which VEXPRESS_CONFIG was enabled w/o CONFIG_OF
> being enabled,leading to the following error:
>
> CC drivers/mfd/vexpress-config.o
> drivers/mfd/vexpress-config.c: In function ?__vexpress_config_func_get?:
> drivers/mfd/vexpress-config.c:117:4: error: implicit declaration of function
> ?of_find_node_by_phandle? [-Werror=implicit-function-declaration]
> bridge_node = of_find_node_by_phandle(
> ^
> drivers/mfd/vexpress-config.c:117:16: warning: assignment makes pointer from
> integer without a cast [enabled by default]
> bridge_node = of_find_node_by_phandle(
>
> Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Deepak Saxena <dsaxena@linaro.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
>
> V2:
> -Made of_find_node_by_phandle() and of_get_next_parent() function declaration
> dependence on"#ifdef CONFIG_OF" in "include/linux/of.h" instead of Kconfig
> dependence setting in V1 patch and else part return inline dummy implementations
> (returning NULL) to fix the above randconfig error.
> ---
> include/linux/of.h | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
It's all cool, but the subject line doesn't make any sense now, does
it? ;-) As in: it's not a vexpress- nor mfd-related patch any more.
Pawel
prev parent reply other threads:[~2013-08-12 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375592514-14213-1-git-send-email-manjunath.goudar@linaro.org>
2013-08-12 12:55 ` [PATCH V2] MFD: Make VEXPRESS MFD controller depends on VEXPRESS systems Manjunath Goudar
2013-08-12 13:11 ` Pawel Moll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376313101.13400.2.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).