From: behanw@converseincode.com (behanw at converseincode.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: LLVMLinux: Change "extern inline" to "gnu_inline" in ARM ftrace.h
Date: Wed, 14 Aug 2013 17:37:41 -0400 [thread overview]
Message-ID: <1376516261-2071-2-git-send-email-behanw@converseincode.com> (raw)
In-Reply-To: <1376516261-2071-1-git-send-email-behanw@converseincode.com>
From: Mark Charlebois <charlebm@gmail.com>
With compilers which follow the C99 standard (like modern versions of gcc and
clang), "extern inline" does the wrong thing (emits code for an externally
linkable version of the inline function). In this case using the gnu_inline
attribute makes inline do the right thing on gcc and on clang.
Signed-off-by: Mark Charlebois <charlebm@gmail.com>
Signed-off-by: Behan Webster <behanw@converseincode.com>
---
arch/arm/include/asm/ftrace.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/ftrace.h b/arch/arm/include/asm/ftrace.h
index f89515a..fb7fdc4 100644
--- a/arch/arm/include/asm/ftrace.h
+++ b/arch/arm/include/asm/ftrace.h
@@ -45,7 +45,8 @@ void *return_address(unsigned int);
#else
-extern inline void *return_address(unsigned int level)
+extern inline __attribute__((gnu_inline))
+void *return_address(unsigned int level)
{
return NULL;
}
--
1.8.1.2
next prev parent reply other threads:[~2013-08-14 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 21:37 [PATCH] Fix extern inline in ftrace.h for ARM behanw at converseincode.com
2013-08-14 21:37 ` behanw at converseincode.com [this message]
2013-08-14 21:51 ` [PATCH] ARM: LLVMLinux: Change "extern inline" to "gnu_inline" in ARM ftrace.h David Daney
2013-08-14 21:56 ` Joe Perches
2013-08-14 22:15 ` Stephen Boyd
2013-08-14 22:45 ` Russell King - ARM Linux
2013-09-06 1:10 ` Behan Webster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376516261-2071-2-git-send-email-behanw@converseincode.com \
--to=behanw@converseincode.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).