[PATCH] ARM: fiq: Cast the first argument of flush_icache_range()

[PATCH] ARM: fiq: Cast the first argument of flush_icache_range()

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Commit 2ba85e7af4 (ARM: Fix FIQ code on VIVT CPUs) causes the following build
warning:

arch/arm/kernel/fiq.c: In function 'set_fiq_handler':
arch/arm/kernel/fiq.c:92:3: warning: passing argument 1 of 'cpu_cache.coherent_kern_range' makes integer from pointer without a cast [enabled by default]
arch/arm/kernel/fiq.c:92:3: note: expected 'long unsigned int' but argument is of type 'void *'

Cast it as '(unsigned long)base' to avoid the warning.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/kernel/fiq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/fiq.c b/arch/arm/kernel/fiq.c
index fc79202..d6515b9 100644
--- a/arch/arm/kernel/fiq.c
+++ b/arch/arm/kernel/fiq.c
@@ -89,7 +89,8 @@ void set_fiq_handler(void *start, unsigned int length)
 
 	memcpy(base + offset, start, length);
 	if (!cache_is_vipt_nonaliasing())
-		flush_icache_range(base + offset, offset + length);
+		flush_icache_range((unsigned long)base + offset, offset +
+				   length);
 	flush_icache_range(0xffff0000 + offset, 0xffff0000 + offset + length);
 }
 
-- 
1.8.1.2

[PATCH] ARM: fiq: Cast the first argument of flush_icache_range()

[Olof Johansson]

On Thu, Aug 15, 2013 at 5:35 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Commit 2ba85e7af4 (ARM: Fix FIQ code on VIVT CPUs) causes the following build
> warning:
>
> arch/arm/kernel/fiq.c: In function 'set_fiq_handler':
> arch/arm/kernel/fiq.c:92:3: warning: passing argument 1 of 'cpu_cache.coherent_kern_range' makes integer from pointer without a cast [enabled by default]
> arch/arm/kernel/fiq.c:92:3: note: expected 'long unsigned int' but argument is of type 'void *'
>
> Cast it as '(unsigned long)base' to avoid the warning.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Olof Johansson <olof@lixom.net>

This warning just showed up on mainline with the last arm fixes.
Please send to the patch tracker.


-Olof

[PATCH] ARM: fiq: Cast the first argument of flush_icache_range()

[Fabio Estevam]

On Sat, Aug 17, 2013 at 1:24 AM, Olof Johansson <olof@lixom.net> wrote:
> On Thu, Aug 15, 2013 at 5:35 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Commit 2ba85e7af4 (ARM: Fix FIQ code on VIVT CPUs) causes the following build
>> warning:
>>
>> arch/arm/kernel/fiq.c: In function 'set_fiq_handler':
>> arch/arm/kernel/fiq.c:92:3: warning: passing argument 1 of 'cpu_cache.coherent_kern_range' makes integer from pointer without a cast [enabled by default]
>> arch/arm/kernel/fiq.c:92:3: note: expected 'long unsigned int' but argument is of type 'void *'
>>
>> Cast it as '(unsigned long)base' to avoid the warning.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Acked-by: Olof Johansson <olof@lixom.net>
>
> This warning just showed up on mainline with the last arm fixes.
> Please send to the patch tracker.

Yes, I have already sent it to the patch system:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7819/1

Regards,

Fabio Estevam