From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 6/8] ASoC: fsl-ssi: add SSIEN errata work around
Date: Mon, 19 Aug 2013 17:05:59 +0200 [thread overview]
Message-ID: <1376924761-4054-7-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1376924761-4054-1-git-send-email-mpa@pengutronix.de>
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
The chip errata for the i.MX35, Rev.2 has the following errata:
ENGcm06222: SSI:Transmission does not take place in bit length early frame sync
configuration
The workaround states, that TX_EN and SSI_EN bits should be set in the same
register write. As the next errata in the document (ENGcm06532) says to always
write RX_EN and TX_EN in the same register write in network mode.
Therefore include the whole write to
CCSR_SSI_SCR_TE and CCSR_SSI_SCR_RE
into the write to
CCSR_SSI_SCR_SSIEN
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
sound/soc/fsl/fsl_ssi.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 827af75..3af15e9 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -424,15 +424,12 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private)
write_ssi(0x300, &ssi->saccen);
/*
- * Enable SSI
+ * Enable SSI, Transmit and Receive
*/
- write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_SSIEN);
- write_ssi(CCSR_SSI_SOR_WAIT(3), &ssi->sor);
+ write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_SSIEN |
+ CCSR_SSI_SCR_TE | CCSR_SSI_SCR_RE);
- /*
- * Enable Transmit and Receive
- */
- write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TE | CCSR_SSI_SCR_RE);
+ write_ssi(CCSR_SSI_SOR_WAIT(3), &ssi->sor);
}
return 0;
--
1.8.4.rc3
next prev parent reply other threads:[~2013-08-19 15:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 15:05 [PATCH v11 0/7] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 1/8] ASoC: imx-pcm-dma: Add missing include Markus Pargmann
2013-08-19 16:42 ` Mark Brown
2013-08-19 15:05 ` [PATCH v11 2/8] ASoC: core: Generic ac97 link reset functions Markus Pargmann
2013-08-20 10:22 ` Mark Brown
2014-06-18 18:42 ` S. Fricke
2014-06-18 21:19 ` Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 3/8] ASoC: generic: simple DT sound card Markus Pargmann
2013-08-23 9:58 ` Mark Brown
2013-08-31 7:17 ` Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 4/8] ASoC: fsl: Kconfig, visible config items for simple card Markus Pargmann
2013-08-19 15:05 ` [PATCH v11 5/8] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-08-22 10:09 ` Mark Brown
2013-08-19 15:05 ` Markus Pargmann [this message]
2013-08-22 10:10 ` [PATCH v11 6/8] ASoC: fsl-ssi: add SSIEN errata work around Mark Brown
2013-08-19 15:06 ` [PATCH v11 7/8] ASoC: fsl-ssi: imx-pcm-fiq bugfix Markus Pargmann
2013-08-22 10:10 ` Mark Brown
2013-08-19 15:06 ` [PATCH v11 8/8] ASoC: fsl: disable ssi irq for imx Markus Pargmann
2013-08-22 10:11 ` Mark Brown
2013-08-19 15:13 ` [PATCH v11 0/7] ASoC: fsl-ssi: ac97-slave support Marc Kleine-Budde
2013-08-19 15:13 ` Marc Kleine-Budde
2013-08-19 15:29 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376924761-4054-7-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).