linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/4] clocksource: dw_apb_timer: Move timer defines to header file.
Date: Thu, 22 Aug 2013 11:19:21 -0500	[thread overview]
Message-ID: <1377188361.30624.18.camel@linux-builds1> (raw)
In-Reply-To: <20130822110118.GB19347@amd.pavel.ucw.cz>

On Thu, 2013-08-22 at 13:01 +0200, ZY - pavel wrote:
> Hi!
> 
> On Wed 2013-08-21 15:53:46, dinguyen at altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> > 
> > Move all dw_apb_timer defines to include/linux/dw_apb_timer.h.
> 
> That makes sense. But the changelog says "move" while the patch only
> adds them to second place, which can not be right.

Oops, must not have saved on one of my shells. Thanks for the review.
Will post a v4 asap.

> 
> Is there public git tree with the patches somewhere?

git://git.rocketboards.org/linux-socfpga-next.git

Dinh
> 
> Thanks,
> 								Pavel
> 
> > ---
> >  include/linux/dw_apb_timer.h |   19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/include/linux/dw_apb_timer.h b/include/linux/dw_apb_timer.h
> > index 1f79b20..1d2b949 100644
> > --- a/include/linux/dw_apb_timer.h
> > +++ b/include/linux/dw_apb_timer.h
> > @@ -19,6 +19,25 @@
> >  
> >  #define APBTMRS_REG_SIZE       0x14
> >  
> > +#define APBT_MIN_PERIOD                 4
> > +#define APBT_MIN_DELTA_USEC             200
> > +
> > +#define APBTMR_N_LOAD_COUNT             0x00
> > +#define APBTMR_N_CURRENT_VALUE          0x04
> > +#define APBTMR_N_CONTROL                0x08
> > +#define APBTMR_N_EOI                    0x0c
> > +#define APBTMR_N_INT_STATUS             0x10
> > +
> > +#define APBTMRS_INT_STATUS              0xa0
> > +#define APBTMRS_EOI                     0xa4
> > +#define APBTMRS_RAW_INT_STATUS          0xa8
> > +#define APBTMRS_COMP_VERSION            0xac
> > +
> > +#define APBTMR_CONTROL_ENABLE           (1 << 0)
> > +/* 1: periodic, 0:free running. */
> > +#define APBTMR_CONTROL_MODE_PERIODIC    (1 << 1)
> > +#define APBTMR_CONTROL_INT              (1 << 2)
> > +
> >  struct dw_apb_timer {
> >  	void __iomem				*base;
> >  	unsigned long				freq;
> 

  reply	other threads:[~2013-08-22 16:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 20:53 [PATCHv3 1/4] arm: dts: Add clock entries for timers in SOCFPGA dinguyen at altera.com
2013-08-21 20:53 ` [PATCHv3 2/4] arm: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen at altera.com
2013-08-21 20:53 ` [PATCHv3 3/4] clocksource: dw_apb_timer: Move timer defines to header file dinguyen at altera.com
2013-08-22 11:01   ` Pavel Machek
2013-08-22 16:19     ` Dinh Nguyen [this message]
2013-08-21 20:53 ` [PATCHv3 4/4] clocksource: dw_apb_timer_of: Fix read_sched_clock dinguyen at altera.com
2013-08-22 10:52 ` [PATCHv3 1/4] arm: dts: Add clock entries for timers in SOCFPGA Pavel Machek
2013-08-28 15:31 ` Steffen Trumtrar
2013-08-29 15:55   ` Dinh Nguyen
2013-08-29 19:20     ` Steffen Trumtrar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377188361.30624.18.camel@linux-builds1 \
    --to=dinguyen@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).