From mboxrd@z Thu Jan  1 00:00:00 1970
From: dinguyen@altera.com (Dinh Nguyen)
Date: Thu, 22 Aug 2013 17:55:36 -0500
Subject: [PATCHv4 2/4] arm: dts: Change dw-apb-timer-osc and
 dw-apb-timer-sp to just dw-apb-timer
In-Reply-To: <52168E96.3020702@wwwdotorg.org>
References: <1377189026-16656-1-git-send-email-dinguyen@altera.com>
 <1377189026-16656-2-git-send-email-dinguyen@altera.com>
 <52168E96.3020702@wwwdotorg.org>
Message-ID: <1377212136.30624.41.camel@linux-builds1>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, 2013-08-22 at 16:20 -0600, Stephen Warren wrote:
> On 08/22/2013 10:30 AM, dinguyen at altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> > 
> > "dw-apb-timer-osc" and "dw-apb-timer-sp" are the same implementation of the
> > DW APB timer, just fed by different clocks. Thus, deprecate both
> > "dw-apb-timer-osc" and "dw-apb-timer-sp" in lieu of "dw-apb-timer".
> 
> The binding change looks reasonable to me.
> 
> The *.dtsi change will cause the new DT not to work with older kernels
> that don't support the new compatible values. Perhaps you're fine with that?

I am okay with the older kernels not working as SOCFPGA is pretty new
and older kernel don't really have too much support for it.

> 
> I assume that the driver has already been updated to support the new
> values, and that the driver change is guaranteed to be merged before
> this change? Otherwise, git bisect will be broken for a while.

Yes, the patch to update the driver was part of this series, but not
merged yet. The driver's V1 patch was Acked-By: Jamie Iles who is the
maintainer for Picoxcell and is the only other platform using this timer
driver at the moment. The only changes since V1 is to maintain
compatibility for the new binding values.

Thanks,
Dinh
>